Skip to content

[XY] Fix point visibility when Show dots toggle is off #222557

@andrimal

Description

@andrimal

Kibana version: main

Describe the bug:

While I was working on adding a point visibility option to the Appearance configuration for Lens Line/Area chart for (#222187) I noticed that in Legacy viz Line/Area chart when the Show dots toggle is off, then the point visibility is set to auto as shown in the below gif.

This was introduced in this PR #197828 to enhance point visibility for Lens Line/Area charts.

Currently in src/platform/plugins/shared/chart_expressions/expression_xy/public/helpers/data_layers.tsx:
visible: pointVisibility ?? (showPoints || markSizeAccessor ? 'always' : 'auto')

Expected behavior: Now that the Point visibility option has been added for Lens charts, should we change the point visibility for Legacy charts to never instead of auto when toggle is off (pointVisibility is undefined and showPoints is false)?

Screenshots (if relevant):

Image

Metadata

Metadata

Assignees

Labels

Feature:Vis EditorVisualization editor issuesTeam:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//bugFixes for quality problems that affect the customer experienceimpact:lowAddressing this issue will have a low level of impact on the quality/strength of our product.loe:smallSmall Level of Effort

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions