Summary

Kibana version: 8.10.0+

Describe the bug:
The data views swap_references API does not handle hidden saved objects, meaning some references (e.g. alerting rules) can be missed and left dangling after swapping references.

For example, this request:

POST /api/data_views/swap_references/_preview
{
     "fromId" : "90943e30-9a47-11e8-b64d-95841ca0b247",
     "toId" : "d3d7af60-4c81-11e8-b3d7-01146121b73d"
}

Returns this response:

{
  "result": [
    {
      "id": "06cf9c40-9ee8-11e7-8711-e7a007dcef99",
      "type": "visualization"
    },
    {
      "id": "16b1d7d0-ea71-11eb-8b4b-f7b600de0f7d",
      "type": "lens"
    },
    {
      "id": "edf84fe0-e1a0-11e7-b6d5-4dc382ef7f5b",
      "type": "dashboard"
    },
    {
      "id": "de71f4f0-1902-11e9-919b-ffe5949a18d2",
      "type": "map"
    }
  ]
}

When it should actually return this response including the hidden alert saved object:

{
  "result": [
    {
      "id": "730c7728-e71e-4dd0-8998-4f9f1a5f4279",
      "type": "alert"
    },
    {
      "id": "06cf9c40-9ee8-11e7-8711-e7a007dcef99",
      "type": "visualization"
    },
    {
      "id": "16b1d7d0-ea71-11eb-8b4b-f7b600de0f7d",
      "type": "lens"
    },
    {
      "id": "edf84fe0-e1a0-11e7-b6d5-4dc382ef7f5b",
      "type": "dashboard"
    },
    {
      "id": "de71f4f0-1902-11e9-919b-ffe5949a18d2",
      "type": "map"
    }
  ]
}

Steps to reproduce:

1. Create a data view referenced by at least one hidden saved object (e.g. an alerting rule targeting the data view).
2. Create another data view to use as the target when swapping references.
3. Make a request to the swap_references API like this:

POST /api/data_views/swap_references/_preview
{
     "fromId" : "{SOURCE_DATA_VIEW_ID}",
     "toId" : "{TARGET_DATA_VIEW_ID}"
}

4. Observe that the result array in the response does not include any hidden saved objects.

Expected behavior:
It should be possible to swap all saved object references, including for hidden saved objects, through the swap_references API.

Any additional context:
The current behaviour is a bug, but it could be possible that some consumers are depending on it working this way (seems unlikely though, it's pretty misleading right now). If we're concerned that changing the default behaviour could be a breaking change, we could consider instead supporting an includeHiddenObjects param or similar to enable it.

Hidden saved object approvals

We are tracking approvals from owning teams to include their existing hidden saved objects in the swap_references API. We believe this is the correct behaviour for the API given the dangling references bug outlined in this issue, but to be sure, we'd like to get each team's explicit approval.

Once the owning team has reviewed their hidden saved objects listed below, please check yourselves off the list to help with tracking. If you feel any or all of your hidden saved objects should not be included in the swap_references API, please leave a comment on this issue explaining why to discuss.

Approvals list

• @elastic/response-ops (11 types)

Plugin kibana.jsonc files:

• Actions: x-pack/platform/plugins/shared/actions/kibana.jsonc
• Alerting: x-pack/platform/plugins/shared/alerting/kibana.jsonc
• Task Manager: x-pack/platform/plugins/shared/task_manager/kibana.jsonc

• @elastic/kibana-cases (7 types)

Plugin kibana.jsonc: x-pack/platform/plugins/shared/cases/kibana.jsonc

• @elastic/kibana-core (5 types)

Plugin kibana.jsonc files:

• Cloud: x-pack/platform/plugins/shared/cloud/kibana.jsonc
• Core usage stats: Core Kibana (no plugin kibana.jsonc)
• Dynamic config: Core Kibana (no plugin kibana.jsonc)
• Event loop delays: src/platform/plugins/private/kibana_usage_collection/kibana.jsonc
• Telemetry: src/platform/plugins/shared/telemetry/kibana.jsonc

• @elastic/appex-sharedux (5 types)

Plugin kibana.jsonc files:

• Content Management: src/platform/plugins/shared/content_management/kibana.jsonc
• Files: src/platform/plugins/shared/files/kibana.jsonc
• Intercepts: x-pack/platform/plugins/private/intercepts/kibana.jsonc

• @elastic/kibana-security (2 types)

Plugin kibana.jsonc: x-pack/platform/plugins/shared/spaces/kibana.jsonc

• @elastic/security-solution (2 types)

Plugin kibana.jsonc: x-pack/solutions/security/plugins/security_solution/kibana.jsonc

• @elastic/fleet (2 types)

Plugin kibana.jsonc: x-pack/platform/plugins/shared/fleet/kibana.jsonc

• @elastic/kibana-management (2 types)

Plugin kibana.jsonc: x-pack/platform/plugins/private/upgrade_assistant/kibana.jsonc

• @elastic/kibana-visualizations, @elastic/kibana-data-discovery (1 type)

Plugin kibana.jsonc: src/platform/plugins/shared/data/kibana.jsonc

• @elastic/obs-entities (1 type)

Plugin kibana.jsonc: x-pack/platform/plugins/shared/entity_manager/kibana.jsonc

• @elastic/contextual-security-apps (1 type)

Plugin kibana.jsonc: x-pack/solutions/security/plugins/cloud_security_posture/kibana.jsonc

• @elastic/stack-monitoring (1 type)

Plugin kibana.jsonc: x-pack/platform/plugins/private/monitoring/kibana.jsonc

• @elastic/appex-ai-infra (1 type)

Plugin kibana.jsonc: x-pack/platform/plugins/shared/ai_infra/product_doc_base/kibana.jsonc

• @elastic/obs-ux-management-team (1 type)

Plugin kibana.jsonc: x-pack/solutions/observability/plugins/synthetics/kibana.jsonc