Skip to content

Small UI fixes for new Space creation/settings page#197303

Merged
ek-so merged 12 commits intoelastic:mainfrom
ek-so:spaces-ui-fixes
Oct 24, 2024
Merged

Small UI fixes for new Space creation/settings page#197303
ek-so merged 12 commits intoelastic:mainfrom
ek-so:spaces-ui-fixes

Conversation

@ek-so
Copy link
Contributor

@ek-so ek-so commented Oct 22, 2024 •
edited
Loading

Summary

According to this PRD.

  • Solution selection inside space settings is now full width (point 7)
  • "Solution view" in features visibility section is not bold anymore (point 8)
  • Slightly tweaked placement for header and badges (point 14)

CleanShot 2024-10-22 at 18 47 34@2x
@ek-so ek-so changed the title Solution picker full width Oct 22, 2024
@ek-so ek-so marked this pull request as ready for review October 22, 2024 16:46
@ek-so ek-so requested a review from a team as a code owner October 22, 2024 16:47
@ek-so ek-so added the backport This PR is a backport of another PR label Oct 22, 2024
@kc13greiner kc13greiner self-requested a review October 22, 2024 16:58
@ek-so ek-so changed the title Small UI fixes for new Spaces functionality Oct 23, 2024
@ek-so ek-so changed the title Small UI fixes for new Spaces functionality [Space details page] Oct 23, 2024
@ek-so ek-so changed the title Small UI fixes for new Space settings/ page Oct 23, 2024
@ek-so ek-so changed the title Small UI fixes for new Space creatin/settings page Oct 23, 2024
kc13greiner
kc13greiner approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@ek-so ek-so added backport:skip This PR does not require backporting and removed backport This PR is a backport of another PR labels Oct 23, 2024
@ek-so
Copy link
Contributor Author

ek-so commented Oct 23, 2024

@elasticmachine merge upstream
@kc13greiner
Copy link
Contributor

kc13greiner commented Oct 23, 2024

Heya @ek-so !

You need to update the associated snapshot for the Jest test:
Screenshot 2024-10-23 at 3 59 44 PM

You can do so by running this command and pushing the changes to this PR:
node scripts/jest -u x-pack/plugins/spaces/public/management/components/enabled_features/enabled_features.test.tsx
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #34 / Cloud Security Posture Test adding Cloud Security Posture Integrations CSPM AWS CIS_AWS Organization Cloud Formation Clicking on Launch CloudFormation on post intall modal should lead user to Cloud Formation page

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
spaces 256.4KB 256.5KB +96.0B

History
@ek-so ek-so merged commit aaa9604 into elastic:main Oct 24, 2024
@ek-so
Copy link
Contributor Author

ek-so commented Oct 24, 2024 •
edited
Loading

@kc13greiner thanks a lot! All good now 🙂
@ek-so ek-so deleted the spaces-ui-fixes branch November 11, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:fix v9.0.0

4 participants

@ek-so @kc13greiner @elasticmachine @kibanamachine