[ML] Removing use of ignore_throttled#199107
Merged
jgowdyelastic merged 11 commits intoelastic:mainfrom Nov 22, 2024
Merged
Conversation
jgowdyelastic
added
release_note:enhancement
:ml
v9.0.0
v8.17.0
backport:version
Contributor
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Nov 19, 2024
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested (cloning jobs created previously with ignore_throttled in the datafeed config) and LGTM
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
removed
the
backport missing
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
`ignore_throttled` is being removed, we can remove it from the various searches we run. I'm leaving it in the schema for the datafeed config for now, just in case we have a situation where a very old job is used in the UI with an endpoint which validates the datafeed config. Even though the setting would be ignored, we don't want the route to reject the datafeed because it doesn't know what `ignore_throttled` is. When cloning very old jobs jobs, I'm removing `ignore_throttled` from the `indices_options` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
`ignore_throttled` is being removed, we can remove it from the various searches we run. I'm leaving it in the schema for the datafeed config for now, just in case we have a situation where a very old job is used in the UI with an endpoint which validates the datafeed config. Even though the setting would be ignored, we don't want the route to reject the datafeed because it doesn't know what `ignore_throttled` is. When cloning very old jobs jobs, I'm removing `ignore_throttled` from the `indices_options` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignore_throttledis being removed, we can remove it from the various searches we run.I'm leaving it in the schema for the datafeed config for now, just in case we have a situation where a very old job is used in the UI with an endpoint which validates the datafeed config. Even though the setting would be ignored, we don't want the route to reject the datafeed because it doesn't know what
ignore_throttledis.When cloning very old jobs jobs, I'm removing
ignore_throttledfrom theindices_options