[Fleet] Remove deprecated topics property for kafka output in favor of topic#199226
Conversation
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --update'
… src/core/server/integration_tests/ci_checks'
…nchaulet/kibana into feature-remove-deprecated-kafka-topics
nchaulet
added
release_note:breaking
backport:skip
|
Pinging @elastic/fleet (Team:Fleet) |
| outputDoc.attributes.topic = outputDoc.attributes.topics?.filter((t) => !t.when)?.[0]?.topic; | ||
| } | ||
|
|
||
| delete outputDoc.attributes.topics; |
There was a problem hiding this comment.
The fact that we're removing this field makes it non-BWC. I wonder if we can perform the migration in 2 steps:
- Maintains both fields
- (In a couple of weeks) Deletes the deprecated
topicsarray
There was a problem hiding this comment.
@afharo since kibana 8.13 we already handle the fact that topics could not be here and the topic field is present, so I think we should not have any BWC issues
There was a problem hiding this comment.
let me know if you think this could still be an issue
There was a problem hiding this comment.
oh! if 8.13+ already uses the single topic field, then all good on my end. Approving
criamico
left a comment
criamico
left a comment
There was a problem hiding this comment.
I checked the changes for the dynamic topic, back when I implemented it I wasn't aware that topic was being deprecated. Thanks for taking care of it! LGTM 🚀
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @nchaulet |
7 participants
Description
Related to #189746
Remove deprecated property
topicsfrom output APIs in response and requests(GET|POST|PUT) /api/fleet/outputsin favor of thetopicproperty in 9.0.The property was still used in Fleet UI and had to made a few change there.