Skip to content

[Profiling] Switch to 19Hz sampling frequency#202278

Merged
rockdaboot merged 3 commits intoelastic:mainfrom
rockdaboot:profiling-switch-to-19hz
Nov 29, 2024
Merged

[Profiling] Switch to 19Hz sampling frequency#202278
rockdaboot merged 3 commits intoelastic:mainfrom
rockdaboot:profiling-switch-to-19hz

Conversation

@rockdaboot
Copy link
Contributor

Summary

With 9.0.0, profiling switches to 19Hz default sampling frequency.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@rockdaboot rockdaboot added the backport:skip This PR does not require backporting label Nov 29, 2024
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rockdaboot rockdaboot force-pushed the profiling-switch-to-19hz branch from a958c67 to 12b1087 Compare November 29, 2024 12:53
@rockdaboot rockdaboot enabled auto-merge (squash) November 29, 2024 16:10
@cauemarcondes
Copy link
Contributor

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 29, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 9b03642
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202278-9b03642cd337

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #4 / Detection Engine - Exception Lists and Items APIs Exception Lists - Lists APIs @ess @serverless @serverlessQA import_exceptions "overwrite" is false should report that it imported an exception list with multiple items successfully

Metrics [docs]

✅ unchanged

History

cc @rockdaboot

@rockdaboot rockdaboot merged commit 94f4f66 into elastic:main Nov 29, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
With 9.0.0, profiling switches to 19Hz default sampling frequency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants