[Discover] Remove discover:searchFieldsFromSource setting by jughosta · Pull Request #202679 · elastic/kibana

jughosta · 2024-12-03T11:20:41Z

Closes [Discover] Deprecate discover:searchFieldsFromSource Advanced Setting #196501

Summary

The PR removes discover:searchFieldsFromSource Advanced Setting and the associated code.
This breaking change is planned for v9.

The setting was marked as deprecated in v8.15 #185871

Checklist

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

github-actions · 2024-12-03T11:20:55Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

…-setting' into 196501-remove-search-from-source-setting

elasticmachine · 2024-12-03T18:39:16Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

elasticmachine · 2024-12-03T18:39:33Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

github-actions · 2024-12-03T18:39:39Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

nreese

kibana-presentation changes LGTM
code review only

TinaHeiligers

Usage collection and telemetry schema changes LGTM.
We are still waiting for a final confirmation for the BC, hence not approving quite yet.

TinaHeiligers

The BC has approved the change.
Code-related changes w.r.t usage collection and telemetry LGTM

akowalska622

LGTM, what a massive cleanup!

opauloh

Cloud Security changes LGTM

peteharverson

ML changes for the data visualizer LGTM

janmonschke

THI changes lgtm

elasticmachine · 2024-12-06T16:30:02Z

💚 Build Succeeded

Buildkite Build
Commit: 3e75600
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202679-3e75600a4c2b

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/discover-utils`	227	226	-1
`@kbn/management-settings-ids`	137	136	-1
`@kbn/unified-data-table`	109	108	-1
total			-3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cloudSecurityPosture`	502.7KB	502.5KB	-200.0B
`dataVisualizer`	614.8KB	614.8KB	-40.0B
`discover`	785.8KB	784.6KB	-1.1KB
`esqlDataGrid`	153.8KB	153.7KB	-82.0B
`securitySolution`	14.6MB	14.6MB	-618.0B
`slo`	855.0KB	854.8KB	-185.0B
`unifiedDocViewer`	115.8KB	115.8KB	+14.0B
total			-2.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`discover`	44.1KB	44.0KB	-70.0B
`unifiedDocViewer`	11.8KB	11.3KB	-464.0B
total			-534.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/discover-utils`	277	276	-1
`@kbn/management-settings-ids`	138	137	-1
`@kbn/unified-data-table`	186	184	-2
total			-4

History

💚 Build #257288 succeeded a9a4bd9
💚 Build #256900 succeeded ece2ddd
💚 Build #256610 succeeded c3639c9
💛 Build #256457 was flaky bdf7582
💔 Build #256386 failed f1dec08

cc @jughosta

…2679) - Closes elastic#196501 ## Summary The PR removes `discover:searchFieldsFromSource` Advanced Setting and the associated code. This breaking change is planned for v9. The setting was marked as deprecated in v8.15 elastic#185871 ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

[Discover] Remove discover:searchFieldsFromSource setting

86ae415

jughosta added release_note:breaking Feature:Discover Discover Application backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Dec 3, 2024

jughosta self-assigned this Dec 3, 2024

jughosta added 8 commits December 3, 2024 12:41

[Discover] Clean up translations

f1dec08

[Discover] Clean up tests

f31163f

[Discover] Add a comment

c3eb73a

Merge branch 'main' into 196501-remove-search-from-source-setting

bdf7582

[Discover] Restore and update one of the tests

c446a99

Merge remote-tracking branch 'origin/196501-remove-search-from-source…

61e945a

…-setting' into 196501-remove-search-from-source-setting

Merge branch 'main' into 196501-remove-search-from-source-setting

617599b

Merge branch 'main' into 196501-remove-search-from-source-setting

edb08cd

jughosta marked this pull request as ready for review December 3, 2024 18:39

jughosta requested review from a team as code owners December 3, 2024 18:39

Merge branch 'main' into 196501-remove-search-from-source-setting

c3639c9

botelastic bot added ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Dec 3, 2024

nreese approved these changes Dec 3, 2024

View reviewed changes

TinaHeiligers reviewed Dec 3, 2024

View reviewed changes

TinaHeiligers self-requested a review December 3, 2024 23:46

TinaHeiligers approved these changes Dec 3, 2024

View reviewed changes

stratoula approved these changes Dec 4, 2024

View reviewed changes

sabarasaba approved these changes Dec 4, 2024

View reviewed changes

akowalska622 approved these changes Dec 4, 2024

View reviewed changes

Merge branch 'main' into 196501-remove-search-from-source-setting

ece2ddd

sebelga approved these changes Dec 4, 2024

View reviewed changes

opauloh approved these changes Dec 4, 2024

View reviewed changes

peteharverson approved these changes Dec 5, 2024

View reviewed changes

Merge branch 'main' into 196501-remove-search-from-source-setting

a9a4bd9

shahzad31 approved these changes Dec 6, 2024

View reviewed changes

Merge branch 'main' into 196501-remove-search-from-source-setting

3e75600

janmonschke approved these changes Dec 6, 2024

View reviewed changes

jughosta merged commit 2f95dee into elastic:main Dec 6, 2024

jughosta deleted the 196501-remove-search-from-source-setting branch December 6, 2024 16:58

kibanamachine added the v9.0.0 label Dec 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] Remove discover:searchFieldsFromSource setting#202679

[Discover] Remove discover:searchFieldsFromSource setting#202679
jughosta merged 13 commits intoelastic:mainfrom
jughosta:196501-remove-search-from-source-setting

jughosta commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024

elasticmachine commented Dec 3, 2024

elasticmachine commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

nreese left a comment

TinaHeiligers left a comment

TinaHeiligers left a comment

akowalska622 left a comment

opauloh left a comment

peteharverson left a comment

janmonschke left a comment

elasticmachine commented Dec 6, 2024 •

edited

Loading

API count

Labels

13 participants

Conversation

jughosta commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

github-actions bot commented Dec 3, 2024

elasticmachine commented Dec 3, 2024

elasticmachine commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

🤖 GitHub comments

nreese left a comment

Choose a reason for hiding this comment

TinaHeiligers left a comment

Choose a reason for hiding this comment

TinaHeiligers left a comment

Choose a reason for hiding this comment

akowalska622 left a comment

Choose a reason for hiding this comment

opauloh left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

janmonschke left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Labels

13 participants

jughosta commented Dec 3, 2024 •

edited

Loading

elasticmachine commented Dec 6, 2024 •

edited

Loading