Remove links to Logs Explorer#203685
Merged
thomheymann merged 42 commits intoelastic:mainfrom Jan 3, 2025
Merged
Conversation
Bamieh
approved these changes
Jan 2, 2025
Contributor
Bamieh
left a comment
Bamieh
left a comment
There was a problem hiding this comment.
telemetry schema changes LGTM
davismcphee
approved these changes
Jan 3, 2025
Contributor
davismcphee
left a comment
davismcphee
left a comment
There was a problem hiding this comment.
Data Discovery changes LGTM and it works as expected, no more Logs Explorer tab 👍
Comment on lines
+505
to
+507
| * Contrary to its name, this property sets the index pattern of the data view. (e.g. `logs-*,metrics-*`) | ||
| * | ||
| * Use the `name` property instead to set a human readable name for the data view. |
Contributor
There was a problem hiding this comment.
Oh legacy code... At one point this was both the pattern and display name, but that hasn't been the case in a long time. Makes sense to call it out explicitly.
| css={{ boxShadow: 'none', backgroundColor: euiThemeVars.euiPageBackgroundColor }} | ||
| data-test-subj="discoverTopNavInline" | ||
| > | ||
| {customizationContext.inlineTopNav.showLogsExplorerTabs && ( |
Contributor
There was a problem hiding this comment.
This prop can likely be removed now that O11y no longer needs it, but we can handle that as a followup.
…/kibana into remove-logs-explorer
Kerry350
approved these changes
Jan 3, 2025
Contributor
Kerry350
left a comment
Kerry350
left a comment
There was a problem hiding this comment.
Thanks for pushing this through 🙌
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
|
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
Resolves elastic#182229 ## Release Note Remove Logs Explorer ## Summary - Removes the Discover/Logs Explorer tabs in the top nav - Changes all links to Logs Explorer in other applications to Discover - Removes all APIs exposed by Logs Explorer Note: This does not remove Logs Explorer from the codebase. There will be a follow up for that work. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
7 tasks
davismcphee
added a commit
that referenced
this pull request
Jan 27, 2025
## Summary This is followup work to #203685 that removes `DiscoverTopNavInline` now that Logs Explorer is gone, since the component is no longer used. I also noticed that top nav style overrides we use weren't applied to the inline top nav, so this fixes that as well. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This was referenced Jan 31, 2025
gbamparop
added a commit
that referenced
this pull request
Feb 6, 2025
…209120) ## 📓 Summary Removes the `observability:logsExplorer:allowedDataViews` advanced setting that was introduced by #178602 as Logs Explorer is [no longer available](#203685) in Serverless and 9.0. Closes #209092 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2025
…lastic#209120) ## 📓 Summary Removes the `observability:logsExplorer:allowedDataViews` advanced setting that was introduced by elastic#178602 as Logs Explorer is [no longer available](elastic#203685) in Serverless and 9.0. Closes elastic#209092 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 3e5f55d)
kibanamachine
added a commit
that referenced
this pull request
Feb 6, 2025
…ting (#209120) (#210005) # Backport This will backport the following commits from `main` to `9.0`: - [Remove observability:logsExplorer:allowedDataViews advanced setting (#209120)](#209120) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Giorgos Bamparopoulos","email":"georgios.bamparopoulos@elastic.co"},"sourceCommit":{"committedDate":"2025-02-06T13:28:00Z","message":"Remove observability:logsExplorer:allowedDataViews advanced setting (#209120)\n\n## 📓 Summary\r\nRemoves the `observability:logsExplorer:allowedDataViews` advanced\r\nsetting that was introduced by\r\nhttps://github.com//pull/178602 as Logs Explorer is [no\r\nlonger available](#203685) in\r\nServerless and 9.0.\r\n\r\nCloses https://github.com/elastic/kibana/issues/209092\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3e5f55dd0258646d976d776127e39bdb04859568","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v9.1.0"],"title":"Remove observability:logsExplorer:allowedDataViews advanced setting","number":209120,"url":"https://github.com/elastic/kibana/pull/209120","mergeCommit":{"message":"Remove observability:logsExplorer:allowedDataViews advanced setting (#209120)\n\n## 📓 Summary\r\nRemoves the `observability:logsExplorer:allowedDataViews` advanced\r\nsetting that was introduced by\r\nhttps://github.com//pull/178602 as Logs Explorer is [no\r\nlonger available](#203685) in\r\nServerless and 9.0.\r\n\r\nCloses https://github.com/elastic/kibana/issues/209092\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3e5f55dd0258646d976d776127e39bdb04859568"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209120","number":209120,"mergeCommit":{"message":"Remove observability:logsExplorer:allowedDataViews advanced setting (#209120)\n\n## 📓 Summary\r\nRemoves the `observability:logsExplorer:allowedDataViews` advanced\r\nsetting that was introduced by\r\nhttps://github.com//pull/178602 as Logs Explorer is [no\r\nlonger available](#203685) in\r\nServerless and 9.0.\r\n\r\nCloses https://github.com/elastic/kibana/issues/209092\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3e5f55dd0258646d976d776127e39bdb04859568"}}]}] BACKPORT--> Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>
drewdaemon
pushed a commit
to drewdaemon/kibana
that referenced
this pull request
Feb 6, 2025
…lastic#209120) ## 📓 Summary Removes the `observability:logsExplorer:allowedDataViews` advanced setting that was introduced by elastic#178602 as Logs Explorer is [no longer available](elastic#203685) in Serverless and 9.0. Closes elastic#209092 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #182229
Release Note
Remove Logs Explorer
Summary
Note: This does not remove Logs Explorer from the codebase. There will be a follow up for that work.