Disable log stream and settings pages by gbamparop · Pull Request #203996 · elastic/kibana

gbamparop · 2024-12-12T10:47:59Z

Release note

Logs Stream and the logs settings page in Observability are removed. Use the Discover application, which now offers a contextual experience for logs, to explore your logs. The logs stream panel in dashboards is removed, use Discover sessions instead.

📓 Summary

The Logs Stream app in Observability and the log stream panel available in dashboards were hidden behind an advanced setting as part of #194519 in 8.16.0. At the same time, a link was added to the left navigation for the logs settings page.

This PR which targets 9.0.0 disables these pages as well as the dashboard panel:

Removes the navigation item for the logs settings page and the corresponding route
Removes the observability:enableLogsStream setting and keeps the redirects to logs explorer. The locators will be updated to point to Discover as part of [Logs Explorer] Remove Logs Explorer #182229.

Removing the code that renders the logs stream and the settings pages will be done in a follow-up issue.

Left navigation

Classic

Solution

Navigating to /app/logs/settings

Closes https://github.com/elastic/observability-dev/issues/4156

gbamparop · 2024-12-12T11:49:11Z

Release note

The logs stream and the logs settings pages in Observability are removed and the Discover application, which now offers a contextual experience for logs, can be used for log exploration.

@mdbirnstiehl do you have any suggestions for the release notes?

elasticmachine · 2024-12-12T11:55:33Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

github-actions · 2024-12-12T11:55:39Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

wayneseymour

test/tsconfig.json LGTM

tonyghiani · 2024-12-12T13:26:51Z

x-pack/plugins/observability_solution/observability/public/navigation_tree.ts

                  defaultMessage: 'Logs categories',
                }),
              },
-              {


nit: I think we should also remove the log stream entry above here in the same file right?

Good spot, removed here

tonyghiani

Overall looks good, thanks for this work 👏
Regarding the functional tests for the logs stream and settings page, should they be removed too or at least skipped since those features won't be registered behind any flag?

gbamparop · 2024-12-12T13:47:54Z

Overall looks good, thanks for this work 👏 Regarding the functional tests for the logs stream and settings page, should they be removed too or at least skipped since those features won't be registered behind any flag?

That's a good point, I skipped the functional tests here and added an item to the acceptance criteria of the follow-up issue to remove them.

gbamparop · 2024-12-12T13:50:00Z

Overall looks good, thanks for this work 👏 Regarding the functional tests for the logs stream and settings page, should they be removed too or at least skipped since those features won't be registered behind any flag?

That's a good point, I skipped the functional tests here and added an item to the acceptance criteria of the follow-up issue to remove them.

The same can possibly be done for API tests.

mdbirnstiehl · 2024-12-12T14:44:25Z

Release note

The logs stream and the logs settings pages in Observability are removed and the Discover application, which now offers a contextual experience for logs, can be used for log exploration.

@mdbirnstiehl do you have any suggestions for the release notes?

Maybe something like this:

Logs Stream and the logs settings page in Observability are removed. Use the Discover application, which now offers a contextual experience for logs, to explore your logs.

gbamparop · 2024-12-12T15:03:43Z

The logs stream panel in dashboards is removed, use Discover's saved search instead.

@mdbirnstiehl thanks, updated the release notes section in the description and mentioned the log stream panel too, please feel free to update.

nreese

kibana-presentation changes LGTM - functional test changes only

gbamparop · 2024-12-12T19:18:18Z

test/functional/apps/dashboard/group1/create_and_add_embeddables.ts

      await dashboard.switchToEditMode();
      await dashboardAddPanel.clickEditorMenuButton();
-      await dashboardAddPanel.clickAddNewPanelFromUIActionLink('Log stream (deprecated)');
+      await dashboardAddPanel.clickAddNewPanelFromUIActionLink('Pattern analysis');


Updated to test another panel as the log stream panel is removed

…and-settings

tonyghiani · 2024-12-13T08:50:04Z

A huge number of translations were removed in one of the latest commits, including security translations, is that intentional?

…and-settings

gbamparop · 2024-12-13T09:00:29Z

A huge number of translations were removed in one of the latest commits, including security translations, is that intentional?

Not really, and the i18n_check.js script locally verifies all the translation files

…and-settings

gbamparop · 2024-12-17T12:58:42Z

@elasticmachine merge upstream

afharo

Telemetry changes on UI Settings LGTM

tonyghiani

LGTM

rmyz

LGTM, only codeowners review

crespocarlos

LGTM.

Does it make sense to merge this #203620, now that we're removing the logs stream for v9.0?

miloszmarcinkowski

LGTM

miloszmarcinkowski · 2024-12-18T09:34:38Z

x-pack/plugins/observability_solution/infra/public/plugin.ts

@@ -412,12 +367,9 @@ const getLogsNavigationEntries = ({
  }

  // Display Stream nav entry when Logs Stream is enabled


nit: please remove comment associated with deleted line

Good catch, removed in 8c5c37d

mattkime

codeowner changes lgtm

…and-settings

gbamparop · 2024-12-19T08:53:05Z

Does it make sense to merge this #203620, now that we're removing the logs stream for v9.0?

@crespocarlos there's no harm in merging it, the underlying code will be removed by #204115

elasticmachine · 2024-12-19T09:52:12Z

💚 Build Succeeded

Buildkite Build
Commit: 50a3971
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203996-50a39713b4db

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	1544	1298	-246

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/management-settings-ids`	136	135	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	1.7MB	1.3MB	-478.6KB
`observability`	481.1KB	480.8KB	-262.0B
total			-478.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	57.8KB	51.1KB	-6.7KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/management-settings-ids`	137	136	-1

async chunk count

id	before	after	diff
`infra`	33	30	-3

History

💚 Build #261375 succeeded 9bf82b4
💚 Build #260236 succeeded ac4621e
💚 Build #260213 succeeded 7e202e6
💛 Build #260194 was flaky adf2892
💔 Build #260048 failed 96b2a3a

## Release note Logs Stream and the logs settings page in Observability are removed. Use the [Discover](https://www.elastic.co/guide/en/kibana/current/discover.html) application, which now offers a contextual experience for logs, to explore your logs. The logs stream panel in dashboards is removed, use Discover sessions instead. ## 📓 Summary The Logs Stream app in Observability and the log stream panel available in dashboards were hidden behind an advanced setting as part of elastic#194519 in `8.16.0`. At the same time, a link was added to the left navigation for the logs settings page. This PR which targets `9.0.0` disables these pages as well as the dashboard panel: - Removes the navigation item for the logs settings page and the corresponding route - Removes the `observability:enableLogsStream` setting and keeps the redirects to logs explorer. The locators will be updated to point to Discover as part of elastic#182229. Removing the code that renders the logs stream and the settings pages will be done in a [follow-up issue](elastic#204005). ### Left navigation #### Classic <img width="238" alt="image" src="https://github.com/user-attachments/assets/bc72c5ce-ed32-472e-91c1-8bd691dd2420" /> #### Solution <img width="275" alt="image" src="https://github.com/user-attachments/assets/3b21a2ae-5e82-478e-97bb-e12303178a24" /> ### Navigating to /app/logs/settings <img width="1722" alt="image" src="https://github.com/user-attachments/assets/07b4197c-6063-4a59-8194-a97ce2fa3cd7" /> Closes elastic/observability-dev#4156 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Disable log stream and settings pages

028e168

gbamparop mentioned this pull request Dec 12, 2024

Remove the code used to render the logs stream app and the logs settings page in Observability #204005

Closed

gbamparop marked this pull request as ready for review December 12, 2024 11:45

gbamparop requested review from a team as code owners December 12, 2024 11:45

gbamparop requested a review from a team December 12, 2024 11:45

gbamparop requested review from a team as code owners December 12, 2024 11:45

gbamparop added release_note:deprecation backport:skip This PR does not require backporting labels Dec 12, 2024

[CI] Auto-commit changed files from 'node scripts/notice'

335c198

elastic-vault-github-plugin-prod bot requested a review from a team as a code owner December 12, 2024 11:55

botelastic bot added ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Dec 12, 2024

wayneseymour approved these changes Dec 12, 2024

View reviewed changes

tonyghiani reviewed Dec 12, 2024

View reviewed changes

Skip tests related to the log stream and settings pages

a81667f

nreese approved these changes Dec 12, 2024

View reviewed changes

Remove test cases for the log stream and settings pages

afeecef

gbamparop commented Dec 12, 2024

View reviewed changes

gbamparop added 2 commits December 12, 2024 21:51

Merge remote-tracking branch 'upstream/main' into disable-log-stream-…

81bf76d

…and-settings

Update dashboard panel type

adf2892

Merge remote-tracking branch 'upstream/main' into disable-log-stream-…

7e202e6

…and-settings

gbamparop added 2 commits December 13, 2024 10:04

Merge remote-tracking branch 'upstream/main' into disable-log-stream-…

e7c2afb

…and-settings

Update translations

ac4621e

Merge branch 'main' into disable-log-stream-and-settings

9bf82b4

afharo approved these changes Dec 17, 2024

View reviewed changes

tonyghiani approved these changes Dec 17, 2024

View reviewed changes

shahzad31 approved these changes Dec 18, 2024

View reviewed changes

rmyz approved these changes Dec 18, 2024

View reviewed changes

crespocarlos approved these changes Dec 18, 2024

View reviewed changes

miloszmarcinkowski approved these changes Dec 18, 2024

View reviewed changes

mattkime approved these changes Dec 18, 2024

View reviewed changes

gbamparop added 3 commits December 19, 2024 08:48

Merge remote-tracking branch 'upstream/main' into disable-log-stream-…

aef5208

…and-settings

Remove comment from infra plugin

8c5c37d

Update translations

50a3971

gbamparop merged commit 90277c3 into elastic:main Dec 19, 2024

kibanamachine added the v9.0.0 label Dec 19, 2024

gbamparop mentioned this pull request Jan 23, 2025

[Logs UI] Improve error handling when using undefined remote cluster in source settings #125496

Closed

gbamparop mentioned this pull request Feb 3, 2025

Add redirect for the logs settings page #209270

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable log stream and settings pages#203996

Disable log stream and settings pages#203996
gbamparop merged 16 commits intoelastic:mainfrom
gbamparop:disable-log-stream-and-settings

gbamparop commented Dec 12, 2024 •

edited

Loading

gbamparop commented Dec 12, 2024

Release note

elasticmachine commented Dec 12, 2024

github-actions bot commented Dec 12, 2024

wayneseymour left a comment

tonyghiani Dec 12, 2024

gbamparop Dec 12, 2024

tonyghiani left a comment

gbamparop commented Dec 12, 2024 •

edited

Loading

gbamparop commented Dec 12, 2024

mdbirnstiehl commented Dec 12, 2024

Release note

gbamparop commented Dec 12, 2024

nreese left a comment

gbamparop Dec 12, 2024

tonyghiani commented Dec 13, 2024

gbamparop commented Dec 13, 2024

gbamparop commented Dec 17, 2024

afharo left a comment

tonyghiani left a comment

rmyz left a comment

crespocarlos left a comment

miloszmarcinkowski left a comment

miloszmarcinkowski Dec 18, 2024 •

edited

Loading

gbamparop Dec 19, 2024

mattkime left a comment

gbamparop commented Dec 19, 2024

elasticmachine commented Dec 19, 2024 •

edited

Loading

API count

async chunk count

Labels

14 participants

		@@ -412,12 +367,9 @@ const getLogsNavigationEntries = ({
		}

		// Display Stream nav entry when Logs Stream is enabled

Conversation

gbamparop commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release note

📓 Summary

Left navigation

Classic

Solution

Navigating to /app/logs/settings

gbamparop commented Dec 12, 2024

Release note

elasticmachine commented Dec 12, 2024

github-actions bot commented Dec 12, 2024

🤖 GitHub comments

wayneseymour left a comment

Choose a reason for hiding this comment

tonyghiani Dec 12, 2024

Choose a reason for hiding this comment

gbamparop Dec 12, 2024

Choose a reason for hiding this comment

tonyghiani left a comment

Choose a reason for hiding this comment

gbamparop commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gbamparop commented Dec 12, 2024

mdbirnstiehl commented Dec 12, 2024

Release note

gbamparop commented Dec 12, 2024

nreese left a comment

Choose a reason for hiding this comment

gbamparop Dec 12, 2024

Choose a reason for hiding this comment

tonyghiani commented Dec 13, 2024

gbamparop commented Dec 13, 2024

gbamparop commented Dec 17, 2024

afharo left a comment

Choose a reason for hiding this comment

tonyghiani left a comment

Choose a reason for hiding this comment

rmyz left a comment

Choose a reason for hiding this comment

crespocarlos left a comment

Choose a reason for hiding this comment

miloszmarcinkowski left a comment

Choose a reason for hiding this comment

miloszmarcinkowski Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

gbamparop Dec 19, 2024

Choose a reason for hiding this comment

mattkime left a comment

Choose a reason for hiding this comment

gbamparop commented Dec 19, 2024

elasticmachine commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

async chunk count

History

Labels

14 participants

gbamparop commented Dec 12, 2024 •

edited

Loading

gbamparop commented Dec 12, 2024 •

edited

Loading

miloszmarcinkowski Dec 18, 2024 •

edited

Loading

elasticmachine commented Dec 19, 2024 •

edited

Loading