Skip to content

[Fleet] Fix required validation for multi text input field#205768

Merged
juliaElastic merged 2 commits intoelastic:mainfrom
viajes7:fix/integration-path-required
Jan 9, 2025
Merged

[Fleet] Fix required validation for multi text input field#205768
juliaElastic merged 2 commits intoelastic:mainfrom
viajes7:fix/integration-path-required

Conversation

@viajes7
Copy link
Contributor

@viajes7 viajes7 commented Jan 7, 2025 •
edited by kibanamachine
Loading

Summary

Fixes #196648

  • ✅ add required validation to blank spaces value
  • ❓ when adding additional rows for path. It seems that the updated value is specially processed.

And this is why the required validation is not triggered when clicking to add a row.

image

After fixup

image
@viajes7 viajes7 requested a review from a team as a code owner January 7, 2025 15:18
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 7, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 7, 2025

Pinging @elastic/fleet (Team:Fleet)
@viajes7 viajes7 force-pushed the fix/integration-path-required branch from 0e03287 to cf03fc6 Compare January 7, 2025 15:19
@viajes7
Copy link
Contributor Author

viajes7 commented Jan 7, 2025

Hi, @kpollich Can you help review the pr? Thanks.
@viajes7 viajes7 force-pushed the fix/integration-path-required branch from cf03fc6 to fc3d720 Compare January 7, 2025 15:22
@kpollich
Copy link
Member

kpollich commented Jan 7, 2025

buildkite test this
@kpollich kpollich self-assigned this Jan 7, 2025
jen-huang
jen-huang approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks for the tests
@juliaElastic juliaElastic merged commit 74da51f into elastic:main Jan 9, 2025
4 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 9, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12687589427
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 9, 2025
@viajes7
[Fleet] Fix required validation for multi text input field (elastic#2…
51cbd49 
…05768)

## Summary

Fixes elastic#196648

- ✅  add required validation to blank spaces value
- ❓ when adding additional rows for path. It seems that the updated
value is specially processed.

**And this is why the required validation is not triggered when clicking
to add a row.**

![image](https://github.com/user-attachments/assets/f2f0d813-3762-47c5-bf31-1171c82c3b07)

## After fixup

![image](https://github.com/user-attachments/assets/857bef47-38c1-4951-8ea9-15b5ef5d143d)

(cherry picked from commit 74da51f)
@kibanamachine kibanamachine mentioned this pull request Jan 9, 2025
Closed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 9, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation
Zacqary pushed a commit to Zacqary/kibana that referenced this pull request Jan 9, 2025
@viajes7 @Zacqary
[Fleet] Fix required validation for multi text input field (elastic#2…
dc0a5c3 
…05768)

## Summary

Fixes elastic#196648 

- ✅  add required validation to blank spaces value
- ❓ when adding additional rows for path. It seems that the updated
value is specially processed.

**And this is why the required validation is not triggered when clicking
to add a row.**


![image](https://github.com/user-attachments/assets/f2f0d813-3762-47c5-bf31-1171c82c3b07)

## After fixup


![image](https://github.com/user-attachments/assets/857bef47-38c1-4951-8ea9-15b5ef5d143d)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 10, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 10, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 13, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
5 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 14, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 15, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 16, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 17, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 20, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 21, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 22, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 23, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205768 locally
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@viajes7 @viduni94
[Fleet] Fix required validation for multi text input field (elastic#2…
b37c3c7 
…05768)

## Summary

Fixes elastic#196648 

- ✅  add required validation to blank spaces value
- ❓ when adding additional rows for path. It seems that the updated
value is specially processed.

**And this is why the required validation is not triggered when clicking
to add a row.**


![image](https://github.com/user-attachments/assets/f2f0d813-3762-47c5-bf31-1171c82c3b07)

## After fixup


![image](https://github.com/user-attachments/assets/857bef47-38c1-4951-8ea9-15b5ef5d143d)
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 24, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205768 locally
2 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 27, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205768 locally
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 28, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 205768 locally
@juliaElastic juliaElastic mentioned this pull request Jan 29, 2025
Merged
juliaElastic pushed a commit to juliaElastic/kibana that referenced this pull request Jan 29, 2025
@viajes7 @juliaElastic
[Fleet] Fix required validation for multi text input field (elastic#2…
8c362ec 
…05768)

## Summary

Fixes elastic#196648 

- ✅  add required validation to blank spaces value
- ❓ when adding additional rows for path. It seems that the updated
value is specially processed.

**And this is why the required validation is not triggered when clicking
to add a row.**


![image](https://github.com/user-attachments/assets/f2f0d813-3762-47c5-bf31-1171c82c3b07)

## After fixup


![image](https://github.com/user-attachments/assets/857bef47-38c1-4951-8ea9-15b5ef5d143d)
@kibanamachine kibanamachine mentioned this pull request Jan 29, 2025
Merged
1 task
juliaElastic added a commit that referenced this pull request Jan 29, 2025
@juliaElastic @viajes7
[8.x] Fix required validation for multi text input field (#208699)
c2647b5 
Backport #205768 to 8.x

Combining with the fix #208528

---------

Co-authored-by: Jusheng Huang <117657272+viajes7@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💝community release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0

6 participants

@viajes7 @elasticmachine @kpollich @kibanamachine @jen-huang @juliaElastic