[Fleet] Expose ssl options for ES and remote ES outputs in UI#208745
Merged
criamico merged 27 commits intoelastic:mainfrom Feb 21, 2025
Merged
[Fleet] Expose ssl options for ES and remote ES outputs in UI#208745criamico merged 27 commits intoelastic:mainfrom
criamico merged 27 commits intoelastic:mainfrom
Conversation
criamico
added
Team:Fleet
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
merge conflict between base and head |
criamico
force-pushed
the
207326_es_outputs_ssl
branch
from
7d5e515 to
3c8bfbb
Compare
Contributor
Author
|
@elasticmachine merge upstream |
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --include-path /api/dashboards --update'
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
Yeah, we should probably hide them until the fleet-server change is made. |
x-pack/platform/plugins/shared/fleet/server/services/agent_policies/full_agent_policy.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
criamico
added
v9.1.0
backport:skip
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
merge conflict between base and head |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@juliaElastic I noticed that I had a small bug in the plain text key due to the fact that we have several secrets in some forms, so disabling the secrets in the whole page is not a good solution. i pushed a change that introduces the feature flag |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @criamico |
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Feb 27, 2025
…c#208745) Fixes elastic#207326 ## Summary Expose SSL options for outputs of type ES and remote ES outputs to use in case of mTLS configuration. These options correspond to `--elastic-agent-cert, --elastic-agent-cert-key, --certificate-authorities` CLI options explained [in the docs](https://www.elastic.co/guide/en/fleet/current/tls-overview.html#mutual-tls-connection) and they need to be defined only when the user intends to configure mTLS in the system. Secrets inputs are disabled for now in the UI until the needed changes to fleet server are done. ### Testing - Create an ES or remote ES output with all the SSL fields compiled - Either make it default or assign it as a custom output for an agent policy - Check that the agent policy has the input data under `fleet` section: <img width="741" alt="Screenshot 2025-02-20 at 11 56 05" src="https://github.com/user-attachments/assets/bc891bbc-d669-4e31-951f-d045b64328e7" /> <details> <summary>Screenshots</summary> <img width="803" alt="Screenshot 2025-02-20 at 16 07 38" src="https://github.com/user-attachments/assets/e489cd51-6a40-4820-bf39-7670ad2ce69b" /> <img width="810" alt="Screenshot 2025-02-18 at 15 31 54" src="https://github.com/user-attachments/assets/9f155b2b-1feb-424f-b02b-b232e1e4e63e" /> </details> ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…c#208745) Fixes elastic#207326 ## Summary Expose SSL options for outputs of type ES and remote ES outputs to use in case of mTLS configuration. These options correspond to `--elastic-agent-cert, --elastic-agent-cert-key, --certificate-authorities` CLI options explained [in the docs](https://www.elastic.co/guide/en/fleet/current/tls-overview.html#mutual-tls-connection) and they need to be defined only when the user intends to configure mTLS in the system. Secrets inputs are disabled for now in the UI until the needed changes to fleet server are done. ### Testing - Create an ES or remote ES output with all the SSL fields compiled - Either make it default or assign it as a custom output for an agent policy - Check that the agent policy has the input data under `fleet` section: <img width="741" alt="Screenshot 2025-02-20 at 11 56 05" src="https://github.com/user-attachments/assets/bc891bbc-d669-4e31-951f-d045b64328e7" /> <details> <summary>Screenshots</summary> <img width="803" alt="Screenshot 2025-02-20 at 16 07 38" src="https://github.com/user-attachments/assets/e489cd51-6a40-4820-bf39-7670ad2ce69b" /> <img width="810" alt="Screenshot 2025-02-18 at 15 31 54" src="https://github.com/user-attachments/assets/9f155b2b-1feb-424f-b02b-b232e1e4e63e" /> </details> ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
juliaElastic
added a commit
that referenced
this pull request
Mar 26, 2025
## Summary Fix Remote ES output with secret token secret. The secrets were not correctly saved to the full agent policy, bug introduced in this pr: #208745 Also added a doc how to test sync integrations feature with 2 local clusters. To test: - create remote ES output with service token as a secret - create an agent policy and use the remote ES output as data and monitoring output - check that the full agent policy contains `outputs.secrets` - enroll an agent and verify that it becomes healthy and the data is ingested to the remote cluster <img width="1704" alt="image" src="https://github.com/user-attachments/assets/1744fb71-75b4-44f9-ade9-8a29dd44fd95" /> <img width="1619" alt="image" src="https://github.com/user-attachments/assets/941936a3-ddc6-42c9-9c49-a941ae9007b6" /> <img width="816" alt="image" src="https://github.com/user-attachments/assets/e9b703fb-b032-4879-8f0a-c69e67f1a4b2" /> <img width="1792" alt="image" src="https://github.com/user-attachments/assets/077d6f1e-efc2-486b-a6d5-9a87ae012471" />
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…c#216033) ## Summary Fix Remote ES output with secret token secret. The secrets were not correctly saved to the full agent policy, bug introduced in this pr: elastic#208745 Also added a doc how to test sync integrations feature with 2 local clusters. To test: - create remote ES output with service token as a secret - create an agent policy and use the remote ES output as data and monitoring output - check that the full agent policy contains `outputs.secrets` - enroll an agent and verify that it becomes healthy and the data is ingested to the remote cluster <img width="1704" alt="image" src="https://github.com/user-attachments/assets/1744fb71-75b4-44f9-ade9-8a29dd44fd95" /> <img width="1619" alt="image" src="https://github.com/user-attachments/assets/941936a3-ddc6-42c9-9c49-a941ae9007b6" /> <img width="816" alt="image" src="https://github.com/user-attachments/assets/e9b703fb-b032-4879-8f0a-c69e67f1a4b2" /> <img width="1792" alt="image" src="https://github.com/user-attachments/assets/077d6f1e-efc2-486b-a6d5-9a87ae012471" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #207326
Summary
Expose SSL options for outputs of type ES and remote ES outputs to use in case of mTLS configuration.
These options correspond to
--elastic-agent-cert, --elastic-agent-cert-key, --certificate-authoritiesCLI options explained in the docs and they need to be defined only when the user intends to configure mTLS in the system.Secrets inputs are disabled for now in the UI until the needed changes to fleet server are done.
Testing
fleetsection:Screenshots
Checklist