[Lens][Partition] Fix behind text coloring for syncColors#209632
Merged
nickofthyme merged 6 commits intoelastic:mainfrom Feb 11, 2025
Merged
[Lens][Partition] Fix behind text coloring for syncColors#209632nickofthyme merged 6 commits intoelastic:mainfrom
syncColors#209632nickofthyme merged 6 commits intoelastic:mainfrom
Conversation
nickofthyme
added
release_note:fix
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
dej611
reviewed
Feb 5, 2025
| }); | ||
|
|
||
| it('should return the same index of the behind text palette for same key', () => { | ||
| itIf(legacy)('should return the same index of the behind text palette for same key', () => { |
Contributor
There was a problem hiding this comment.
nit: why not use a simple condition here?
if(legacy){
it('...')
Contributor
Author
There was a problem hiding this comment.
Idk, I wanted something like playwright allows...
test('skip this test', async ({ page, browserName }) => {
test.skip(browserName === 'firefox', 'Still working on it');
});
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
dej611
approved these changes
Feb 6, 2025
Contributor
|
Starting backport for target branches: 9.0 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
…209632) ## Summary When switching to borealis palettes there is no longer a need for `euiPaletteColorBlindBehindText` palette. Removing this created the linked issue as there was no default applied when accessing the mapped colors. This change attempts to lookup behind text color otherwise defaults to normal color. This was only reachable when the dashboard `syncColors` option was enabled. Fixes elastic#209610 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release note This fixes and issues where behind text colors were not correctly assigned, such as in `Pie`, `Treemap` and `Mosaic` charts. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 155577b)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
…09632) (#210487) # Backport This will backport the following commits from `main` to `9.0`: - [[Lens][Partition] Fix behind text coloring for `syncColors` (#209632)](#209632) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nick Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2025-02-11T03:41:09Z","message":"[Lens][Partition] Fix behind text coloring for `syncColors` (#209632)\n\n## Summary\r\n\r\nWhen switching to borealis palettes there is no longer a need for\r\n`euiPaletteColorBlindBehindText` palette. Removing this created the\r\nlinked issue as there was no default applied when accessing the mapped\r\ncolors. This change attempts to lookup behind text color otherwise\r\ndefaults to normal color. This was only reachable when the dashboard\r\n`syncColors` option was enabled.\r\n\r\nFixes #209610\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nThis fixes and issues where behind text colors were not correctly\r\nassigned, such as in `Pie`, `Treemap` and `Mosaic` charts.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"155577b74bb9da71a1b77c568092b879a09b754a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","v9.1.0"],"title":"[Lens][Partition] Fix behind text coloring for `syncColors`","number":209632,"url":"https://github.com/elastic/kibana/pull/209632","mergeCommit":{"message":"[Lens][Partition] Fix behind text coloring for `syncColors` (#209632)\n\n## Summary\r\n\r\nWhen switching to borealis palettes there is no longer a need for\r\n`euiPaletteColorBlindBehindText` palette. Removing this created the\r\nlinked issue as there was no default applied when accessing the mapped\r\ncolors. This change attempts to lookup behind text color otherwise\r\ndefaults to normal color. This was only reachable when the dashboard\r\n`syncColors` option was enabled.\r\n\r\nFixes #209610\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nThis fixes and issues where behind text colors were not correctly\r\nassigned, such as in `Pie`, `Treemap` and `Mosaic` charts.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"155577b74bb9da71a1b77c568092b879a09b754a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209632","number":209632,"mergeCommit":{"message":"[Lens][Partition] Fix behind text coloring for `syncColors` (#209632)\n\n## Summary\r\n\r\nWhen switching to borealis palettes there is no longer a need for\r\n`euiPaletteColorBlindBehindText` palette. Removing this created the\r\nlinked issue as there was no default applied when accessing the mapped\r\ncolors. This change attempts to lookup behind text color otherwise\r\ndefaults to normal color. This was only reachable when the dashboard\r\n`syncColors` option was enabled.\r\n\r\nFixes #209610\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\n\r\nThis fixes and issues where behind text colors were not correctly\r\nassigned, such as in `Pie`, `Treemap` and `Mosaic` charts.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"155577b74bb9da71a1b77c568092b879a09b754a"}}]}] BACKPORT--> Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When switching to borealis palettes there is no longer a need for
euiPaletteColorBlindBehindTextpalette. Removing this created the linked issue as there was no default applied when accessing the mapped colors. This change attempts to lookup behind text color otherwise defaults to normal color. This was only reachable when the dashboardsyncColorsoption was enabled.Fixes #209610
Checklist
release_note:*label is applied per the guidelinesRelease note
This fixes and issues where behind text colors were not correctly assigned, such as in
Pie,TreemapandMosaiccharts.