Skip to content

chore(slo): factorize error handler#209671

Merged
kdelemme merged 5 commits intoelastic:mainfrom
kdelemme:slo-error-handling-router
Feb 6, 2025
Merged

chore(slo): factorize error handler#209671
kdelemme merged 5 commits intoelastic:mainfrom
kdelemme:slo-error-handling-router

Conversation

@kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Feb 4, 2025 •
edited
Loading

Summary

Note

Reopened Dario's PR from latest main to avoid the rebase conflict resolution.

This PR remove the need for the custom error handler in every routes.

A quick smoke test of running the app, creating a few SLOs should be enough
@kdelemme kdelemme force-pushed the slo-error-handling-router branch from a5e813f to e2da489 Compare February 5, 2025 14:49
@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Feb 5, 2025
@kdelemme kdelemme self-assigned this Feb 5, 2025
@kdelemme kdelemme marked this pull request as ready for review February 5, 2025 14:55
@kdelemme kdelemme requested a review from a team as a code owner February 5, 2025 14:55
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 5, 2025

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)
@kdelemme kdelemme added the backport:skip This PR does not require backporting label Feb 5, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 5, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #33 / Entity Analytics - Entity Store @ess @skipInServerlessMKI Entity Store APIs apply_dataview_indices should update the index pattern when the data view changes
  • [job] [logs] FTR Configs #33 / Entity Analytics - Entity Store @ess @skipInServerlessMKI Entity Store APIs apply_dataview_indices should update the index pattern when the data view changes
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary Calendar Aligned and Occurrences SLOs returns the summary
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary Calendar Aligned and Occurrences SLOs returns the summary
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary Calendar Aligned and Timeslices SLOs returns the summary
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary Calendar Aligned and Timeslices SLOs returns the summary
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary filters with the 'instanceId' when provided
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary filters with the 'instanceId' when provided
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary Rolling and Occurrences SLOs returns the summary using the provided date range
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary Rolling and Occurrences SLOs returns the summary using the provided date range
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary Rolling and Occurrences SLOs returns the summary using the SLO timeWindow date range
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary Rolling and Occurrences SLOs returns the summary using the SLO timeWindow date range
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary Rolling and Timeslices SLOs returns the summary using the provided date range
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary Rolling and Timeslices SLOs returns the summary using the provided date range
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary Rolling and Timeslices SLOs returns the summary using the SLO timeWindow date range
  • [job] [logs] Jest Tests #7 / FetchHistoricalSummary Rolling and Timeslices SLOs returns the summary using the SLO timeWindow date range
  • [job] [logs] FTR Configs #62 / Search solution tests Search index details page Solution Nav - Search search index details page API key details should show api key

Metrics [docs]

✅ unchanged

History

cc @kdelemme
baileycash-elastic
baileycash-elastic approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@baileycash-elastic baileycash-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested edit and delete SLO in duplicate session to verify use of new handler. lgtm
@kdelemme kdelemme merged commit 375528d into elastic:main Feb 6, 2025
9 checks passed
@kdelemme kdelemme deleted the slo-error-handling-router branch February 6, 2025 19:04
drewdaemon pushed a commit to drewdaemon/kibana that referenced this pull request Feb 6, 2025
@kdelemme @drewdaemon
chore(slo): factorize error handler (elastic#209671)
7a7c0a7
@kibanamachine kibanamachine mentioned this pull request Feb 7, 2025
Merged
@dgieselaar dgieselaar mentioned this pull request Feb 7, 2025
Closed
@kibanamachine kibanamachine mentioned this pull request Mar 18, 2025
Merged
kdelemme added a commit to kdelemme/kibana that referenced this pull request Apr 9, 2025
@kdelemme
chore(slo): factorize error handler (elastic#209671)
e806a23 
(cherry picked from commit 375528d)

# Conflicts:
#	x-pack/solutions/observability/plugins/slo/tsconfig.json
@kdelemme kdelemme mentioned this pull request Apr 9, 2025
Merged
@kdelemme
Copy link
Contributor Author

kdelemme commented Apr 9, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation
kdelemme added a commit that referenced this pull request Apr 9, 2025
@kdelemme
[8.x] chore(slo): factorize error handler (#209671) (#217720)
46ef01b 
# Backport

This will backport the following commits from `main` to `8.x`:
- [chore(slo): factorize error handler
(#209671)](#209671)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2025-02-06T19:04:37Z","message":"chore(slo):
factorize error handler
(#209671)","sha":"375528dcfe03912fb491fa8477b10dcaa3fa7f7c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","Team:obs-ux-management","v9.1.0"],"title":"chore(slo):
factorize error
handler","number":209671,"url":"https://github.com/elastic/kibana/pull/209671","mergeCommit":{"message":"chore(slo):
factorize error handler
(#209671)","sha":"375528dcfe03912fb491fa8477b10dcaa3fa7f7c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209671","number":209671,"mergeCommit":{"message":"chore(slo):
factorize error handler
(#209671)","sha":"375528dcfe03912fb491fa8477b10dcaa3fa7f7c"}}]}]
BACKPORT-->
@kibanamachine kibanamachine mentioned this pull request Jul 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.19.0 v9.0.0 v9.1.0

4 participants

@kdelemme @elasticmachine @baileycash-elastic @kibanamachine