Skip to content

Updates removed params of the Fleet -> Logstash output configurations.#210115

Merged
mashhurs merged 1 commit intoelastic:mainfrom
mashhurs:fleet-logstash-output-params-update
Feb 7, 2025
Merged

Updates removed params of the Fleet -> Logstash output configurations.#210115
mashhurs merged 1 commit intoelastic:mainfrom
mashhurs:fleet-logstash-output-params-update

Conversation

@mashhurs
Copy link
Contributor

@mashhurs mashhurs commented Feb 6, 2025

Summary

The configuration shown on Fleet -> Logstash output isn't up to date that some of them are removed.
This PR updates obsoleted configuration(s) to align with recent Logstash 9.0 configs.

Author's checklist

  • This needs to be backported to 9.0 Kibana branch
  • and would be good to trigger BC

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

N.A

Outcome

image
@mashhurs mashhurs self-assigned this Feb 6, 2025
@mashhurs mashhurs marked this pull request as ready for review February 6, 2025 23:16
@mashhurs mashhurs requested a review from a team as a code owner February 6, 2025 23:16
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 7, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +45.0B

History

cc @mashhurs

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 7, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@mashhurs mashhurs merged commit 7dd4058 into elastic:main Feb 7, 2025
16 checks passed
@mashhurs mashhurs deleted the fleet-logstash-output-params-update branch February 7, 2025 18:07
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13205480657

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 7, 2025
elastic#210115)

## Summary
The configuration shown on Fleet -> Logstash output isn't up to date
that some of them are removed.
This PR updates obsoleted configuration(s) to align with recent Logstash
9.0 configs.

### Author's checklist
- [ ] This needs to be backported to 9.0 Kibana branch
- [ ] and would be good to trigger BC

(cherry picked from commit 7dd4058)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 7, 2025
…gurations. (#210115) (#210235)

# Backport

This will backport the following commits from `main` to `9.0`:
- [Updates removed params of the Fleet -> Logstash output
configurations.
(#210115)](#210115)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Mashhur","email":"99575341+mashhurs@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-07T18:06:59Z","message":"Updates
removed params of the Fleet -> Logstash output configurations.
(#210115)\n\n## Summary\r\nThe configuration shown on Fleet -> Logstash
output isn't up to date\r\nthat some of them are removed.\r\nThis PR
updates obsoleted configuration(s) to align with recent Logstash\r\n9.0
configs.\r\n\r\n### Author's checklist\r\n- [ ] This needs to be
backported to 9.0 Kibana branch\r\n- [ ] and would be good to trigger
BC","sha":"7dd40580bd29f0ebd2d539b4a6ff6a853463b13a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v9.1.0"],"title":"Updates
removed params of the Fleet -> Logstash output
configurations.","number":210115,"url":"https://github.com/elastic/kibana/pull/210115","mergeCommit":{"message":"Updates
removed params of the Fleet -> Logstash output configurations.
(#210115)\n\n## Summary\r\nThe configuration shown on Fleet -> Logstash
output isn't up to date\r\nthat some of them are removed.\r\nThis PR
updates obsoleted configuration(s) to align with recent Logstash\r\n9.0
configs.\r\n\r\n### Author's checklist\r\n- [ ] This needs to be
backported to 9.0 Kibana branch\r\n- [ ] and would be good to trigger
BC","sha":"7dd40580bd29f0ebd2d539b4a6ff6a853463b13a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210115","number":210115,"mergeCommit":{"message":"Updates
removed params of the Fleet -> Logstash output configurations.
(#210115)\n\n## Summary\r\nThe configuration shown on Fleet -> Logstash
output isn't up to date\r\nthat some of them are removed.\r\nThis PR
updates obsoleted configuration(s) to align with recent Logstash\r\n9.0
configs.\r\n\r\n### Author's checklist\r\n- [ ] This needs to be
backported to 9.0 Kibana branch\r\n- [ ] and would be good to trigger
BC","sha":"7dd40580bd29f0ebd2d539b4a6ff6a853463b13a"}}]}] BACKPORT-->

Co-authored-by: Mashhur <99575341+mashhurs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0 v9.1.0

4 participants