Skip to content

[ES|QL] Creates controls for stats functions#210170

Merged
stratoula merged 13 commits intoelastic:mainfrom
stratoula:stats-functions-controls
Feb 13, 2025
Merged

[ES|QL] Creates controls for stats functions#210170
stratoula merged 13 commits intoelastic:mainfrom
stratoula:stats-functions-controls

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Feb 7, 2025 •
edited by kibanamachine
Loading

Summary

Closes #207029

Allows the creation of function controls. These are only available for STATS

image

Release notes

Allows the creation of dynamic aggregations controls for ES|QL charts.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.
@stratoula stratoula added v9.0.0 backport:version Backport to applied version labels v8.19.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// release_note:enhancement v9.1.0 and removed v9.0.0 labels Feb 10, 2025
@stratoula stratoula marked this pull request as ready for review February 10, 2025 13:11
@stratoula stratoula requested review from a team as code owners February 10, 2025 13:11
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 10, 2025

Pinging @elastic/kibana-esql (Team:ESQL)
nreese
nreese approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM
code review only
darnautov
darnautov reviewed Feb 12, 2025
View reviewed changes
@stratoula
Copy link
Contributor Author

stratoula commented Feb 13, 2025

@darnautov thanx, I addressed everything
darnautov
darnautov approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thx for making the edits
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 13, 2025

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-validation-autocomplete 204 205 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 495.3KB 495.3KB +24.0B
esql 226.4KB 247.1KB +20.7KB
lens 1.6MB 1.6MB +42.0B
total +20.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 423.6KB 423.7KB +41.0B
kbnUiSharedDeps-srcJs 3.6MB 3.6MB +296.0B
total +337.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-validation-autocomplete 216 217 +1

History
@stratoula stratoula merged commit f96b68d into elastic:main Feb 13, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 13, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13306672544
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 13, 2025
@stratoula
[ES|QL] Creates controls for stats functions (elastic#210170)
83faaa9 
## Summary

Closes elastic#207029

Allows the creation of function controls. These are only available for
STATS

<img width="880" alt="image"
src="https://github.com/user-attachments/assets/fe57c3e5-f42a-4d9c-95b3-4a5a12938821"
/>

### Release notes
Allows the creation of dynamic aggregations controls for ES|QL charts.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit f96b68d)
@kibanamachine kibanamachine mentioned this pull request Feb 13, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 13, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation
kibanamachine added a commit that referenced this pull request Feb 13, 2025
@kibanamachine @stratoula
[8.x] [ES|QL] Creates controls for stats functions (#210170) (#210985)
406e88f 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Creates controls for stats functions
(#210170)](#210170)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-02-13T11:28:18Z","message":"[ES|QL]
Creates controls for stats functions (#210170)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/207029\n\nAllows the creation
of function controls. These are only available for\nSTATS\n\n<img
width=\"880\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fe57c3e5-f42a-4d9c-95b3-4a5a12938821\"\n/>\n\n\n###
Release notes\nAllows the creation of dynamic aggregations controls for
ES|QL charts.\n\n### Checklist\n\nCheck the PR satisfies following
conditions. \n\nReviewers should verify this PR satisfies this list as
well.\n\n- [x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f96b68dbac70f887cb8b039e5619bdda9a84eb89","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Creates controls for stats
functions","number":210170,"url":"https://github.com/elastic/kibana/pull/210170","mergeCommit":{"message":"[ES|QL]
Creates controls for stats functions (#210170)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/207029\n\nAllows the creation
of function controls. These are only available for\nSTATS\n\n<img
width=\"880\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fe57c3e5-f42a-4d9c-95b3-4a5a12938821\"\n/>\n\n\n###
Release notes\nAllows the creation of dynamic aggregations controls for
ES|QL charts.\n\n### Checklist\n\nCheck the PR satisfies following
conditions. \n\nReviewers should verify this PR satisfies this list as
well.\n\n- [x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f96b68dbac70f887cb8b039e5619bdda9a84eb89"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210170","number":210170,"mergeCommit":{"message":"[ES|QL]
Creates controls for stats functions (#210170)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/207029\n\nAllows the creation
of function controls. These are only available for\nSTATS\n\n<img
width=\"880\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fe57c3e5-f42a-4d9c-95b3-4a5a12938821\"\n/>\n\n\n###
Release notes\nAllows the creation of dynamic aggregations controls for
ES|QL charts.\n\n### Checklist\n\nCheck the PR satisfies following
conditions. \n\nReviewers should verify this PR satisfies this list as
well.\n\n- [x] Any text added follows [EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] The PR
description includes the appropriate Release Notes section,\nand the
correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f96b68dbac70f887cb8b039e5619bdda9a84eb89"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
@florent-leborgne florent-leborgne mentioned this pull request Jun 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:enhancement Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

6 participants

@stratoula @elasticmachine @kibanamachine @drewdaemon @nreese @darnautov