[ES|QL][Lens] Keeps the chart configuration when possible#210780
Merged
stratoula merged 12 commits intoelastic:mainfrom Feb 21, 2025
Merged
[ES|QL][Lens] Keeps the chart configuration when possible#210780stratoula merged 12 commits intoelastic:mainfrom
stratoula merged 12 commits intoelastic:mainfrom
Conversation
stratoula
commented
Feb 13, 2025
| }; | ||
|
|
||
| export const injectESQLQueryIntoLensLayers = ( | ||
| attributes: TypedLensSerializedState['attributes'], |
Contributor
Author
There was a problem hiding this comment.
ℹ️ I would love to move this to the visualizations-utils package but the TypedLensSerializedState must move first and is a tricky one.
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7878[✅] x-pack/test/functional/apps/lens/group7/config.ts: 25/25 tests passed. |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7880[✅] x-pack/test/functional/apps/lens/group7/config.ts: 25/25 tests passed. |
stratoula
added
v9.1.0
v8.19.0
Feature:Lens
Feature:ES|QL
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
markov00
reviewed
Feb 19, 2025
x-pack/platform/plugins/shared/lens/public/app_plugin/shared/edit_on_the_fly/helpers.ts
Show resolved
Hide resolved
stratoula
commented
Feb 20, 2025
| wordWrap: 'on', | ||
| wrappingIndent: 'none', | ||
| }; | ||
| const codeEditorOptions: CodeEditorProps['options'] = useMemo( |
Contributor
Author
There was a problem hiding this comment.
ℹ️ Irrelevant with the PR, just saw that we do an extra rerender here
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
drewdaemon
approved these changes
Feb 20, 2025
| wordWrap: 'on', | ||
| wrappingIndent: 'none', | ||
| }; | ||
| const codeEditorOptions: CodeEditorProps['options'] = useMemo( |
markov00
approved these changes
Feb 21, 2025
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Feb 21, 2025
…0780) ## Summary Closes elastic#186366  It keeps the chart configuration when the user is doing actions compatible with the current query such as: - Adding a where filter - Changing to a compatible chart type (from example from bar to line or pie to treemap) - In general changing the query that doesnt affect the generated columns mapped to a chart. ### Release notes Keeps the chart configuration changes done by the user when changing the query whenever it is possible. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit cb77b97) # Conflicts: # src/platform/packages/private/kbn-esql-editor/src/esql_editor.tsx
stratoula
added a commit
that referenced
this pull request
Feb 21, 2025
) (#212013) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL][Lens] Keeps the chart configuration when possible (#210780)](#210780) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-02-21T08:24:00Z","message":"[ES|QL][Lens] Keeps the chart configuration when possible (#210780)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/186366\n\n\n\n\nIt keeps the chart configuration when the user is doing actions\ncompatible with the current query such as:\n\n- Adding a where filter\n- Changing to a compatible chart type (from example from bar to line or\npie to treemap)\n- In general changing the query that doesnt affect the generated columns\nmapped to a chart.\n\n### Release notes\n\nKeeps the chart configuration changes done by the user when changing the\nquery whenever it is possible.\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"cb77b978877443cdce12f00a42e54609c0b36dbc","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Visualizations","Feature:Lens","Feature:ES|QL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL][Lens] Keeps the chart configuration when possible","number":210780,"url":"https://github.com/elastic/kibana/pull/210780","mergeCommit":{"message":"[ES|QL][Lens] Keeps the chart configuration when possible (#210780)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/186366\n\n\n\n\nIt keeps the chart configuration when the user is doing actions\ncompatible with the current query such as:\n\n- Adding a where filter\n- Changing to a compatible chart type (from example from bar to line or\npie to treemap)\n- In general changing the query that doesnt affect the generated columns\nmapped to a chart.\n\n### Release notes\n\nKeeps the chart configuration changes done by the user when changing the\nquery whenever it is possible.\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"cb77b978877443cdce12f00a42e54609c0b36dbc"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210780","number":210780,"mergeCommit":{"message":"[ES|QL][Lens] Keeps the chart configuration when possible (#210780)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/186366\n\n\n\n\nIt keeps the chart configuration when the user is doing actions\ncompatible with the current query such as:\n\n- Adding a where filter\n- Changing to a compatible chart type (from example from bar to line or\npie to treemap)\n- In general changing the query that doesnt affect the generated columns\nmapped to a chart.\n\n### Release notes\n\nKeeps the chart configuration changes done by the user when changing the\nquery whenever it is possible.\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"cb77b978877443cdce12f00a42e54609c0b36dbc"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…0780) ## Summary Closes elastic#186366  It keeps the chart configuration when the user is doing actions compatible with the current query such as: - Adding a where filter - Changing to a compatible chart type (from example from bar to line or pie to treemap) - In general changing the query that doesnt affect the generated columns mapped to a chart. ### Release notes Keeps the chart configuration changes done by the user when changing the query whenever it is possible. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
florent-leborgne
added a commit
to elastic/docs-content
that referenced
this pull request
Jul 15, 2025
Closes: #1665 Documents: elastic/kibana#210780
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #186366
It keeps the chart configuration when the user is doing actions compatible with the current query such as:
Release notes
Keeps the chart configuration changes done by the user when changing the query whenever it is possible.
Checklist
release_note:*label is applied per the guidelines