[Discover] Display a warning and a tooltip for the _score column in the grid#211013
Merged
rbrtj merged 4 commits intoelastic:mainfrom Feb 17, 2025
Merged
Conversation
rbrtj
added
release_note:enhancement
Feature:Discover
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
Member
|
thx a lot @rbrtj, I didn't have the time to review, but our team will certainly take care of it ... just one question, do you have an idea why the async bundle is increased by 8.7 kb? it seems the change is adding 1 kb by each DataView usage, not a blocker, just thinking |
kertal
reviewed
Feb 14, 2025
src/platform/packages/shared/kbn-unified-data-table/src/components/data_table_columns.tsx
Outdated
Show resolved
Hide resolved
akowalska622
approved these changes
Feb 14, 2025
Contributor
akowalska622
left a comment
akowalska622
left a comment
There was a problem hiding this comment.
LGTM and works as expected, just minor nit added
Comment on lines
149
to
156
| dataView: DataView; | ||
| columnName: string; | ||
| columnDisplayName: string; | ||
| showColumnTokens?: boolean; | ||
| isSorted?: boolean; | ||
| columnsMeta?: DataTableColumnsMeta; | ||
| headerRowHeight?: number; | ||
| }) => { |
Contributor
There was a problem hiding this comment.
For consistency with DataTableColumnHeaderProps can we extract it to interface?
Also they both look pretty similar, I believe we can just extend DataTableColumnHeaderProps by isSorted, what do you think?
interface ExtendedDataTableColumnHeaderProps extends DataTableColumnHeaderProps {
isSorted?: boolean;
}
I leave interface name up to you
Contributor
There was a problem hiding this comment.
Or just extending it inline
export const DataTableScoreColumnHeader = ({
isSorted,
showColumnTokens,
columnName,
columnsMeta,
dataView,
headerRowHeight,
columnDisplayName,
}: DataTableColumnHeaderProps & { isSorted?: boolean }) => {
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @rbrtj |
Member
|
one thing: I think this should be a |
rbrtj
added
backport:skip
davismcphee
added
backport:version
Contributor
|
Starting backport for target branches: 8.x |
Contributor
|
Starting backport for target branches: 8.x |
Contributor
|
After some discussions, we've learned we should be backporting new work to 8.19 where possible. I updated the labels on this one to trigger a backport to 8.19. |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 5, 2025
… the grid (elastic#211013) Resolves: elastic#167271 https://github.com/user-attachments/assets/f21be330-a85d-471c-a6c3-d172ff7a15d2 (cherry picked from commit 67f6fd3)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 6, 2025
…umn in the grid (#211013) (#213296) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Display a warning and a tooltip for the `_score` column in the grid (#211013)](#211013) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-17T12:22:33Z","message":"[Discover] Display a warning and a tooltip for the `_score` column in the grid (#211013)\n\nResolves: https://github.com/elastic/kibana/issues/167271\n\n\n\nhttps://github.com/user-attachments/assets/f21be330-a85d-471c-a6c3-d172ff7a15d2","sha":"67f6fd3ec87eb41cfdbc89cee9a5cfa9f1bf2061","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Discover","enhancement","Team:DataDiscovery","papercut","backport:version","v9.1.0","v8.19.0"],"title":"[Discover] Display a warning and a tooltip for the `_score` column in the grid","number":211013,"url":"https://github.com/elastic/kibana/pull/211013","mergeCommit":{"message":"[Discover] Display a warning and a tooltip for the `_score` column in the grid (#211013)\n\nResolves: https://github.com/elastic/kibana/issues/167271\n\n\n\nhttps://github.com/user-attachments/assets/f21be330-a85d-471c-a6c3-d172ff7a15d2","sha":"67f6fd3ec87eb41cfdbc89cee9a5cfa9f1bf2061"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211013","number":211013,"mergeCommit":{"message":"[Discover] Display a warning and a tooltip for the `_score` column in the grid (#211013)\n\nResolves: https://github.com/elastic/kibana/issues/167271\n\n\n\nhttps://github.com/user-attachments/assets/f21be330-a85d-471c-a6c3-d172ff7a15d2","sha":"67f6fd3ec87eb41cfdbc89cee9a5cfa9f1bf2061"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #167271
Screen.Recording.2025-02-13.at.14.47.50.mov