[ResponseOps][MW] Allow users to delete MWs#211399
Merged
guskovaue merged 13 commits intoelastic:mainfrom Mar 3, 2025
Merged
Conversation
guskovaue
added
Feature:Alerting
release_note:skip
Contributor
Author
|
/ci |
guskovaue
added
backport:version
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7916[✅] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 100/100 tests passed. |
adcoelho
reviewed
Mar 3, 2025
Contributor
There was a problem hiding this comment.
Could you please upload the it renders test in x-pack/platform/plugins/shared/alerting/public/pages/maintenance_windows/components/maintenance_windows_list.test.tsx?
Contributor
Author
There was a problem hiding this comment.
Hey @adcoelho!
Why do you think it's important?
It just I did it from beginning, but it turned out that it'll be almost the same coverage as table_actions_popover.test.tsx. And also table_actions_popover.test.tsx + maintenance_windows_table.ts covers the whole functionality. So I decided that it's redundant.
WDYT?
Contributor
There was a problem hiding this comment.
I misread the test there.
I thought we had a section to make sure all the correct actions render, but i confused it with the status.
// check the status
expect(result.getAllByText('Running')).toHaveLength(1);
expect(result.getAllByText('Upcoming')).toHaveLength(1);
expect(result.getAllByText('Finished')).toHaveLength(1);
expect(result.getAllByText('Archived')).toHaveLength(1);
Nevermind then 👍
umbopepato
approved these changes
Mar 3, 2025
Member
umbopepato
left a comment
umbopepato
left a comment
There was a problem hiding this comment.
Local testing works correctly, also with limited privileges
LGTM! 🚀
adcoelho
approved these changes
Mar 3, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
cc @guskovaue |
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
2 tasks
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
guskovaue
added a commit
that referenced
this pull request
Mar 5, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][MW] Allow users to delete MWs (#211399)](#211399) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Julia","email":"iuliia.guskova@elastic.co"},"sourceCommit":{"committedDate":"2025-03-03T15:20:31Z","message":"[ResponseOps][MW] Allow users to delete MWs (#211399)\n\nResolve: https://github.com/elastic/kibana/issues/198559\nResolve: https://github.com/elastic/kibana/issues/205269\n\nHere I used the existing DELETE\n/internal/alerting/rules/maintenance_window/{id} API to delete MWs from\nthe UI.\nI added an action to the MW table so users can delete MWs. And show a\ndelete confirmation modal when users delete a MW from the UI.\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"6ce22f4a336caa774acd360e3f66b74517d0bad0","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","backport:version","v9.1.0","v8.19.0"],"title":"[ResponseOps][MW] Allow users to delete MWs","number":211399,"url":"https://github.com/elastic/kibana/pull/211399","mergeCommit":{"message":"[ResponseOps][MW] Allow users to delete MWs (#211399)\n\nResolve: https://github.com/elastic/kibana/issues/198559\nResolve: https://github.com/elastic/kibana/issues/205269\n\nHere I used the existing DELETE\n/internal/alerting/rules/maintenance_window/{id} API to delete MWs from\nthe UI.\nI added an action to the MW table so users can delete MWs. And show a\ndelete confirmation modal when users delete a MW from the UI.\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"6ce22f4a336caa774acd360e3f66b74517d0bad0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211399","number":211399,"mergeCommit":{"message":"[ResponseOps][MW] Allow users to delete MWs (#211399)\n\nResolve: https://github.com/elastic/kibana/issues/198559\nResolve: https://github.com/elastic/kibana/issues/205269\n\nHere I used the existing DELETE\n/internal/alerting/rules/maintenance_window/{id} API to delete MWs from\nthe UI.\nI added an action to the MW table so users can delete MWs. And show a\ndelete confirmation modal when users delete a MW from the UI.\n\n### Checklist\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [x] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed","sha":"6ce22f4a336caa774acd360e3f66b74517d0bad0"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
Resolve: elastic#198559 Resolve: elastic#205269 Here I used the existing DELETE /internal/alerting/rules/maintenance_window/{id} API to delete MWs from the UI. I added an action to the MW table so users can delete MWs. And show a delete confirmation modal when users delete a MW from the UI. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve: #198559
Resolve: #205269
Here I used the existing DELETE /internal/alerting/rules/maintenance_window/{id} API to delete MWs from the UI.
I added an action to the MW table so users can delete MWs. And show a delete confirmation modal when users delete a MW from the UI.
Checklist
release_note:breakinglabel should be applied in these situations.