[OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery context#211411
Merged
fkanout merged 17 commits intoelastic:mainfrom Mar 3, 2025
Merged
Conversation
botelastic
bot
added
the
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
fkanout
commented
Feb 17, 2025
| }, | ||
| }); | ||
| }); | ||
| test('includes reason message in the recovered alert context pulled from the last active alert ', async () => { |
Contributor
Author
There was a problem hiding this comment.
I added the test only to the Custom Threshold as the goal is to deprecate/invest less in Logs, Metrics, and Inventory rules.
Also, adding this test to other rules with the current structure/tools is time-consuming because it would require changing how the tests and the mock services work.
Contributor
Contributor
Author
|
botelastic
bot
added
the
Team:obs-ux-infra_services - DEPRECATED
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
crespocarlos
approved these changes
Feb 21, 2025
|
@fkanout will it be visible in Alert details as well? |
kdelemme
approved these changes
Feb 21, 2025
| }), | ||
| requiresAppContext: false, | ||
| defaultActionMessage: errorCountMessage, | ||
| defaultRecoveryMessage: transactionErrorRateRecoveryMessage, |
Contributor
There was a problem hiding this comment.
shouldn't it be errorCountRecoveryMessage?
Contributor
Author
@maciejforcone, this is for the action variable in the notification section of the connector. Are you referring to the Alert Details page? Where do you think we need to see the recovered context? |
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
History
cc @fkanout |
Contributor
|
Starting backport for target branches: 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 3, 2025
…context (elastic#211411) ## Summary It fixes elastic#184803 by: ### Adding the reason message to recovery context variables in the following rules: - Inventory Threshold - Metric threshold - Custom threshold - Log threshold ### Enabling recovery context and handling the recovery alert context for APM (except Anomaly) - Latency threshold - Error count - Failed transaction rate (cherry picked from commit 9a6b4ec)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 3, 2025
…overy context (#211411) (#212896) # Backport This will backport the following commits from `main` to `9.0`: - [[OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery context (#211411)](#211411) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Faisal Kanout","email":"faisal.kanout@elastic.co"},"sourceCommit":{"committedDate":"2025-03-03T12:04:52Z","message":"[OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery context (#211411)\n\n## Summary\n\nIt fixes #184803 by:\n\n### Adding the reason message to recovery context variables in the\nfollowing rules:\n- Inventory Threshold\n- Metric threshold\n- Custom threshold\n- Log threshold\n\n### Enabling recovery context and handling the recovery alert context\nfor APM (except Anomaly)\n- Latency threshold\n- Error count\n- Failed transaction rate","sha":"9a6b4ecda3c0f1db49f8f93cd6968b4e2f2055d7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Alerting","backport:prev-minor","Team:obs-ux-infra_services","Team:obs-ux-management","v9.1.0"],"title":"[OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery context","number":211411,"url":"https://github.com/elastic/kibana/pull/211411","mergeCommit":{"message":"[OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery context (#211411)\n\n## Summary\n\nIt fixes #184803 by:\n\n### Adding the reason message to recovery context variables in the\nfollowing rules:\n- Inventory Threshold\n- Metric threshold\n- Custom threshold\n- Log threshold\n\n### Enabling recovery context and handling the recovery alert context\nfor APM (except Anomaly)\n- Latency threshold\n- Error count\n- Failed transaction rate","sha":"9a6b4ecda3c0f1db49f8f93cd6968b4e2f2055d7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211411","number":211411,"mergeCommit":{"message":"[OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery context (#211411)\n\n## Summary\n\nIt fixes #184803 by:\n\n### Adding the reason message to recovery context variables in the\nfollowing rules:\n- Inventory Threshold\n- Metric threshold\n- Custom threshold\n- Log threshold\n\n### Enabling recovery context and handling the recovery alert context\nfor APM (except Anomaly)\n- Latency threshold\n- Error count\n- Failed transaction rate","sha":"9a6b4ecda3c0f1db49f8f93cd6968b4e2f2055d7"}}]}] BACKPORT--> Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…context (elastic#211411) ## Summary It fixes elastic#184803 by: ### Adding the reason message to recovery context variables in the following rules: - Inventory Threshold - Metric threshold - Custom threshold - Log threshold ### Enabling recovery context and handling the recovery alert context for APM (except Anomaly) - Latency threshold - Error count - Failed transaction rate
Contributor
|
Starting backport for target branches: 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 16, 2025
…context (elastic#211411) ## Summary It fixes elastic#184803 by: ### Adding the reason message to recovery context variables in the following rules: - Inventory Threshold - Metric threshold - Custom threshold - Log threshold ### Enabling recovery context and handling the recovery alert context for APM (except Anomaly) - Latency threshold - Error count - Failed transaction rate (cherry picked from commit 9a6b4ec)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 16, 2025
…overy context (#211411) (#218490) # Backport This will backport the following commits from `main` to `8.x`: - [[OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery context (#211411)](#211411) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Faisal Kanout","email":"faisal.kanout@elastic.co"},"sourceCommit":{"committedDate":"2025-03-03T12:04:52Z","message":"[OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery context (#211411)\n\n## Summary\n\nIt fixes #184803 by:\n\n### Adding the reason message to recovery context variables in the\nfollowing rules:\n- Inventory Threshold\n- Metric threshold\n- Custom threshold\n- Log threshold\n\n### Enabling recovery context and handling the recovery alert context\nfor APM (except Anomaly)\n- Latency threshold\n- Error count\n- Failed transaction rate","sha":"9a6b4ecda3c0f1db49f8f93cd6968b4e2f2055d7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Alerting","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery context","number":211411,"url":"https://github.com/elastic/kibana/pull/211411","mergeCommit":{"message":"[OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery context (#211411)\n\n## Summary\n\nIt fixes #184803 by:\n\n### Adding the reason message to recovery context variables in the\nfollowing rules:\n- Inventory Threshold\n- Metric threshold\n- Custom threshold\n- Log threshold\n\n### Enabling recovery context and handling the recovery alert context\nfor APM (except Anomaly)\n- Latency threshold\n- Error count\n- Failed transaction rate","sha":"9a6b4ecda3c0f1db49f8f93cd6968b4e2f2055d7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212896","number":212896,"state":"MERGED","mergeCommit":{"sha":"2fc95c610f0b8a7a2b57cfc38a48f722f4ce5b84","message":"[9.0] [OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery context (#211411) (#212896)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery\ncontext (#211411)](https://github.com/elastic/kibana/pull/211411)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Faisal Kanout <faisal.kanout@elastic.co>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/211411","number":211411,"mergeCommit":{"message":"[OBX-UX-MGTM][ALERTING] Add the reason message to the rules recovery context (#211411)\n\n## Summary\n\nIt fixes #184803 by:\n\n### Adding the reason message to recovery context variables in the\nfollowing rules:\n- Inventory Threshold\n- Metric threshold\n- Custom threshold\n- Log threshold\n\n### Enabling recovery context and handling the recovery alert context\nfor APM (except Anomaly)\n- Latency threshold\n- Error count\n- Failed transaction rate","sha":"9a6b4ecda3c0f1db49f8f93cd6968b4e2f2055d7"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It fixes #184803 by:
Adding the reason message to recovery context variables in the following rules:
Enabling recovery context and handling the recovery alert context for APM (except Anomaly)