Skip to content

[Global Search] Register custom integrations search provider#213013

Merged
kowalczyk-krzysztof merged 2 commits intoelastic:mainfrom
kowalczyk-krzysztof:feat/register-custom-integrations-search-provider
Mar 4, 2025
Merged

[Global Search] Register custom integrations search provider#213013
kowalczyk-krzysztof merged 2 commits intoelastic:mainfrom
kowalczyk-krzysztof:feat/register-custom-integrations-search-provider

Conversation

@kowalczyk-krzysztof
Copy link
Copy Markdown
Member

Summary

This PR creates search provider for custom integrations so they show up in Global Search.
Closes: #115778

@kowalczyk-krzysztof kowalczyk-krzysztof added release_note:enhancement backport:skip This PR does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team Feature:Navigational Search Global search bar labels Mar 4, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Mar 4, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof marked this pull request as ready for review March 4, 2025 18:44
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner March 4, 2025 18:44
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

icon: customIntegration.icons.find(({ src }) => Boolean(src))?.src,
});

export const createCustomIntegrationsSearchProvider = (
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some tests for this in search_provider.test.ts?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do.

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 156.9KB 157.5KB +618.0B

cc @kowalczyk-krzysztof

Copy link
Copy Markdown
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests. Code LGTM

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit c3c8f7b into elastic:main Mar 4, 2025
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
…#213013)

## Summary

This PR creates search provider for custom integrations so they show up
in Global Search.
Closes: elastic#115778
@kowalczyk-krzysztof kowalczyk-krzysztof deleted the feat/register-custom-integrations-search-provider branch August 31, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Navigational Search Global search bar release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v9.1.0

4 participants