[ES|QL] Fixes the wrong validation when a named param is used as function#213355
Merged
stratoula merged 1 commit intoelastic:mainfrom Mar 6, 2025
Merged
[ES|QL] Fixes the wrong validation when a named param is used as function#213355stratoula merged 1 commit intoelastic:mainfrom
stratoula merged 1 commit intoelastic:mainfrom
Conversation
stratoula
changed the title
13 tasks
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
|
stratoula
added
release_note:fix
v9.1.0
v8.19.0
Feature:ES|QL
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
darnautov
approved these changes
Mar 6, 2025
| // * or if it's a operators function, then all operands are agg functions or literals | ||
| // * or if it's a eval function then all arguments are agg functions or literals | ||
| // * or if a named param is used | ||
| function checkFunctionContent(arg: ESQLFunction) { |
Contributor
There was a problem hiding this comment.
Quick question: What is the motivation for defining checkFunctionContent and other functions inside statsValidator? Shall we move outside to the top level?
Contributor
Author
There was a problem hiding this comment.
yes this makes sense, will taje a look tmr in a follow up PR
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 6, 2025
…tion (elastic#213355) ## Summary Fixes the bug described here elastic#192255 (comment) <img width="1094" alt="image" src="https://github.com/user-attachments/assets/69d4f004-6a66-416b-8aa6-e477b0380010" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 4a8af4c)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 6, 2025
…s function (#213355) (#213407) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Fixes the wrong validation when a named param is used as function (#213355)](#213355) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-06T14:39:44Z","message":"[ES|QL] Fixes the wrong validation when a named param is used as function (#213355)\n\n## Summary\n\nFixes the bug described here\nhttps://github.com//issues/192255#issuecomment-2684125449\n\n\n<img width=\"1094\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/69d4f004-6a66-416b-8aa6-e477b0380010\"\n/>\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"4a8af4ca27f01e6f7d992e61c1f59feeff347a29","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] Fixes the wrong validation when a named param is used as function","number":213355,"url":"https://github.com/elastic/kibana/pull/213355","mergeCommit":{"message":"[ES|QL] Fixes the wrong validation when a named param is used as function (#213355)\n\n## Summary\n\nFixes the bug described here\nhttps://github.com//issues/192255#issuecomment-2684125449\n\n\n<img width=\"1094\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/69d4f004-6a66-416b-8aa6-e477b0380010\"\n/>\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"4a8af4ca27f01e6f7d992e61c1f59feeff347a29"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213355","number":213355,"mergeCommit":{"message":"[ES|QL] Fixes the wrong validation when a named param is used as function (#213355)\n\n## Summary\n\nFixes the bug described here\nhttps://github.com//issues/192255#issuecomment-2684125449\n\n\n<img width=\"1094\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/69d4f004-6a66-416b-8aa6-e477b0380010\"\n/>\n\n### Checklist\n\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"4a8af4ca27f01e6f7d992e61c1f59feeff347a29"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…tion (elastic#213355) ## Summary Fixes the bug described here elastic#192255 (comment) <img width="1094" alt="image" src="https://github.com/user-attachments/assets/69d4f004-6a66-416b-8aa6-e477b0380010" /> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the bug described here #192255 (comment)
Checklist