Skip to content

[ES|QL] Fixes warnings with escaped quotes#213685

Merged
stratoula merged 4 commits intoelastic:mainfrom
stratoula:fix-warnings-with-escaped-quots
Mar 11, 2025
Merged

[ES|QL] Fixes warnings with escaped quotes#213685
stratoula merged 4 commits intoelastic:mainfrom
stratoula:fix-warnings-with-escaped-quots

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Mar 10, 2025 •
edited by kibanamachine
Loading

Summary

Fixes a big where the warning appear wrong when the warning message has escaped quotes.

Before
image (84)

Now
image

Checklist

Brought at my attention from @nik9000 ❤️
@stratoula stratoula added release_note:fix Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.1.0 v8.19.0 backport:version Backport to applied version labels labels Mar 10, 2025
@stratoula stratoula marked this pull request as ready for review March 10, 2025 10:41
@stratoula stratoula requested a review from a team as a code owner March 10, 2025 10:41
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 10, 2025

Pinging @elastic/kibana-esql (Team:ESQL)
darnautov
darnautov reviewed Mar 10, 2025
View reviewed changes
@nik9000
Copy link
Member

nik9000 commented Mar 10, 2025

With the fix the screenshot says:

evaluation of [TO_LOWER([\FOO\, \BAR\)])] failed

Could it be:

evaluation of [TO_LOWER([\"FOO\", \"BAR\")])] failed

or:

evaluation of [TO_LOWER(["FOO", "BAR")])] failed

?

I think the bottom one is best because I never typed a \", just ".
@stratoula
Copy link
Contributor Author

stratoula commented Mar 10, 2025

@nik9000 great catch, I missed that

image
@nik9000
Copy link
Member

nik9000 commented Mar 10, 2025

@stratoula so now there isn't a " or \ - could you add the " back? Sorry - I don't envy you the regex hacking.
@stratoula
Copy link
Contributor Author

stratoula commented Mar 10, 2025

@nik9000 yes this is a good point. Fixed it here 770c9b4

image
darnautov
darnautov reviewed Mar 11, 2025
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one minor suggestion
@stratoula @darnautov
Update src/platform/packages/private/kbn-esql-editor/src/helpers.ts
7d35ca6 
Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 11, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 239.1KB 239.2KB +31.0B

History
@stratoula stratoula merged commit 0addb3f into elastic:main Mar 11, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 11, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13788414536
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 11, 2025
@stratoula @darnautov
[ES|QL] Fixes warnings with escaped quotes (elastic#213685)
56cf24e 
## Summary

Fixes a big where the warning appear wrong when the warning message has
escaped quotes.

**Before**
![image
(84)](https://github.com/user-attachments/assets/db7eaca1-bb04-4785-ae3e-2ecb3da694ee)

**Now**

![image](https://github.com/user-attachments/assets/afc107e1-b83d-4d3b-862c-6c2bffc27656)

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Brought at my attention from @nik9000 ❤️

---------

Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>
(cherry picked from commit 0addb3f)
@kibanamachine kibanamachine mentioned this pull request Mar 11, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 11, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation
stratoula added a commit that referenced this pull request Mar 11, 2025
@kibanamachine @stratoula
[8.x] [ES|QL] Fixes warnings with escaped quotes (#213685) (#213912)
00e5613 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Fixes warnings with escaped quotes
(#213685)](#213685)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-11T12:48:45Z","message":"[ES|QL]
Fixes warnings with escaped quotes (#213685)\n\n## Summary\n\nFixes a
big where the warning appear wrong when the warning message has\nescaped
quotes.\n\n**Before**\n![image\n(84)](https://github.com/user-attachments/assets/db7eaca1-bb04-4785-ae3e-2ecb3da694ee)\n\n\n**Now**\n\n![image](https://github.com/user-attachments/assets/afc107e1-b83d-4d3b-862c-6c2bffc27656)\n\n\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n\n\nBrought at my
attention from @nik9000 ❤️\n\n---------\n\nCo-authored-by: Dima Arnautov
<arnautov.dima@gmail.com>","sha":"0addb3fd6d82e5c3c11dd5ea654306196a7aebd5","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Fixes warnings with escaped
quotes","number":213685,"url":"https://github.com/elastic/kibana/pull/213685","mergeCommit":{"message":"[ES|QL]
Fixes warnings with escaped quotes (#213685)\n\n## Summary\n\nFixes a
big where the warning appear wrong when the warning message has\nescaped
quotes.\n\n**Before**\n![image\n(84)](https://github.com/user-attachments/assets/db7eaca1-bb04-4785-ae3e-2ecb3da694ee)\n\n\n**Now**\n\n![image](https://github.com/user-attachments/assets/afc107e1-b83d-4d3b-862c-6c2bffc27656)\n\n\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n\n\nBrought at my
attention from @nik9000 ❤️\n\n---------\n\nCo-authored-by: Dima Arnautov
<arnautov.dima@gmail.com>","sha":"0addb3fd6d82e5c3c11dd5ea654306196a7aebd5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213685","number":213685,"mergeCommit":{"message":"[ES|QL]
Fixes warnings with escaped quotes (#213685)\n\n## Summary\n\nFixes a
big where the warning appear wrong when the warning message has\nescaped
quotes.\n\n**Before**\n![image\n(84)](https://github.com/user-attachments/assets/db7eaca1-bb04-4785-ae3e-2ecb3da694ee)\n\n\n**Now**\n\n![image](https://github.com/user-attachments/assets/afc107e1-b83d-4d3b-862c-6c2bffc27656)\n\n\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n\n\nBrought at my
attention from @nik9000 ❤️\n\n---------\n\nCo-authored-by: Dima Arnautov
<arnautov.dima@gmail.com>","sha":"0addb3fd6d82e5c3c11dd5ea654306196a7aebd5"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
@stratoula @darnautov @CAWilson94
[ES|QL] Fixes warnings with escaped quotes (elastic#213685)
e8e7b81 
## Summary

Fixes a big where the warning appear wrong when the warning message has
escaped quotes.

**Before**
![image
(84)](https://github.com/user-attachments/assets/db7eaca1-bb04-4785-ae3e-2ecb3da694ee)


**Now**

![image](https://github.com/user-attachments/assets/afc107e1-b83d-4d3b-862c-6c2bffc27656)



### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios


Brought at my attention from @nik9000 ❤️

---------

Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:fix Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

5 participants

@stratoula @elasticmachine @nik9000 @kibanamachine @darnautov