[Lens][Embeddable] Fix unnecessary rerender on view mode change#213902
Merged
dej611 merged 2 commits intoelastic:mainfrom Mar 12, 2025
Merged
[Lens][Embeddable] Fix unnecessary rerender on view mode change#213902dej611 merged 2 commits intoelastic:mainfrom
dej611 merged 2 commits intoelastic:mainfrom
Conversation
dej611
added
release_note:fix
Team:Visualizations
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @dej611 |
nickofthyme
approved these changes
Mar 11, 2025
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
…tic#213902) ## Summary Fixes elastic#203020 Improve drill down check before triggering a rerender. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 14b0c61)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2025
…tic#213902) ## Summary Fixes elastic#203020 Improve drill down check before triggering a rerender. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 14b0c61)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 12, 2025
…#213902) (#214073) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens][Embeddable] Fix unnecessary rerender on view mode change (#213902)](#213902) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T09:09:33Z","message":"[Lens][Embeddable] Fix unnecessary rerender on view mode change (#213902)\n\n## Summary\n\nFixes #203020 \n\nImprove drill down check before triggering a rerender.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"14b0c611b1c479fa8e9fdb1c98f2b6c8f55ca12e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:version","v9.1.0","v8.19.0","v8.18.1","v8.17.4","v9.0.1"],"title":"[Lens][Embeddable] Fix unnecessary rerender on view mode change","number":213902,"url":"https://github.com/elastic/kibana/pull/213902","mergeCommit":{"message":"[Lens][Embeddable] Fix unnecessary rerender on view mode change (#213902)\n\n## Summary\n\nFixes #203020 \n\nImprove drill down check before triggering a rerender.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"14b0c611b1c479fa8e9fdb1c98f2b6c8f55ca12e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18","8.17","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213902","number":213902,"mergeCommit":{"message":"[Lens][Embeddable] Fix unnecessary rerender on view mode change (#213902)\n\n## Summary\n\nFixes #203020 \n\nImprove drill down check before triggering a rerender.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"14b0c611b1c479fa8e9fdb1c98f2b6c8f55ca12e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Mar 12, 2025
#213902) (#214072) # Backport This will backport the following commits from `main` to `8.18`: - [[Lens][Embeddable] Fix unnecessary rerender on view mode change (#213902)](#213902) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-03-12T09:09:33Z","message":"[Lens][Embeddable] Fix unnecessary rerender on view mode change (#213902)\n\n## Summary\n\nFixes #203020 \n\nImprove drill down check before triggering a rerender.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"14b0c611b1c479fa8e9fdb1c98f2b6c8f55ca12e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:version","v9.1.0","v8.19.0","v8.18.1","v8.17.4","v9.0.1"],"title":"[Lens][Embeddable] Fix unnecessary rerender on view mode change","number":213902,"url":"https://github.com/elastic/kibana/pull/213902","mergeCommit":{"message":"[Lens][Embeddable] Fix unnecessary rerender on view mode change (#213902)\n\n## Summary\n\nFixes #203020 \n\nImprove drill down check before triggering a rerender.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"14b0c611b1c479fa8e9fdb1c98f2b6c8f55ca12e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.18","8.17","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213902","number":213902,"mergeCommit":{"message":"[Lens][Embeddable] Fix unnecessary rerender on view mode change (#213902)\n\n## Summary\n\nFixes #203020 \n\nImprove drill down check before triggering a rerender.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"14b0c611b1c479fa8e9fdb1c98f2b6c8f55ca12e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
7 tasks
7 tasks
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
…tic#213902) ## Summary Fixes elastic#203020 Improve drill down check before triggering a rerender. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #203020
Improve drill down check before triggering a rerender.
Checklist