Skip to content

Custom link colour option for top banner#214241

Merged
paulinashakirova merged 5 commits intoelastic:mainfrom
paulinashakirova:banner-link-color
Mar 25, 2025
Merged

Custom link colour option for top banner#214241
paulinashakirova merged 5 commits intoelastic:mainfrom
paulinashakirova:banner-link-color

Conversation

@paulinashakirova
Copy link
Contributor

@paulinashakirova paulinashakirova commented Mar 12, 2025

Summary

This PR resolves Link color in banner shown in blue and not the defined color issue.

Now there is a new option added that appllies custom colour specifically for links, and can be fully customized.

Screenshot 2025-03-12 at 18 23 40
  • Updated documentation
    • in Cloud
    • advanced-settings
    • configuration
  • Added to plugins
    • kibana_usage
    • telemetry
  • Implemented new 'linkColor' property for the banners
  • Updated functional tests
@paulinashakirova paulinashakirova added bug Fixes for quality problems that affect the customer experience release_note:fix Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// backport:prev-minor labels Mar 12, 2025
@paulinashakirova paulinashakirova self-assigned this Mar 12, 2025
@paulinashakirova paulinashakirova requested review from a team as code owners March 12, 2025 17:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@paulinashakirova paulinashakirova marked this pull request as draft March 12, 2025 20:57
`xpack.banners.textColor`
: The color for the banner text. Defaults to `#8A6A0A`.

`xpack.banners.linkColor`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked - set up this setting in kibana.dev.yml and when i ran the project - it defaulted to a colour I defined in .yml file.

@paulinashakirova paulinashakirova marked this pull request as ready for review March 19, 2025 16:33
@paulinashakirova paulinashakirova requested review from a team as code owners March 19, 2025 16:33
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana management changes lgtm

Copy link
Contributor

@ddillinger ddillinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

telemetry schema change ✅

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem to be working well 👍

I suggest we don't backport this because I see it more as a new feature than a bugfix

@Dosant Dosant added backport:skip This PR does not require backporting and removed backport:prev-minor labels Mar 25, 2025
@ryankeairns ryankeairns self-requested a review March 25, 2025 16:21
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change!

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
banners 26 13 -13

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-ids 136 137 +1
banners 9 10 +1
total +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
banners 8.4KB 3.9KB -4.5KB
Unknown metric groups

API count

id before after diff
@kbn/management-settings-ids 137 138 +1
banners 9 10 +1
total +2

History

cc @paulinashakirova

@paulinashakirova paulinashakirova merged commit 637c61a into elastic:main Mar 25, 2025
12 checks passed
@paulinashakirova paulinashakirova deleted the banner-link-color branch March 25, 2025 19:26
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
This PR resolves [Link color in banner shown in blue and not the defined
color](elastic#206266) issue.

Now there is a new option added that applies custom color specifically
for links, and can be fully customized.

- Updated documentation
  - in Cloud
  - advanced-settings
  - configuration
- Added to plugins
  - kibana_usage
  - telemetry
- Implemented new 'linkColor' property for the banners
- Updated functional tests
florent-leborgne added a commit to florent-leborgne/kibana that referenced this pull request Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience release_note:fix scss-removal Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v9.1.0

9 participants