[ES|QL] Calculate the query for retrieving the values correctly#214905
Merged
stratoula merged 3 commits intoelastic:mainfrom Mar 21, 2025
Merged
[ES|QL] Calculate the query for retrieving the values correctly#214905stratoula merged 3 commits intoelastic:mainfrom
stratoula merged 3 commits intoelastic:mainfrom
Conversation
stratoula
added
v9.1.0
v8.19.0
Feature:ES|QL
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Async chunks
History
|
drewdaemon
approved these changes
Mar 20, 2025
Contributor
drewdaemon
left a comment
drewdaemon
left a comment
There was a problem hiding this comment.
Seems good.
I guess we don't support looking ahead, but that's in line with everything else in autocomplete 👍
Screen.Recording.2025-03-20.at.10.02.11.AM.mov
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 21, 2025
…tic#214905) ## Summary My function to calculate the query for retrieving the values wasn't complete. This fixes it by taking under consideration the cursor position  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 96ba76d)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 21, 2025
…#214905) (#215434) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Calculate the query for retrieving the values correctly (#214905)](#214905) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-21T06:44:39Z","message":"[ES|QL] Calculate the query for retrieving the values correctly (#214905)\n\n## Summary\n\nMy function to calculate the query for retrieving the values wasn't\ncomplete. This fixes it by taking under consideration the cursor\nposition\n\n\n\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"96ba76de2b5cccbf71c7588e01d763bb45a6d7aa","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] Calculate the query for retrieving the values correctly","number":214905,"url":"https://github.com/elastic/kibana/pull/214905","mergeCommit":{"message":"[ES|QL] Calculate the query for retrieving the values correctly (#214905)\n\n## Summary\n\nMy function to calculate the query for retrieving the values wasn't\ncomplete. This fixes it by taking under consideration the cursor\nposition\n\n\n\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"96ba76de2b5cccbf71c7588e01d763bb45a6d7aa"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214905","number":214905,"mergeCommit":{"message":"[ES|QL] Calculate the query for retrieving the values correctly (#214905)\n\n## Summary\n\nMy function to calculate the query for retrieving the values wasn't\ncomplete. This fixes it by taking under consideration the cursor\nposition\n\n\n\n\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"96ba76de2b5cccbf71c7588e01d763bb45a6d7aa"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Mar 24, 2025
…tic#214905) ## Summary My function to calculate the query for retrieving the values wasn't complete. This fixes it by taking under consideration the cursor position  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
…tic#214905) ## Summary My function to calculate the query for retrieving the values wasn't complete. This fixes it by taking under consideration the cursor position  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
My function to calculate the query for retrieving the values wasn't complete. This fixes it by taking under consideration the cursor position
Checklist