Skip to content

[ES|QL] Highlights the code examples in our inline docs#214915

Merged
stratoula merged 1 commit intoelastic:mainfrom
stratoula:docs-esql-formatting
Mar 19, 2025
Merged

[ES|QL] Highlights the code examples in our inline docs#214915
stratoula merged 1 commit intoelastic:mainfrom
stratoula:docs-esql-formatting

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Mar 18, 2025

Summary

Adds ES|QL highlight in our inline docs

image (87)

@stratoula stratoula added v9.1.0 v8.19.0 release_note:enhancement backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// labels Mar 18, 2025
@stratoula stratoula changed the title [ES|QL] Format markdown codeblock to esql highlight Mar 18, 2025
@stratoula stratoula marked this pull request as ready for review March 18, 2025 09:02
@stratoula stratoula requested a review from a team as a code owner March 18, 2025 09:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 239.3KB 240.1KB +885.0B
unifiedSearch 347.5KB 348.3KB +885.0B
total +1.7KB
Copy link
Contributor

@vadimkibana vadimkibana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks beautiful!

@stratoula stratoula merged commit 66b00f3 into elastic:main Mar 19, 2025
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13943499242

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [ES|QL] Update function metadata (#215087)

Manual backport

To create the backport manually run:

node scripts/backport --pr 214915

Questions ?

Please refer to the Backport tool documentation

@stratoula
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit to stratoula/kibana that referenced this pull request Mar 19, 2025
## Summary

Adds ES|QL highlight in our inline docs

![image
(87)](https://github.com/user-attachments/assets/a08c21b4-f11b-4366-aaa1-8505e973d201)

(cherry picked from commit 66b00f3)

# Conflicts:
#	src/platform/packages/private/kbn-language-documentation/src/sections/esql_documentation_sections.tsx
#	src/platform/packages/private/kbn-language-documentation/src/sections/generated/scalar_functions.tsx
stratoula added a commit that referenced this pull request Mar 19, 2025
… (#215116)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Highlights the code examples in our inline docs
(#214915)](#214915)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-03-19T09:46:30Z","message":"[ES|QL]
Highlights the code examples in our inline docs (#214915)\n\n##
Summary\n\nAdds ES|QL highlight in our inline
docs\n\n\n![image\n(87)](https://github.com/user-attachments/assets/a08c21b4-f11b-4366-aaa1-8505e973d201)","sha":"66b00f3583a1cc5d574f359ed560ae3fff2c3abc","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Highlights the code examples in our inline
docs","number":214915,"url":"https://github.com/elastic/kibana/pull/214915","mergeCommit":{"message":"[ES|QL]
Highlights the code examples in our inline docs (#214915)\n\n##
Summary\n\nAdds ES|QL highlight in our inline
docs\n\n\n![image\n(87)](https://github.com/user-attachments/assets/a08c21b4-f11b-4366-aaa1-8505e973d201)","sha":"66b00f3583a1cc5d574f359ed560ae3fff2c3abc"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214915","number":214915,"mergeCommit":{"message":"[ES|QL]
Highlights the code examples in our inline docs (#214915)\n\n##
Summary\n\nAdds ES|QL highlight in our inline
docs\n\n\n![image\n(87)](https://github.com/user-attachments/assets/a08c21b4-f11b-4366-aaa1-8505e973d201)","sha":"66b00f3583a1cc5d574f359ed560ae3fff2c3abc"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this pull request Mar 20, 2025
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Mar 24, 2025
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:enhancement Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

4 participants