[User Profile Settings] Implement toggle for high contrast mode#216242
[User Profile Settings] Implement toggle for high contrast mode#216242tsullivan merged 7 commits intoelastic:mainfrom
Conversation
36272b6 to
9d32cb3
Compare
9d32cb3 to
e3b18c3
Compare
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
|
Pinging @elastic/kibana-security (Team:Security) |
| // colorMode provided by the `theme`. | ||
| const colorMode = colorModeProp || themeColorMode; | ||
|
|
||
| const getUserProfile$ = userProfile?.getUserProfile$ ?? Rx.of; |
There was a problem hiding this comment.
tiny suggestion to memo the observable, because now useObservable would unsubscribe and subscribe with every render
There was a problem hiding this comment.
@Dosant I take it you mean we should call a memoized version of getUserProfile$. Is this what you mean?
- const getUserProfile$ = userProfile?.getUserProfile$ ?? Rx.of;
+ const getUserProfile$ = useMemo(
+ () => userProfile?.getUserProfile$ ?? Rx.of,
+ [userProfile?.getUserProfile$]
+ );
src/platform/packages/shared/react/kibana_context/root/eui_provider.tsx
Outdated
Show resolved
Hide resolved
|
Pinging @elastic/kibana-core (Team:Core) |
gsoldevila
left a comment
There was a problem hiding this comment.
The src/core/packages/overlays/browser-internal/src/modal/__snapshots__/modal_service.test.tsx.snap snapshot is crazy long and thus useless.
I'll improve the related test on a follow-up PR.
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
Summary
Closes #176219
Depends on #215698
EUI provides documentation about high contrast mode. This includes info about when it is enabled automatically, and some developer utilities. See: https://eui.elastic.co/#/theming/high-contrast-mode
Release note
Added an option to User Settings that allows the Kibana interface to display in a high contrast mode.