[ES|QL] Autocomplete for `STATS...WHERE` by drewdaemon · Pull Request #216379 · elastic/kibana

drewdaemon · 2025-03-28T20:01:12Z

Summary

Resolve #209359

(No match operator or full-text search functions)

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

…moar-places

elasticmachine · 2025-04-01T03:42:31Z

Pinging @elastic/kibana-esql (Team:ESQL)

stratoula

This looks really nice indeed! I have some comments and a bug:

When I do something like

I get an error in the console and I dont have suggestions either (I am selecting the comma from the dropdown)

stratoula · 2025-04-01T06:17:11Z

...n-esql-validation-autocomplete/src/autocomplete/__tests__/autocomplete.command.stats.test.ts

+        /**
+         * @todo re-enable when expression autocomplete is officially supported for STATS ... BY
+         */
+        // await assertSuggestions('from a | stats avg(b) by integerField % /', [


Why these tests are commented out? Our changes should not affect them

When we detected an operator in STATS we were sending the code to getFunctionArgsSuggestions which worked in this case. So it was kind of a half-hearted attempt to support expressions in the STATS <here>.

I removed that logic from getAstContext because it was sending us to the wrong place in the STATS ... WHERE <here>.

At the time, I was thinking I would add first-class expressions support for this case too, but that is for later in #216492.

I should be able to adjust the getAstContext logic to restore the original behavior without ruining the work done for STATS... WHERE.

Restored in 40ada59

stratoula · 2025-04-01T06:17:51Z

...n-esql-validation-autocomplete/src/autocomplete/__tests__/autocomplete.command.stats.test.ts

-        test('suggests `??function` option', async () => {
-          const { suggest } = await setup();
-
+        test('suggests `?function` option', async () => {


Why did you change the test here? It should suggest ??function

I didn't... maybe a merge thing. Will clean it up

stratoula · 2025-04-01T06:18:06Z

...n-esql-validation-autocomplete/src/autocomplete/__tests__/autocomplete.command.stats.test.ts

-        test('suggests `??field` option', async () => {
-          const { suggest } = await setup();
-
+        test('suggests `?field` option', async () => {


Same here

Suggested change

test('suggests `?field` option', async () => {

test('suggests `??field` option', async () => {

stratoula · 2025-04-01T06:23:27Z

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/autocomplete/helper.ts

+
+/**
+ * Encapsulates handling of the "is null" and "is not null"
+ * checks...


Something missing here?

Nope. That's all I have to say 🤣

(I can expand a bit)

Updated in 866a5e4

stratoula · 2025-04-01T06:24:30Z

src/platform/packages/shared/kbn-esql-validation-autocomplete/src/shared/context.ts

      // command ... "<here>"
      return { type: 'value' as const, command, node, option, containingFunction };
    }
+    // /**


Why is this commented out?

leftover, will remove

Updated in 866a5e4

drewdaemon · 2025-04-01T16:54:51Z

Some observations about the bug

It's reproducible on main... just copy FROM kibana_sample_data_logs | STATS count = COUNT(*) /* you can group by a field using the BY operator */ WHERE extension.keyword != "" and type ,
It only happens when there's a comment
The error is happening within the AST building... I've traced it to this line

I'll dig a bit more. If the fix is simple, I can pull it into this PR.

drewdaemon · 2025-04-01T17:27:04Z

Looks like we get an undefined node with this particular query, so the code is trying to attach the comment to an undefined AST node.

drewdaemon · 2025-04-01T17:47:18Z

Fixed in f03e5b6

stratoula

Awesome, thanx for fixing the bug in this PR too 🙌

…moar-places

elasticmachine · 2025-04-02T16:32:52Z

💔 Build Failed

Buildkite Build
Commit: e2554ed

Failed CI Steps

Test Failures

[job] [logs] Jest Tests #2 / autocomplete.suggest STATS [ BY ] ... ... ...WHERE expression... Parity with WHERE command matches WHERE suggestions after a boolean expression
[job] [logs] Jest Tests #2 / autocomplete.suggest STATS [ BY ] ... ... ...WHERE expression... Parity with WHERE command matches WHERE suggestions after a boolean expression
[job] [logs] Jest Tests #2 / autocomplete.suggest STATS [ BY ] ... ... ...WHERE expression... Parity with WHERE command matches WHERE suggestions after a keyword expression
[job] [logs] Jest Tests #2 / autocomplete.suggest STATS [ BY ] ... ... ...WHERE expression... Parity with WHERE command matches WHERE suggestions after a keyword expression

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-srcJs`	3.6MB	3.6MB	+935.0B

History

💚 Build #289197 succeeded f03e5b6
💚 Build #289106 succeeded 40ada59

kibanamachine · 2025-04-02T19:38:06Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/14228097110

## Summary Resolve elastic#209359 (No match operator or full-text search functions) ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 2fda88c)

kibanamachine · 2025-04-02T19:50:22Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Autocomplete for `STATS...WHERE` (#216379)](#216379)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Drew Tate <drew.tate@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

drewdaemon added 24 commits February 6, 2025 16:42

Merge branch 'main' of github.com:elastic/kibana

0e937a9

Merge branch 'main' of github.com:elastic/kibana

7ffbf4c

Merge branch 'main' of github.com:elastic/kibana

b426318

Merge branch 'main' of github.com:elastic/kibana

511ccaa

Merge branch 'main' of github.com:elastic/kibana

2d71300

Merge branch 'main' of github.com:elastic/kibana

0076de9

Merge branch 'main' of github.com:elastic/kibana

2898ce1

Merge branch 'main' of github.com:elastic/kibana

ace0009

Merge branch 'main' of github.com:elastic/kibana

6cdd8c1

Merge branch 'main' of github.com:elastic/kibana

98616e9

Merge branch 'main' of github.com:elastic/kibana

64e40fd

Merge branch 'main' of github.com:elastic/kibana

1e3f8d1

Merge branch 'main' of github.com:elastic/kibana

afd5630

Merge branch 'main' of github.com:elastic/kibana

31c6cb3

Merge branch 'main' of github.com:elastic/kibana

08f4b1b

Merge branch 'main' of github.com:elastic/kibana

0c11f55

Merge branch 'main' of github.com:elastic/kibana

de2bc7a

Merge branch 'main' of github.com:elastic/kibana

828d142

Merge branch 'main' of github.com:elastic/kibana into expressions-in-…

6900864

…moar-places

Basic WHERE support

6ba3f08

make it work

0c30f12

add a few expression smoke tests

9363312

make the tests happy

fd11634

Merge branch 'main' of github.com:elastic/kibana into expressions-in-…

8cb4376

…moar-places

drewdaemon mentioned this pull request Mar 31, 2025

[ES|QL] extend expression autocomplete support #216492

Closed

drewdaemon added 3 commits March 31, 2025 18:18

Merge branch 'main' of github.com:elastic/kibana into expressions-in-…

2cf33a9

…moar-places

increase operator support, test WHERE parity

592eecb

support multiple expressions

59a3eba

drewdaemon added release_note:enhancement Feature:ES|QL ES|QL related features in Kibana labels Apr 1, 2025

drewdaemon added Team:ESQL ES|QL related features in Kibana t// v9.1.0 v8.19.0 labels Apr 1, 2025

drewdaemon marked this pull request as ready for review April 1, 2025 03:42

drewdaemon requested a review from a team as a code owner April 1, 2025 03:42

stratoula added the backport:version Backport to applied version labels label Apr 1, 2025

stratoula reviewed Apr 1, 2025

View reviewed changes

drewdaemon added 2 commits April 1, 2025 07:26

clean up some stuff

866a5e4

re-enable stats behavior

40ada59

fix undefined arg bug

f03e5b6

drewdaemon requested a review from stratoula April 1, 2025 17:47

stratoula approved these changes Apr 2, 2025

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into expressions-in-…

e2554ed

…moar-places

drewdaemon enabled auto-merge (squash) April 2, 2025 14:54

update operators

c471a3e

drewdaemon merged commit 2fda88c into elastic:main Apr 2, 2025
9 checks passed

kibanamachine mentioned this pull request Apr 2, 2025

[8.x] [ES|QL] Autocomplete for STATS...WHERE (#216379) #216920

Merged

florent-leborgne mentioned this pull request Jun 10, 2025

[ES|QL editor in Kibana] Support for aggregation filtering autocomplete elastic/docs-content#1680

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ES|QL] Autocomplete for `STATS...WHERE`#216379

[ES|QL] Autocomplete for `STATS...WHERE`#216379
drewdaemon merged 32 commits intoelastic:mainfrom
drewdaemon:expressions-in-moar-places

drewdaemon commented Mar 28, 2025 •

edited by kibanamachine

Loading

elasticmachine commented Apr 1, 2025

stratoula left a comment

stratoula Apr 1, 2025

drewdaemon Apr 1, 2025

drewdaemon Apr 1, 2025

stratoula Apr 1, 2025

drewdaemon Apr 1, 2025

drewdaemon Apr 1, 2025

stratoula Apr 1, 2025

drewdaemon Apr 1, 2025

stratoula Apr 1, 2025

drewdaemon Apr 1, 2025

drewdaemon Apr 1, 2025

drewdaemon Apr 1, 2025

stratoula Apr 1, 2025

drewdaemon Apr 1, 2025

drewdaemon Apr 1, 2025

drewdaemon commented Apr 1, 2025 •

edited

Loading

drewdaemon commented Apr 1, 2025

drewdaemon commented Apr 1, 2025

stratoula left a comment

elasticmachine commented Apr 2, 2025 •

edited

Loading

Uh oh!

kibanamachine commented Apr 2, 2025

kibanamachine commented Apr 2, 2025

Labels

4 participants

	test('suggests `?field` option', async () => {
	test('suggests `??field` option', async () => {

Conversation

drewdaemon commented Mar 28, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

elasticmachine commented Apr 1, 2025

stratoula left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drewdaemon commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

drewdaemon commented Apr 1, 2025

drewdaemon commented Apr 1, 2025

stratoula left a comment

Choose a reason for hiding this comment

elasticmachine commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Page load bundle

History

Uh oh!

kibanamachine commented Apr 2, 2025

kibanamachine commented Apr 2, 2025

💚 All backports created successfully

Questions ?

Labels

4 participants

drewdaemon commented Mar 28, 2025 •

edited by kibanamachine

Loading

drewdaemon commented Apr 1, 2025 •

edited

Loading

elasticmachine commented Apr 2, 2025 •

edited

Loading