[ML] Change Point Detection: Fixes 'Use full data' button issue which could cause page to crash#217291
Merged
rbrtj merged 1 commit intoelastic:mainfrom Apr 7, 2025
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
added
the
Feature:ML/AIOps
rbrtj
added
release_note:fix
backport:version
36 tasks
darnautov
approved these changes
Apr 7, 2025
peteharverson
approved these changes
Apr 7, 2025
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
LGTM. Tested and confirmed fixes issue I was seeing in the Change Point Detection page and when leaving the Transforms wizard.
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 7, 2025
… could cause page to crash (elastic#217291) Fixes an issue on pages which have a 'Use full data' button, such as the Change Point Detection page inside ML AIOps Labs and the Transforms wizard, where an error where with caching inside the `FieldStatsFlyoutProvider` could cause the page to break. Steps to reproduce: 1. Go to Change Point Detection in ML. 2. Click "Use full data". 3. Change the date in the time picker to a range different from the full data time range (e.g., last 15 minutes) and apply. 4. Click "Use full data" again. It occurs only in `React` > 18 Backporting to 8.19, as it is possible that React 18 will be enabled in 8.19 as well. <img width="1481" alt="image" src="https://github.com/user-attachments/assets/926c1f2f-4b83-44bb-ba99-a45b2428697a" /> (cherry picked from commit 129b150)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 7, 2025
… which could cause page to crash (#217291) (#217320) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Change Point Detection: Fixes 'Use full data' button issue which could cause page to crash (#217291)](#217291) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-04-07T13:19:48Z","message":"[ML] Change Point Detection: Fixes 'Use full data' button issue which could cause page to crash (#217291)\n\nFixes an issue on pages which have a 'Use full data' button, such as the\nChange Point Detection page inside ML AIOps Labs and the Transforms\nwizard, where an error where with caching inside the\n`FieldStatsFlyoutProvider` could cause the page to break.\n\nSteps to reproduce:\n1. Go to Change Point Detection in ML.\n2. Click \"Use full data\".\n3. Change the date in the time picker to a range different from the full\ndata time range (e.g., last 15 minutes) and apply.\n4. Click \"Use full data\" again.\n\nIt occurs only in `React` > 18\nBackporting to 8.19, as it is possible that React 18 will be enabled in\n8.19 as well.\n\n<img width=\"1481\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/926c1f2f-4b83-44bb-ba99-a45b2428697a\"\n/>","sha":"129b1502ec9a0e31b422bba380c2f19f5a7f37ff","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:ML/AIOps","backport:version","v9.1.0","v8.19.0"],"title":"[ML] Change Point Detection: Fixes 'Use full data' button issue which could cause page to crash","number":217291,"url":"https://github.com/elastic/kibana/pull/217291","mergeCommit":{"message":"[ML] Change Point Detection: Fixes 'Use full data' button issue which could cause page to crash (#217291)\n\nFixes an issue on pages which have a 'Use full data' button, such as the\nChange Point Detection page inside ML AIOps Labs and the Transforms\nwizard, where an error where with caching inside the\n`FieldStatsFlyoutProvider` could cause the page to break.\n\nSteps to reproduce:\n1. Go to Change Point Detection in ML.\n2. Click \"Use full data\".\n3. Change the date in the time picker to a range different from the full\ndata time range (e.g., last 15 minutes) and apply.\n4. Click \"Use full data\" again.\n\nIt occurs only in `React` > 18\nBackporting to 8.19, as it is possible that React 18 will be enabled in\n8.19 as well.\n\n<img width=\"1481\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/926c1f2f-4b83-44bb-ba99-a45b2428697a\"\n/>","sha":"129b1502ec9a0e31b422bba380c2f19f5a7f37ff"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217291","number":217291,"mergeCommit":{"message":"[ML] Change Point Detection: Fixes 'Use full data' button issue which could cause page to crash (#217291)\n\nFixes an issue on pages which have a 'Use full data' button, such as the\nChange Point Detection page inside ML AIOps Labs and the Transforms\nwizard, where an error where with caching inside the\n`FieldStatsFlyoutProvider` could cause the page to break.\n\nSteps to reproduce:\n1. Go to Change Point Detection in ML.\n2. Click \"Use full data\".\n3. Change the date in the time picker to a range different from the full\ndata time range (e.g., last 15 minutes) and apply.\n4. Click \"Use full data\" again.\n\nIt occurs only in `React` > 18\nBackporting to 8.19, as it is possible that React 18 will be enabled in\n8.19 as well.\n\n<img width=\"1481\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/926c1f2f-4b83-44bb-ba99-a45b2428697a\"\n/>","sha":"129b1502ec9a0e31b422bba380c2f19f5a7f37ff"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
baileycash-elastic
pushed a commit
to baileycash-elastic/kibana
that referenced
this pull request
Apr 7, 2025
… could cause page to crash (elastic#217291) Fixes an issue on pages which have a 'Use full data' button, such as the Change Point Detection page inside ML AIOps Labs and the Transforms wizard, where an error where with caching inside the `FieldStatsFlyoutProvider` could cause the page to break. Steps to reproduce: 1. Go to Change Point Detection in ML. 2. Click "Use full data". 3. Change the date in the time picker to a range different from the full data time range (e.g., last 15 minutes) and apply. 4. Click "Use full data" again. It occurs only in `React` > 18 Backporting to 8.19, as it is possible that React 18 will be enabled in 8.19 as well. <img width="1481" alt="image" src="https://github.com/user-attachments/assets/926c1f2f-4b83-44bb-ba99-a45b2428697a" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue on pages which have a 'Use full data' button, such as the Change Point Detection page inside ML AIOps Labs and the Transforms wizard, where an error where with caching inside the
FieldStatsFlyoutProvidercould cause the page to break.Steps to reproduce:
It occurs only in
React> 18Backporting to 8.19, as it is possible that React 18 will be enabled in 8.19 as well.