[TableListView] Remove listing limit warning#217945
Merged
Dosant merged 2 commits intoelastic:mainfrom Apr 15, 2025
Merged
Conversation
Dosant
added
release_note:skip
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
nreese
approved these changes
Apr 11, 2025
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM
code review only
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
|
dej611
approved these changes
Apr 15, 2025
eokoneyo
approved these changes
Apr 15, 2025
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Dosant
added
release_note:fix
and removed
release_note:skip
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Apr 15, 2025
## Summary Temporary solution for elastic#207135 (comment)  > [!NOTE] > All items are still findable by query or tags Per Graham, > I would love to not need to display a warning but even with today's implementation I would remove it as its benefits don't outweigh its drawbacks IMO We also plan to work on server-side pagination soon (cherry picked from commit 23fe329) # Conflicts: # src/platform/packages/shared/content-management/table_list_view_table/src/services.tsx
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Dosant
added a commit
that referenced
this pull request
Apr 15, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[TableListView] Remove listing limit warning (#217945)](#217945) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Anton Dosov","email":"anton.dosov@elastic.co"},"sourceCommit":{"committedDate":"2025-04-15T11:42:23Z","message":"[TableListView] Remove listing limit warning (#217945)\n\n## Summary\n\nTemporary solution for\nhttps://github.com//issues/207135#issuecomment-2789752279\n\n\n\n\n> [!NOTE] \n> All items are still findable by query or tags \n\nPer Graham, \n\n> I would love to not need to display a warning but even with today's\nimplementation I would remove it as its benefits don't outweigh its\ndrawbacks IMO\n\nWe also plan to work on server-side pagination soon","sha":"23fe329228a7b9cbcf362b8ea58d1c88d7460fb7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","Component:TableListView","backport:version","v9.1.0","v8.19.0"],"title":"[TableListView] Remove listing limit warning","number":217945,"url":"https://github.com/elastic/kibana/pull/217945","mergeCommit":{"message":"[TableListView] Remove listing limit warning (#217945)\n\n## Summary\n\nTemporary solution for\nhttps://github.com//issues/207135#issuecomment-2789752279\n\n\n\n\n> [!NOTE] \n> All items are still findable by query or tags \n\nPer Graham, \n\n> I would love to not need to display a warning but even with today's\nimplementation I would remove it as its benefits don't outweigh its\ndrawbacks IMO\n\nWe also plan to work on server-side pagination soon","sha":"23fe329228a7b9cbcf362b8ea58d1c88d7460fb7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217945","number":217945,"mergeCommit":{"message":"[TableListView] Remove listing limit warning (#217945)\n\n## Summary\n\nTemporary solution for\nhttps://github.com//issues/207135#issuecomment-2789752279\n\n\n\n\n> [!NOTE] \n> All items are still findable by query or tags \n\nPer Graham, \n\n> I would love to not need to display a warning but even with today's\nimplementation I would remove it as its benefits don't outweigh its\ndrawbacks IMO\n\nWe also plan to work on server-side pagination soon","sha":"23fe329228a7b9cbcf362b8ea58d1c88d7460fb7"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporary solution for #207135 (comment)
Note
All items are still findable by query or tags
Per Graham,
We also plan to work on server-side pagination soon