[Fleet] save and read custom asset errors by juliaElastic · Pull Request #218816 · elastic/kibana

juliaElastic · 2025-04-22T13:05:59Z

Summary

Improvements to sync integrations status API and error reporting

Saving custom asset update errors to the package SO in latest_custom_asset_install_failed_attempts field
Reading these errors in the status API and UI
Fix sync status calculation: show FAILED if one of integrations or custom assets are in failed state, SYNCHRONIZING if one of integrations or custom assets are in synchronizing state, otherwise show COMPLETED state.

Reading the followStats API to report on fatal errors, found that the followInfo API doesn't report if the connection to the remote cluster fails. Reproduced this by updating an active Remote Cluster with an invalid port. The followInfo API still reports active status.

GET fleet-synced-integrations-ccr-main/_ccr/stats

{
  "indices": [
    {
      "index": "fleet-synced-integrations-ccr-main",
      "shards": [
        {
          "remote_cluster": "main",
          "leader_index": "fleet-synced-integrations",
          "follower_index": "fleet-synced-integrations-ccr-main",
          ...
          "fatal_exception": {
            "type": "exception",
            "reason": "java.lang.IllegalArgumentException: port out of range:93001",
            "caused_by": {
              "type": "illegal_argument_exception",
              "reason": "port out of range:93001"
            }
          }
        }
      ]
    }
  ]
}

Checklist

Unit or functional tests were updated or added to match the most common scenarios

juliaElastic · 2025-04-22T13:08:19Z

x-pack/platform/plugins/shared/fleet/server/tasks/sync_integrations/get_remote_status.ts

  } catch (error) {
    if (error.isBoom && error.output.statusCode === 404) {
      throw new FleetNotFoundError(`No output found with id ${outputId}`);
+    } else if (error.type === 'system' && error.code === 'ECONNREFUSED') {


error scenario when the remote kibana is down

…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/dashboards --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/alerting/maintenance_window --update'

elasticmachine · 2025-04-23T12:09:25Z

Pinging @elastic/fleet (Team:Fleet)

nchaulet · 2025-04-23T12:45:55Z

x-pack/platform/plugins/shared/fleet/server/types/models/agent_policy.ts

      }),
    })
  ),
+  service_token: schema.maybe(


was this not needed before?

I had an error locally, it's probably a bug that we introduced with the ssl changes here.
I'm going to change it to allow unknowns, to allow any other secrets.

juliaElastic · 2025-04-23T12:46:46Z

.../public/applications/fleet/sections/settings/components/outputs_table/integration_status.tsx

+                      <EuiBadge color="hollow">
+                        <FormattedMessage
+                          id="xpack.fleet.integrationSyncStatus.deletedText"
+                          defaultMessage="Deleted"


Showing deleted assets with a badge

nchaulet

code LGTM 🚀

…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/dashboards --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/alerting/maintenance_window --update'

elasticmachine · 2025-04-23T15:16:12Z

💚 Build Succeeded

Buildkite Build
Commit: 9da23c4

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	1406	1407	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	1.7MB	1.7MB	+564.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`fleet`	90	91	+1

Unknown metric groups

API count

id	before	after	diff
`fleet`	1535	1536	+1

History

💚 Build #295244 succeeded cf4a0fe
💔 Build #294966 failed 1453e57
💔 Build #294919 failed 39eb994

cc @juliaElastic

## Summary Closes elastic#217154 Improvements to sync integrations status API and error reporting - Saving custom asset update errors to the package SO in `latest_custom_asset_install_failed_attempts` field - Reading these errors in the status API and UI - Fix sync status calculation: show `FAILED` if one of integrations or custom assets are in failed state, `SYNCHRONIZING` if one of integrations or custom assets are in synchronizing state, otherwise show `COMPLETED` state. <img width="608" alt="image" src="https://github.com/user-attachments/assets/15a17690-443b-4ca1-b705-cc92ec7d3b20" /> - Reading the `followStats` API to report on fatal errors, found that the `followInfo` API doesn't report if the connection to the remote cluster fails. Reproduced this by updating an active Remote Cluster with an invalid port. The `followInfo` API still reports `active` status. <img width="612" alt="image" src="https://github.com/user-attachments/assets/e95ebc62-4ed9-42c2-9954-93d9438b6ece" /> ``` GET fleet-synced-integrations-ccr-main/_ccr/stats { "indices": [ { "index": "fleet-synced-integrations-ccr-main", "shards": [ { "remote_cluster": "main", "leader_index": "fleet-synced-integrations", "follower_index": "fleet-synced-integrations-ccr-main", ... "fatal_exception": { "type": "exception", "reason": "java.lang.IllegalArgumentException: port out of range:93001", "caused_by": { "type": "illegal_argument_exception", "reason": "port out of range:93001" } } } ] } ] } ``` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

save and read custom asset errors

c5a5ca3

juliaElastic added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Apr 22, 2025

juliaElastic self-assigned this Apr 22, 2025

juliaElastic commented Apr 22, 2025

View reviewed changes

kibanamachine and others added 4 commits April 22, 2025 13:21

[CI] Auto-commit changed files from 'make api-docs'

1453e57

Merge branch 'main' into custom-asset-error

e6ac2ed

store custom asset errors in a map

cf4a0fe

juliaElastic marked this pull request as ready for review April 23, 2025 12:00

juliaElastic requested a review from a team as a code owner April 23, 2025 12:00

extract common logic

a55d644

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 23, 2025

show deleted assets with a badge

1f7dbc7

nchaulet reviewed Apr 23, 2025

View reviewed changes

juliaElastic commented Apr 23, 2025

View reviewed changes

nchaulet approved these changes Apr 23, 2025

View reviewed changes

juliaElastic and others added 3 commits April 23, 2025 14:56

allow unknowns in BaseSecretsSchema

2d6ca9d

[CI] Auto-commit changed files from 'make api-docs'

9da23c4

juliaElastic merged commit 0ed82c4 into elastic:main Apr 24, 2025
9 checks passed

kibanamachine added the v9.1.0 label Apr 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] save and read custom asset errors#218816

[Fleet] save and read custom asset errors#218816
juliaElastic merged 10 commits intoelastic:mainfrom
juliaElastic:custom-asset-error

juliaElastic commented Apr 22, 2025 •

edited

Loading

juliaElastic Apr 22, 2025

elasticmachine commented Apr 23, 2025

nchaulet Apr 23, 2025

juliaElastic Apr 23, 2025 •

edited

Loading

juliaElastic Apr 23, 2025

nchaulet left a comment

elasticmachine commented Apr 23, 2025

API count

Uh oh!

Labels

4 participants

Conversation

juliaElastic commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

juliaElastic Apr 22, 2025

Choose a reason for hiding this comment

elasticmachine commented Apr 23, 2025

nchaulet Apr 23, 2025

Choose a reason for hiding this comment

juliaElastic Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

juliaElastic Apr 23, 2025

Choose a reason for hiding this comment

nchaulet left a comment

Choose a reason for hiding this comment

elasticmachine commented Apr 23, 2025

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Public APIs missing exports

API count

History

Uh oh!

Labels

4 participants

juliaElastic commented Apr 22, 2025 •

edited

Loading

juliaElastic Apr 23, 2025 •

edited

Loading