[ML] AIOps: Enhances `No Results` state for Change Point Detection by rbrtj · Pull Request #219072 · elastic/kibana

rbrtj · 2025-04-24T11:47:04Z

This PR introduces new 'empty' states for Change Point Detection page and embeddable.
Previously, if no change point was found, we displayed an Empty State screen. Now, we plot a sample metric instead. For partitioned fields, we select the first partition value and plot a metric for it. If there is no data to plot for the selected time range, this PR introduces a new empty state screen.

Note: Warnings in the embeddable will be displayed in the bottom-left corner, similar to how Lens embeddable warnings are shown. Currently, we are waiting for the ability to push custom errors to the lens embeddable - see #220208

Embeddable (charts): No change point found, with a reason

Embeddable (charts): No change point found, without a reason

Embeddable (table): No change point found, with a reason

Embeddable (table): No change point found, without a reason

Change Point Page: No change point found, with a reason

Change Point Page: No change point found, without a reason

Fixes #170388

…enhance-no-results-state

elasticmachine · 2025-05-20T13:30:11Z

Pinging @elastic/ml-ui (:ml)

peteharverson

Overall this is working well. I like the callout in the ML page - can you see how it looks when used in the embeddable as I think it's a clearer UX than the warning icon? It will take up more space, but as we are only showing one series in this case, there is probably enough room.

peteharverson

Tested latest changes and LGTM

darnautov · 2025-05-27T15:25:27Z

+            return [
+              {
+                ...firstRawChangePoint.current,
+                kind: 'noChangePoints',
+                label: 'No change points found',
+                p_value: null,
+                timestamp: null,
+              },
+            ];


Can we simply return an empty array here instead? And get rid of the additional type with kind: 'noChangePoints ?
It should simplify the code quite a bit.

Simplified a bit in 124ad16

darnautov · 2025-05-27T15:27:53Z


-  const [results, setResults] = useState<ChangePointAnnotation[]>([]);
+  const [validChangePoints, setValidChangePoints] = useState<ChangePointAnnotation[]>([]);
+  const firstRawChangePoint = useRef<ChangePointAnnotation | null>(null);


Might be worth adding a comment to explain why this is needed. Also, should we rename it to something more semantic, like sampleChangePointResponse?

Done in 124ad16 and fe50c0c

…ponse

darnautov · 2025-05-30T12:56:48Z

+    results,
    isLoading: annotationsLoading,
    progress,
+    sampleChangePointResponse,


I don't think you need to return it from useChangePointResults and pass around

Removed in 46b2fdc

…nt_agg_request hook

darnautov

LGTM overall, great enhancement! 🚀 Please update the functional tests using the UTC timezone.

darnautov · 2025-06-02T09:45:38Z

+      await PageObjects.timePicker.setAbsoluteRange(
+        'Jun 12, 2023 @ 00:04:19.000',
+        'Jun 12, 2023 @ 01:00:19.000'
+      );


⚠️ There are potential issues with using absolute times in functional tests—time in CI can differ from your local environment. Consider setting the timezone in the before hook.

await kibanaServer.uiSettings.update({ 'dateFormat:tz': 'UTC', });

All of the mentioned tests use await ml.testResources.setKibanaTimeZoneToUTC(); in the before hook, which is responsible for setting timezone to UTC

szabosteve

Left a small suggestion, otherwise LGTM.
cc @nastasha-solomon

szabosteve · 2025-06-02T11:56:34Z

-            id="xpack.aiops.changePointDetection.noChangePointsFoundMessage"
-            defaultMessage="Detect statistically significant change points such as dips, spikes, and distribution changes in a metric. Select a metric and set a time range to start detecting change points in your data."
+            id="xpack.aiops.changePointDetection.noDataFoundMessage"
+            defaultMessage="No data was found for the selected metric and time range. Please adjust your selection to include data from your indices."


Suggested change

defaultMessage="No data was found for the selected metric and time range. Please adjust your selection to include data from your indices."

defaultMessage="No data found for the selected metric and time range. Try adjusting your selection to include data from your indices."

Updated - 2e7a9ff
Thanks!

elasticmachine · 2025-06-02T15:08:04Z

💚 Build Succeeded

Buildkite Build
Commit: 2e7a9ff

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`aiops`	608	609	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiops`	505.1KB	506.3KB	+1.2KB

History

💛 Build #304080 was flaky c3a1736
💚 Build #303981 succeeded 4d04d5c
💚 Build #303286 succeeded e2b38f1
💛 Build #302545 was flaky 3c0ee8b
💛 Build #302260 was flaky 4d4acce
💚 Build #301732 succeeded f6915bc

cc @rbrtj

kibanamachine · 2025-06-02T15:10:04Z

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15395864297

…astic#219072) This PR introduces new 'empty' states for Change Point Detection page and embeddable. Previously, if no change point was found, we displayed an Empty State screen. Now, we plot a sample metric instead. For partitioned fields, we select the first partition value and plot a metric for it. If there is no data to plot for the selected time range, this PR introduces a new empty state screen. Note: Warnings in the embeddable will be displayed in the bottom-left corner, similar to how Lens embeddable warnings are shown. Currently, we are waiting for the ability to push custom errors to the lens embeddable - see elastic#220208 * Embeddable (charts): No change point found, with a reason <img width="966" alt="image" src="https://github.com/user-attachments/assets/88d4f920-6739-4af7-9903-1fb210dfa089" /> * Embeddable (charts): No change point found, without a reason <img width="991" alt="image" src="https://github.com/user-attachments/assets/6bef28e0-19f3-46f5-af63-e31b4e77d575" /> * Embeddable (table): No change point found, with a reason <img width="883" alt="image" src="https://github.com/user-attachments/assets/628ba7fb-000c-45c3-9f23-2fd0535e5106" /> * Embeddable (table): No change point found, without a reason <img width="983" alt="image" src="https://github.com/user-attachments/assets/567c6127-267f-47a0-b280-52fb00c6c749" /> * Change Point Page: No change point found, with a reason <img width="1217" alt="image" src="https://github.com/user-attachments/assets/ab2fbeef-e4f6-4fa9-8cbe-c44abe0357b4" /> * Change Point Page: No change point found, without a reason <img width="1225" alt="image" src="https://github.com/user-attachments/assets/c16dd55a-37eb-45c2-a3eb-51ea9744e0d7" /> Fixes elastic#170388 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 1e7d418)

kibanamachine · 2025-06-02T15:16:42Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ion (#219072) (#222228) # Backport This will backport the following commits from `main` to `8.19`: - [[ML] AIOps: Enhance `No Results` state for Change Point Detection (#219072)](#219072)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>

…astic#219072) This PR introduces new 'empty' states for Change Point Detection page and embeddable. Previously, if no change point was found, we displayed an Empty State screen. Now, we plot a sample metric instead. For partitioned fields, we select the first partition value and plot a metric for it. If there is no data to plot for the selected time range, this PR introduces a new empty state screen. Note: Warnings in the embeddable will be displayed in the bottom-left corner, similar to how Lens embeddable warnings are shown. Currently, we are waiting for the ability to push custom errors to the lens embeddable - see elastic#220208 * Embeddable (charts): No change point found, with a reason <img width="966" alt="image" src="https://github.com/user-attachments/assets/88d4f920-6739-4af7-9903-1fb210dfa089" /> * Embeddable (charts): No change point found, without a reason <img width="991" alt="image" src="https://github.com/user-attachments/assets/6bef28e0-19f3-46f5-af63-e31b4e77d575" /> * Embeddable (table): No change point found, with a reason <img width="883" alt="image" src="https://github.com/user-attachments/assets/628ba7fb-000c-45c3-9f23-2fd0535e5106" /> * Embeddable (table): No change point found, without a reason <img width="983" alt="image" src="https://github.com/user-attachments/assets/567c6127-267f-47a0-b280-52fb00c6c749" /> * Change Point Page: No change point found, with a reason <img width="1217" alt="image" src="https://github.com/user-attachments/assets/ab2fbeef-e4f6-4fa9-8cbe-c44abe0357b4" /> * Change Point Page: No change point found, without a reason <img width="1225" alt="image" src="https://github.com/user-attachments/assets/c16dd55a-37eb-45c2-a3eb-51ea9744e0d7" /> Fixes elastic#170388 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

render sample metrics

8b32a1a

rbrtj changed the title ~~render sample metrics~~ Apr 24, 2025

rbrtj changed the title ~~[ML] AiOps: Enhance No Results state~~ Apr 24, 2025

rbrtj and others added 8 commits May 8, 2025 10:54

Merge remote-tracking branch 'upstream/main' into aiops-change-point-…

869980a

…enhance-no-results-state

simplify use_change_point_agg_request && adjust variable name

ce55fa0

update charts embeddable no change point warning

ca84073

do not prematurely stop fetching of change points

bbbc455

Use reason for warning messages if possible

5b0f3d0

Merge branch 'main' into aiops-change-point-enhance-no-results-state

5558ac3

Display a warning for change point table embeddable

90b14b0

add functional tests

523139c

peteharverson mentioned this pull request May 1, 2025

[ML] Increase Test Coverage 9.1.0 #209513

Closed

15 tasks

rbrtj marked this pull request as ready for review May 20, 2025 13:29

rbrtj requested a review from a team as a code owner May 20, 2025 13:29

rbrtj self-assigned this May 20, 2025

rbrtj added release_note:enhancement :ml Team:ML Team label for ML (also use :ml) t// Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis backport:version Backport to applied version labels v9.1.0 v8.19.0 labels May 20, 2025

rbrtj requested a review from peteharverson May 20, 2025 13:30

rbrtj added 2 commits May 20, 2025 15:48

Merge branch 'main' into aiops-change-point-enhance-no-results-state

b74dde5

Merge branch 'main' into aiops-change-point-enhance-no-results-state

408099b

peteharverson changed the title ~~[ML] AiOps: Enhance No Results state for Change Point Detection~~ May 21, 2025

peteharverson reviewed May 21, 2025

View reviewed changes

rbrtj added 2 commits May 21, 2025 18:30

use callout for warnings in embeddables

44f6327

remove unused variable

213d64a

rbrtj requested review from darnautov and peteharverson May 27, 2025 07:06

peteharverson approved these changes May 27, 2025

View reviewed changes

darnautov reviewed May 27, 2025

View reviewed changes

rbrtj and others added 5 commits May 29, 2025 10:28

simplify change point results logic

124ad16

remove unused property && add comment explaining sampleChangePointRes…

fe50c0c

…ponse

Merge branch 'main' into aiops-change-point-enhance-no-results-state

20bf2de

remove empty line

c4e7365

revert validChangePoints to results variable name

e2b38f1

rbrtj requested a review from darnautov May 29, 2025 08:35

darnautov reviewed May 30, 2025

View reviewed changes

rbrtj and others added 4 commits June 2, 2025 09:55

Merge branch 'main' into aiops-change-point-enhance-no-results-state

ec39420

get rid of useAnnotations hook && consolidate logic in use_change_poi…

46b2fdc

…nt_agg_request hook

use FormattedMessage

7f9b09a

check for undefined p_value

4d04d5c

rbrtj requested a review from darnautov June 2, 2025 08:32

darnautov approved these changes Jun 2, 2025

View reviewed changes

remove unnecessary useMemo

c3a1736

szabosteve approved these changes Jun 2, 2025

View reviewed changes

update no data found warning text

2e7a9ff

rbrtj merged commit 1e7d418 into elastic:main Jun 2, 2025
10 checks passed

kibanamachine mentioned this pull request Jun 2, 2025

[8.19] [ML] AIOps: Enhance No Results state for Change Point Detection (#219072) #222228

Merged

nastasha-solomon changed the title ~~[ML] AIOps: Enhance No Results state for Change Point Detection~~ Jun 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] AIOps: Enhances `No Results` state for Change Point Detection#219072

[ML] AIOps: Enhances `No Results` state for Change Point Detection#219072
rbrtj merged 33 commits intoelastic:mainfrom
rbrtj:aiops-change-point-enhance-no-results-state

rbrtj commented Apr 24, 2025 •

edited by kibanamachine

Loading

elasticmachine commented May 20, 2025

peteharverson left a comment

peteharverson left a comment

darnautov May 27, 2025

rbrtj May 29, 2025

darnautov May 27, 2025

rbrtj May 29, 2025

Uh oh!

Uh oh!

Uh oh!

darnautov May 30, 2025

rbrtj Jun 2, 2025

Uh oh!

Uh oh!

darnautov left a comment

Uh oh!

darnautov Jun 2, 2025

rbrtj Jun 2, 2025

Uh oh!

Uh oh!

szabosteve left a comment

szabosteve Jun 2, 2025

rbrtj Jun 2, 2025

elasticmachine commented Jun 2, 2025

Uh oh!

kibanamachine commented Jun 2, 2025

kibanamachine commented Jun 2, 2025

Labels

6 participants

	defaultMessage="No data was found for the selected metric and time range. Please adjust your selection to include data from your indices."
	defaultMessage="No data found for the selected metric and time range. Try adjusting your selection to include data from your indices."

Conversation

rbrtj commented Apr 24, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

elasticmachine commented May 20, 2025

peteharverson left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

darnautov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

szabosteve left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Jun 2, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

kibanamachine commented Jun 2, 2025

kibanamachine commented Jun 2, 2025

💚 All backports created successfully

Questions ?

Labels

6 participants

rbrtj commented Apr 24, 2025 •

edited by kibanamachine

Loading