Skip to content

[ES|QL] Adds an ES|QL control option on the dashboard controls dropdown#219495

Merged
stratoula merged 8 commits intoelastic:mainfrom
stratoula:dashboard-esql-controls-in-dashboard
May 7, 2025
Merged

[ES|QL] Adds an ES|QL control option on the dashboard controls dropdown#219495
stratoula merged 8 commits intoelastic:mainfrom
stratoula:dashboard-esql-controls-in-dashboard

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented Apr 29, 2025 •
edited by kibanamachine
Loading

Summary

Closes #213154
Closes #209826

Allows the creation of the ES|QL control from the dashboard dropdown

meow

Checklist
@prodsecmachine
Copy link
Copy Markdown
Collaborator

prodsecmachine commented May 1, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 1, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8232

[✅] src/platform/test/functional/apps/dashboard/esql_controls/config.ts: 25/25 tests passed.

see run history
@stratoula stratoula added v8.19.0 v9.1.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// release_note:enhancement backport:version Backport to applied version labels labels May 1, 2025
@stratoula stratoula marked this pull request as ready for review May 1, 2025 11:06
@stratoula stratoula requested review from a team as code owners May 1, 2025 11:06
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 1, 2025

Pinging @elastic/kibana-esql (Team:ESQL)
@ghudgins ghudgins mentioned this pull request May 1, 2025
Closed
@drewdaemon
Copy link
Copy Markdown
Contributor

drewdaemon commented May 5, 2025

@elasticmachine merge upstream
drewdaemon
drewdaemon approved these changes May 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense!
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 6, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #108 / Security Solution - Telemetry Security Telemetry - Ingest pipeline stats task. @ess @serverless indices metadata should publish events for a new pipeline

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 641 642 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 548.8KB 550.0KB +1.2KB
esql 240.7KB 246.0KB +5.3KB
total +6.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esql 7.9KB 7.9KB -23.0B
Unknown metric groups

async chunk count

id before after diff
esql 7 6 -1

ESLint disabled line counts

id before after diff
dashboard 11 12 +1

Total ESLint disabled count

id before after diff
dashboard 11 12 +1

History

cc @stratoula
ThomThomson
ThomThomson approved these changes May 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Looked through the code, and tested the functionality locally.
Comment thread src/platform/test/functional/apps/dashboard/esql_controls/create_from_dropdown.ts

import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ getService, getPageObjects }: FtrProviderContext) {
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have more functional tests here. FTR results LGTM. 25 runs might not be enough to capture any flakiness, but I'm okay to merge this - especially since you've been good at fixing up these tests if they become flaky.
Copy link
Copy Markdown
Contributor Author

@stratoula stratoula May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is flaky I will def look at it Devon, thanx for your review 🙇‍♀️
@stratoula stratoula merged commit 6accad8 into elastic:main May 7, 2025
9 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 7, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/14875937909
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 7, 2025
@stratoula @elasticmachine
[ES|QL] Adds an ES|QL control option on the dashboard controls dropdo…
b24eaac 
…wn (elastic#219495)

## Summary

Closes elastic#213154
Closes elastic#209826

Allows the creation of the ES|QL control from the dashboard dropdown

![meow](https://github.com/user-attachments/assets/8b48adf5-d01a-497a-8062-1271eb213660)

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 6accad8)
@kibanamachine kibanamachine mentioned this pull request May 7, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 7, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation
@stratoula stratoula mentioned this pull request May 7, 2025
Merged
stratoula added a commit that referenced this pull request May 7, 2025
@stratoula
[ES|QL] Fixes types failure in adding a control after a conflict merge (
b6df628 
#220325)

## Summary

Fixes main after merge of #219495.
Apparently the api changed in another PR and I didnt know.
kibanamachine added a commit that referenced this pull request May 7, 2025
@kibanamachine @stratoula @elasticmachine
[8.19] [ES|QL] Adds an ES|QL control option on the dashboard controls…
547b11c 
… dropdown (#219495) (#220324)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[ES|QL] Adds an ES|QL control option on the dashboard controls
dropdown (#219495)](#219495)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-05-07T05:35:13Z","message":"[ES|QL]
Adds an ES|QL control option on the dashboard controls dropdown
(#219495)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/213154\nCloses
https://github.com/elastic/kibana/issues/209826\n\nAllows the creation
of the ES|QL control from the dashboard
dropdown\n\n\n![meow](https://github.com/user-attachments/assets/8b48adf5-d01a-497a-8062-1271eb213660)\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"6accad891d311847eeed518d2c2075c10afee1ad","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL]
Adds an ES|QL control option on the dashboard controls
dropdown","number":219495,"url":"https://github.com/elastic/kibana/pull/219495","mergeCommit":{"message":"[ES|QL]
Adds an ES|QL control option on the dashboard controls dropdown
(#219495)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/213154\nCloses
https://github.com/elastic/kibana/issues/209826\n\nAllows the creation
of the ES|QL control from the dashboard
dropdown\n\n\n![meow](https://github.com/user-attachments/assets/8b48adf5-d01a-497a-8062-1271eb213660)\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"6accad891d311847eeed518d2c2075c10afee1ad"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219495","number":219495,"mergeCommit":{"message":"[ES|QL]
Adds an ES|QL control option on the dashboard controls dropdown
(#219495)\n\n## Summary\n\nCloses
https://github.com/elastic/kibana/issues/213154\nCloses
https://github.com/elastic/kibana/issues/209826\n\nAllows the creation
of the ES|QL control from the dashboard
dropdown\n\n\n![meow](https://github.com/user-attachments/assets/8b48adf5-d01a-497a-8062-1271eb213660)\n\n###
Checklist\n\n- [ ] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"6accad891d311847eeed518d2c2075c10afee1ad"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@stratoula @elasticmachine @akowalska622
[ES|QL] Adds an ES|QL control option on the dashboard controls dropdo…
c66b755 
…wn (elastic#219495)

## Summary

Closes elastic#213154
Closes elastic#209826

Allows the creation of the ES|QL control from the dashboard dropdown


![meow](https://github.com/user-attachments/assets/8b48adf5-d01a-497a-8062-1271eb213660)

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@stratoula @akowalska622
[ES|QL] Fixes types failure in adding a control after a conflict merge (
e21443e 
elastic#220325)

## Summary

Fixes main after merge of elastic#219495.
Apparently the api changed in another PR and I didnt know.
qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
@stratoula @elasticmachine @qn895
[ES|QL] Adds an ES|QL control option on the dashboard controls dropdo…
42f9380 
…wn (elastic#219495)

## Summary

Closes elastic#213154
Closes elastic#209826

Allows the creation of the ES|QL control from the dashboard dropdown


![meow](https://github.com/user-attachments/assets/8b48adf5-d01a-497a-8062-1271eb213660)

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
qn895 pushed a commit to qn895/kibana that referenced this pull request Jun 3, 2025
@stratoula @qn895
[ES|QL] Fixes types failure in adding a control after a conflict merge (
4d68518 
elastic#220325)

## Summary

Fixes main after merge of elastic#219495.
Apparently the api changed in another PR and I didnt know.
@florent-leborgne florent-leborgne mentioned this pull request Jun 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:enhancement Team:ESQL ES|QL related features in Kibana t// v8.19.0 v9.1.0

7 participants

@stratoula @prodsecmachine @kibanamachine @elasticmachine @drewdaemon @ThomThomson @ghudgins