Skip to content

Use new client URLs in doc link service#219600

Merged
lcawl merged 5 commits intoelastic:mainfrom
lcawl:client-links
May 1, 2025
Merged

Use new client URLs in doc link service#219600
lcawl merged 5 commits intoelastic:mainfrom
lcawl:client-links

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 29, 2025 •
edited by kibanamachine
Loading

Summary

Relates to #217722

This PR updates the clients and serverlessClients links in the Kibana doc link service.
Since there's a comment that says "changes to these URLs must also be synched in src/platform/plugins/shared/custom_integrations/server/language_clients/index.ts", I've made some changes there too.

NOTE:

  • I have left the javaBasicAuthentication and javaRestLow entries hard-coded for 8.18 since there seems to be no equivalent in the v9+ docs
  • I have changed netNest to a 7.17 URL, since it doesn't exist in the v8+ docs
  • I have changed the Perl client URLs in language_integrations.ts to use current rather than "branch" since that documentation indicates it's deprecated and it doesn't exist in the new docs
  • I removed the main/master conditional branch handling from language_clients/index.ts since we don't have branch-based URLs in the new docs

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.
@lcawl lcawl added Team:Docs release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v9.0.1 labels Apr 29, 2025
@lcawl lcawl mentioned this pull request Apr 29, 2025
Closed
12 tasks
@lcawl lcawl marked this pull request as ready for review April 29, 2025 16:11
@lcawl lcawl requested review from a team as code owners April 29, 2025 16:11
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 29, 2025

Pinging @elastic/kibana-docs (Team:Docs)
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 29, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 67.4KB 67.0KB -435.0B
lists 114.1KB 113.7KB -435.0B
total -870.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 439.3KB 438.9KB -435.0B

History
juliaElastic
juliaElastic approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@lcawl lcawl enabled auto-merge (squash) May 1, 2025 14:46
kilfoyle
kilfoyle approved these changes May 1, 2025
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌴
@lcawl lcawl merged commit 930642a into elastic:main May 1, 2025
9 checks passed
@lcawl lcawl deleted the client-links branch May 1, 2025 14:47
@kibanamachine
Copy link
Contributor

kibanamachine commented May 1, 2025

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/14777414355
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 1, 2025
@lcawl
Use new client URLs in doc link service (elastic#219600)
6b4753a 
(cherry picked from commit 930642a)
@kibanamachine kibanamachine mentioned this pull request May 1, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented May 1, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation
kibanamachine added a commit that referenced this pull request May 1, 2025
@kibanamachine @lcawl
[9.0] Use new client URLs in doc link service (#219600) (#219855)
223f2a6 
# Backport

This will backport the following commits from `main` to `9.0`:
- [Use new client URLs in doc link service
(#219600)](#219600)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2025-05-01T14:46:58Z","message":"Use
new client URLs in doc link service
(#219600)","sha":"930642a0fbb56336aa74aa35100d95b1a4ecb494","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","backport:version","v9.1.0","v9.0.1"],"title":"Use
new client URLs in doc link
service","number":219600,"url":"https://github.com/elastic/kibana/pull/219600","mergeCommit":{"message":"Use
new client URLs in doc link service
(#219600)","sha":"930642a0fbb56336aa74aa35100d95b1a4ecb494"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219600","number":219600,"mergeCommit":{"message":"Use
new client URLs in doc link service
(#219600)","sha":"930642a0fbb56336aa74aa35100d95b1a4ecb494"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
kapral18 added a commit to kapral18/kibana that referenced this pull request May 4, 2025
@kapral18
Merge branch 'main' into fix/explore/214733-handle-overview-alerts-tr…
d9d8c1d 
…ends-crash

* main: (111 commits)
  [ResponseOps][Rules] Cases action title length too long (elastic#219226)
  [main] Sync bundled packages with Package Storage (elastic#219839)
  Fix ignored dynamic templates (elastic#219875)
  Enforce dependency review by kibana-security workflow (elastic#219262)
  [Security Solution] [Detections] Removes tech preview text from eql seq suppression ui (elastic#219870)
  [Security Solution] Fix alerts table potentially not applying alert assignees (elastic#219460)
  fix(slo): alert deletion (elastic#219876)
  [AI4DSOC] fix styling to address cutoff when screen is narrow (elastic#219306)
  [Security Solution][Endpoint] Response action create and history log API updates in of space awareness (elastic#218674)
  Update publish_oas_docs.sh to deploy Kibana Serverless API docs (elastic#219867)
  feat(slo): lock resource installation (elastic#219747)
  [AI4DSOC] Alert flyout code cleanup (elastic#219810)
  [fleet] fixing `isAgentlessDefault` config usage and readability improvements to `isAgentlessSetupDefault` (elastic#219423)
  feat(slo): Bulk delete UI (elastic#219634)
  m1 demo prep (elastic#219588)
  [Security Solution] Replace sourcerer in EQL tab with dataview picker (elastic#218897)
  [AI4DSOC] Attack discovery widget follow up follow up (elastic#219849)
  [AI Assistant] Fix some OpenAI models not accepting temperature for Inference service (elastic#218887)
  Update dependency msw to ~2.7.5 (main) (elastic#219289)
  Use new client URLs in doc link service (elastic#219600)
  ...
@mistic mistic added v9.0.2 and removed v9.0.1 labels May 6, 2025
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@lcawl @akowalska622
Use new client URLs in doc link service (elastic#219600)
6f46ac3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Docs v9.0.2 v9.1.0

6 participants

@lcawl @elasticmachine @kibanamachine @kilfoyle @juliaElastic @mistic