[ES|QL] Fixes rename wrong validation for asterisc in name#219832
Merged
stratoula merged 4 commits intoelastic:mainfrom May 6, 2025
Merged
[ES|QL] Fixes rename wrong validation for asterisc in name#219832stratoula merged 4 commits intoelastic:mainfrom
stratoula merged 4 commits intoelastic:mainfrom
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
stratoula
added
release_note:fix
backport:version
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
13 tasks
drewdaemon
approved these changes
May 2, 2025
Contributor
drewdaemon
left a comment
drewdaemon
left a comment
There was a problem hiding this comment.
Looks good! (Code review)
Contributor
|
Starting backport for target branches: 8.19 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 6, 2025
…19832) ## Summary Removes the wildcard validation to fix wrong validation like that: <img width="844" alt="image" src="https://github.com/user-attachments/assets/c71ee9a9-539a-40a4-b467-2bedf0111ae5" /> This scenario ``` FROM logst* | RENAME agent* AS meow ``` fails already so we are ok I think ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit f5afb22)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 6, 2025
…19832) (#220194) # Backport This will backport the following commits from `main` to `8.19`: - [[ES|QL] Fixes rename wrong validation for asterisc in name (#219832)](#219832) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2025-05-06T06:48:28Z","message":"[ES|QL] Fixes rename wrong validation for asterisc in name (#219832)\n\n## Summary\n\nRemoves the wildcard validation to fix wrong validation like that:\n\n<img width=\"844\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c71ee9a9-539a-40a4-b467-2bedf0111ae5\"\n/>\n\n\nThis scenario\n\n```\nFROM logst* | RENAME agent* AS meow \n```\n\nfails already so we are ok I think\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"f5afb22941f6008db2f22c1b6fda781e6f9c7e4c","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] Fixes rename wrong validation for asterisc in name","number":219832,"url":"https://github.com/elastic/kibana/pull/219832","mergeCommit":{"message":"[ES|QL] Fixes rename wrong validation for asterisc in name (#219832)\n\n## Summary\n\nRemoves the wildcard validation to fix wrong validation like that:\n\n<img width=\"844\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c71ee9a9-539a-40a4-b467-2bedf0111ae5\"\n/>\n\n\nThis scenario\n\n```\nFROM logst* | RENAME agent* AS meow \n```\n\nfails already so we are ok I think\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"f5afb22941f6008db2f22c1b6fda781e6f9c7e4c"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/219832","number":219832,"mergeCommit":{"message":"[ES|QL] Fixes rename wrong validation for asterisc in name (#219832)\n\n## Summary\n\nRemoves the wildcard validation to fix wrong validation like that:\n\n<img width=\"844\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c71ee9a9-539a-40a4-b467-2bedf0111ae5\"\n/>\n\n\nThis scenario\n\n```\nFROM logst* | RENAME agent* AS meow \n```\n\nfails already so we are ok I think\n\n### Checklist\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"f5afb22941f6008db2f22c1b6fda781e6f9c7e4c"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…19832) ## Summary Removes the wildcard validation to fix wrong validation like that: <img width="844" alt="image" src="https://github.com/user-attachments/assets/c71ee9a9-539a-40a4-b467-2bedf0111ae5" /> This scenario ``` FROM logst* | RENAME agent* AS meow ``` fails already so we are ok I think ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
…19832) ## Summary Removes the wildcard validation to fix wrong validation like that: <img width="844" alt="image" src="https://github.com/user-attachments/assets/c71ee9a9-539a-40a4-b467-2bedf0111ae5" /> This scenario ``` FROM logst* | RENAME agent* AS meow ``` fails already so we are ok I think ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the wildcard validation to fix wrong validation like that:
This scenario
fails already so we are ok I think
Checklist