[Search] Fix Pagination when number of documents is changed#220139
Merged
saarikabhasi merged 1 commit intoelastic:mainfrom May 5, 2025
Merged
[Search] Fix Pagination when number of documents is changed#220139saarikabhasi merged 1 commit intoelastic:mainfrom
saarikabhasi merged 1 commit intoelastic:mainfrom
Conversation
saarikabhasi
added
release_note:skip
TattdCodeMonkey
approved these changes
May 5, 2025
Contributor
|
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
Contributor
saarikabhasi
added a commit
to saarikabhasi/kibana
that referenced
this pull request
May 6, 2025
…220139) ## Summary **Problem** When number of documents is changed, the total number of pages are recalculated but current page is not changed. This works fine, but when on last page and changing to larger number of documents makes the page to show zero documents **Fix** Changed to reset pagination to first page when number of documents is changed. https://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e (cherry picked from commit f1187b4) # Conflicts: # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/documents.tsx
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
saarikabhasi
added a commit
to saarikabhasi/kibana
that referenced
this pull request
May 6, 2025
…220139) ## Summary **Problem** When number of documents is changed, the total number of pages are recalculated but current page is not changed. This works fine, but when on last page and changing to larger number of documents makes the page to show zero documents **Fix** Changed to reset pagination to first page when number of documents is changed. https://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e (cherry picked from commit f1187b4) # Conflicts: # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/documents.tsx
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
saarikabhasi
added a commit
to saarikabhasi/kibana
that referenced
this pull request
May 6, 2025
…220139) **Problem** When number of documents is changed, the total number of pages are recalculated but current page is not changed. This works fine, but when on last page and changing to larger number of documents makes the page to show zero documents **Fix** Changed to reset pagination to first page when number of documents is changed. https://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e (cherry picked from commit f1187b4)
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
saarikabhasi
added a commit
to saarikabhasi/kibana
that referenced
this pull request
May 6, 2025
…220139) **Problem** When number of documents is changed, the total number of pages are recalculated but current page is not changed. This works fine, but when on last page and changing to larger number of documents makes the page to show zero documents **Fix** Changed to reset pagination to first page when number of documents is changed. https://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e (cherry picked from commit f1187b4)
saarikabhasi
added a commit
that referenced
this pull request
May 6, 2025
…220139) (#220271) # Backport This will backport the following commits from `main` to `8.17`: - [[Search] Fix Pagination when number of documents is changed (#220139)](#220139) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Saarika Bhasi","email":"55930906+saarikabhasi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-05T20:48:37Z","message":"[Search] Fix Pagination when number of documents is changed (#220139)\n\n## Summary\n**Problem** \nWhen number of documents is changed, the total number of pages are\nrecalculated but current page is not changed. This works fine, but when\non last page and changing to larger number of documents makes the page\nto show zero documents\n\n**Fix**\nChanged to reset pagination to first page when number of documents is\nchanged.\n\n\nhttps://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e","sha":"f1187b4e9129215e7373b3ba772e306e0af4bdd2","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0","v9.1.0","v8.19.0"],"title":"[Search] Fix Pagination when number of documents is changed","number":220139,"url":"https://github.com/elastic/kibana/pull/220139","mergeCommit":{"message":"[Search] Fix Pagination when number of documents is changed (#220139)\n\n## Summary\n**Problem** \nWhen number of documents is changed, the total number of pages are\nrecalculated but current page is not changed. This works fine, but when\non last page and changing to larger number of documents makes the page\nto show zero documents\n\n**Fix**\nChanged to reset pagination to first page when number of documents is\nchanged.\n\n\nhttps://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e","sha":"f1187b4e9129215e7373b3ba772e306e0af4bdd2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.17","8.18","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220139","number":220139,"mergeCommit":{"message":"[Search] Fix Pagination when number of documents is changed (#220139)\n\n## Summary\n**Problem** \nWhen number of documents is changed, the total number of pages are\nrecalculated but current page is not changed. This works fine, but when\non last page and changing to larger number of documents makes the page\nto show zero documents\n\n**Fix**\nChanged to reset pagination to first page when number of documents is\nchanged.\n\n\nhttps://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e","sha":"f1187b4e9129215e7373b3ba772e306e0af4bdd2"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
saarikabhasi
added a commit
that referenced
this pull request
May 6, 2025
…220139) (#220274) # Backport This will backport the following commits from `main` to `8.18`: - [[Search] Fix Pagination when number of documents is changed (#220139)](#220139) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Saarika Bhasi","email":"55930906+saarikabhasi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-05T20:48:37Z","message":"[Search] Fix Pagination when number of documents is changed (#220139)\n\n## Summary\n**Problem** \nWhen number of documents is changed, the total number of pages are\nrecalculated but current page is not changed. This works fine, but when\non last page and changing to larger number of documents makes the page\nto show zero documents\n\n**Fix**\nChanged to reset pagination to first page when number of documents is\nchanged.\n\n\nhttps://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e","sha":"f1187b4e9129215e7373b3ba772e306e0af4bdd2","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0","v9.1.0","v8.19.0"],"title":"[Search] Fix Pagination when number of documents is changed","number":220139,"url":"https://github.com/elastic/kibana/pull/220139","mergeCommit":{"message":"[Search] Fix Pagination when number of documents is changed (#220139)\n\n## Summary\n**Problem** \nWhen number of documents is changed, the total number of pages are\nrecalculated but current page is not changed. This works fine, but when\non last page and changing to larger number of documents makes the page\nto show zero documents\n\n**Fix**\nChanged to reset pagination to first page when number of documents is\nchanged.\n\n\nhttps://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e","sha":"f1187b4e9129215e7373b3ba772e306e0af4bdd2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/220271","number":220271,"state":"OPEN"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220139","number":220139,"mergeCommit":{"message":"[Search] Fix Pagination when number of documents is changed (#220139)\n\n## Summary\n**Problem** \nWhen number of documents is changed, the total number of pages are\nrecalculated but current page is not changed. This works fine, but when\non last page and changing to larger number of documents makes the page\nto show zero documents\n\n**Fix**\nChanged to reset pagination to first page when number of documents is\nchanged.\n\n\nhttps://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e","sha":"f1187b4e9129215e7373b3ba772e306e0af4bdd2"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
saarikabhasi
added a commit
that referenced
this pull request
May 6, 2025
…220139) (#220282) # Backport This will backport the following commits from `main` to `8.19`: - [[Search] Fix Pagination when number of documents is changed (#220139)](#220139) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Saarika Bhasi","email":"55930906+saarikabhasi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-05T20:48:37Z","message":"[Search] Fix Pagination when number of documents is changed (#220139)\n\n## Summary\n**Problem** \nWhen number of documents is changed, the total number of pages are\nrecalculated but current page is not changed. This works fine, but when\non last page and changing to larger number of documents makes the page\nto show zero documents\n\n**Fix**\nChanged to reset pagination to first page when number of documents is\nchanged.\n\n\nhttps://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e","sha":"f1187b4e9129215e7373b3ba772e306e0af4bdd2","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0","v9.1.0","v8.19.0"],"title":"[Search] Fix Pagination when number of documents is changed","number":220139,"url":"https://github.com/elastic/kibana/pull/220139","mergeCommit":{"message":"[Search] Fix Pagination when number of documents is changed (#220139)\n\n## Summary\n**Problem** \nWhen number of documents is changed, the total number of pages are\nrecalculated but current page is not changed. This works fine, but when\non last page and changing to larger number of documents makes the page\nto show zero documents\n\n**Fix**\nChanged to reset pagination to first page when number of documents is\nchanged.\n\n\nhttps://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e","sha":"f1187b4e9129215e7373b3ba772e306e0af4bdd2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/220271","number":220271,"state":"OPEN"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/220274","number":220274,"state":"OPEN"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220139","number":220139,"mergeCommit":{"message":"[Search] Fix Pagination when number of documents is changed (#220139)\n\n## Summary\n**Problem** \nWhen number of documents is changed, the total number of pages are\nrecalculated but current page is not changed. This works fine, but when\non last page and changing to larger number of documents makes the page\nto show zero documents\n\n**Fix**\nChanged to reset pagination to first page when number of documents is\nchanged.\n\n\nhttps://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e","sha":"f1187b4e9129215e7373b3ba772e306e0af4bdd2"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
saarikabhasi
added a commit
that referenced
this pull request
May 6, 2025
…20139) (#220284) # Backport This will backport the following commits from `main` to `9.0`: - [[Search] Fix Pagination when number of documents is changed (#220139)](#220139) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Saarika Bhasi","email":"55930906+saarikabhasi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-05T20:48:37Z","message":"[Search] Fix Pagination when number of documents is changed (#220139)\n\n## Summary\n**Problem** \nWhen number of documents is changed, the total number of pages are\nrecalculated but current page is not changed. This works fine, but when\non last page and changing to larger number of documents makes the page\nto show zero documents\n\n**Fix**\nChanged to reset pagination to first page when number of documents is\nchanged.\n\n\nhttps://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e","sha":"f1187b4e9129215e7373b3ba772e306e0af4bdd2","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.17.0","v8.18.0","v9.1.0","v8.19.0"],"title":"[Search] Fix Pagination when number of documents is changed","number":220139,"url":"https://github.com/elastic/kibana/pull/220139","mergeCommit":{"message":"[Search] Fix Pagination when number of documents is changed (#220139)\n\n## Summary\n**Problem** \nWhen number of documents is changed, the total number of pages are\nrecalculated but current page is not changed. This works fine, but when\non last page and changing to larger number of documents makes the page\nto show zero documents\n\n**Fix**\nChanged to reset pagination to first page when number of documents is\nchanged.\n\n\nhttps://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e","sha":"f1187b4e9129215e7373b3ba772e306e0af4bdd2"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/220271","number":220271,"state":"OPEN"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/220274","number":220274,"state":"OPEN"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220139","number":220139,"mergeCommit":{"message":"[Search] Fix Pagination when number of documents is changed (#220139)\n\n## Summary\n**Problem** \nWhen number of documents is changed, the total number of pages are\nrecalculated but current page is not changed. This works fine, but when\non last page and changing to larger number of documents makes the page\nto show zero documents\n\n**Fix**\nChanged to reset pagination to first page when number of documents is\nchanged.\n\n\nhttps://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e","sha":"f1187b4e9129215e7373b3ba772e306e0af4bdd2"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/220282","number":220282,"state":"OPEN"}]}] BACKPORT-->
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…220139) ## Summary **Problem** When number of documents is changed, the total number of pages are recalculated but current page is not changed. This works fine, but when on last page and changing to larger number of documents makes the page to show zero documents **Fix** Changed to reset pagination to first page when number of documents is changed. https://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
…220139) ## Summary **Problem** When number of documents is changed, the total number of pages are recalculated but current page is not changed. This works fine, but when on last page and changing to larger number of documents makes the page to show zero documents **Fix** Changed to reset pagination to first page when number of documents is changed. https://github.com/user-attachments/assets/02eab354-b4bd-40cf-af47-1a692951f08e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When number of documents is changed, the total number of pages are recalculated but current page is not changed. This works fine, but when on last page and changing to larger number of documents makes the page to show zero documents
Fix
Changed to reset pagination to first page when number of documents is changed.
pagination.demo.mov