[Fleet] Add integration flyout#220229
Merged
juliaElastic merged 22 commits intoelastic:mainfrom Jun 4, 2025
Merged
Conversation
11 tasks
juliaElastic
added
backport:skip
botelastic
bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
MichelLosier
left a comment
MichelLosier
left a comment
There was a problem hiding this comment.
Looks good so far! Seems there are some failing tests to address, otherwise small items to consider.
...et/sections/agent_policy/details_page/components/package_policies/add_integration_flyout.tsx
Outdated
Show resolved
Hide resolved
...et/sections/agent_policy/details_page/components/package_policies/add_integration_flyout.tsx
Outdated
Show resolved
Hide resolved
| children: replaceStepConfigurePackagePolicy || stepConfigurePackagePolicy, | ||
| children: !pkgName ? null : ( | ||
| <> | ||
| {addIntegrationFlyoutProps ? ( |
Contributor
There was a problem hiding this comment.
nit: I think we can simplify this with just an &&
{addIntegrationFlyoutProps && (
<AddIntegrationFlyoutConfigureHeader
pkgLabel={pkgLabel}
pkgName={pkgName}
pkgVersion={packageInfo?.version}
integration={integration}
/>
)}
Contributor
There was a problem hiding this comment.
likewise with children: !pkgName ? null : ( could look probably look like children: pkgName && (...
...ications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout/index.tsx
Show resolved
Hide resolved
| } | ||
| }, [settings?.item]); | ||
|
|
||
| const { filteredCards } = useAvailablePackages({ prereleaseIntegrationsEnabled: prerelease }); |
Contributor
There was a problem hiding this comment.
It looks like this can return an isLoading state, could we pass this to the EuiComboBox ? Currently when loading the search box will have a message that there are no options available.
…/sections/agent_policy/details_page/components/package_policies/add_integration_flyout.tsx Co-authored-by: Michel Losier <mikelosier@gmail.com>
…/sections/agent_policy/details_page/components/package_policies/add_integration_flyout.tsx Co-authored-by: Michel Losier <mikelosier@gmail.com>
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
## Summary Closes elastic#199345 Add integration flyout in Agent policy details Added a combobox to select integration with icons [Figma design](https://www.figma.com/design/8OS6CP64kvVj57b0JRoYlo/Fleet---Improve-breadcrumb-navigation-between-Fleet---Integrations?node-id=18107-21321&t=ZzyGnOGJlzd0Hq2y-0) <img width="1620" alt="image" src="https://github.com/user-attachments/assets/2c508916-9caf-428f-8ecd-6b3efa6c8947" /> <img width="680" alt="image" src="https://github.com/user-attachments/assets/b23314a6-f8ed-4a1c-9b33-7c9fb8744504" /> <img width="817" alt="image" src="https://github.com/user-attachments/assets/c523e9fd-b0b5-4be2-8363-9ea2bd78b8da" /> <img width="1106" alt="image" src="https://github.com/user-attachments/assets/972b93e4-1a13-4cb3-bbc7-93acc1e810f6" /> Error toast: <img width="1614" alt="image" src="https://github.com/user-attachments/assets/4c56581b-af53-412c-bea7-c3c94a221256" /> <img width="823" alt="image" src="https://github.com/user-attachments/assets/aca2f186-3f31-4181-bae1-3c44ca53e317" /> <img width="1485" alt="image" src="https://github.com/user-attachments/assets/ea17ad38-0da7-4d7d-afb8-e0996b1cba78" /> <img width="673" alt="image" src="https://github.com/user-attachments/assets/3ce8de6f-281b-443f-800a-79605962d83c" /> Read more link goes to the integration reference e.g. https://www.elastic.co/docs/reference/integrations/aws/ecs <img width="1315" alt="image" src="https://github.com/user-attachments/assets/1eda2443-243e-430b-96ca-b1d09953b598" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Michel Losier <mikelosier@gmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
## Summary Closes elastic#199345 Add integration flyout in Agent policy details Added a combobox to select integration with icons [Figma design](https://www.figma.com/design/8OS6CP64kvVj57b0JRoYlo/Fleet---Improve-breadcrumb-navigation-between-Fleet---Integrations?node-id=18107-21321&t=ZzyGnOGJlzd0Hq2y-0) <img width="1620" alt="image" src="https://github.com/user-attachments/assets/2c508916-9caf-428f-8ecd-6b3efa6c8947" /> <img width="680" alt="image" src="https://github.com/user-attachments/assets/b23314a6-f8ed-4a1c-9b33-7c9fb8744504" /> <img width="817" alt="image" src="https://github.com/user-attachments/assets/c523e9fd-b0b5-4be2-8363-9ea2bd78b8da" /> <img width="1106" alt="image" src="https://github.com/user-attachments/assets/972b93e4-1a13-4cb3-bbc7-93acc1e810f6" /> Error toast: <img width="1614" alt="image" src="https://github.com/user-attachments/assets/4c56581b-af53-412c-bea7-c3c94a221256" /> <img width="823" alt="image" src="https://github.com/user-attachments/assets/aca2f186-3f31-4181-bae1-3c44ca53e317" /> <img width="1485" alt="image" src="https://github.com/user-attachments/assets/ea17ad38-0da7-4d7d-afb8-e0996b1cba78" /> <img width="673" alt="image" src="https://github.com/user-attachments/assets/3ce8de6f-281b-443f-800a-79605962d83c" /> Read more link goes to the integration reference e.g. https://www.elastic.co/docs/reference/integrations/aws/ecs <img width="1315" alt="image" src="https://github.com/user-attachments/assets/1eda2443-243e-430b-96ca-b1d09953b598" /> ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Michel Losier <mikelosier@gmail.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #199345
Add integration flyout in Agent policy details
Added a combobox to select integration with icons
Figma design
Error toast:
Read more link goes to the integration reference e.g. https://www.elastic.co/docs/reference/integrations/aws/ecs
Checklist