[8.19] [SLO] Check for unique SLO ids across spaces (#214496)#220267
Merged
baileycash-elastic merged 5 commits intoelastic:8.19from May 7, 2025
Merged
[8.19] [SLO] Check for unique SLO ids across spaces (#214496)#220267baileycash-elastic merged 5 commits intoelastic:8.19from
baileycash-elastic merged 5 commits intoelastic:8.19from
Conversation
## Summary Resolves elastic#212784 Ensure that when an SLO is created, the id is verified across all spaces. ## Release Notes Ensure that when an SLO is created, the id is verified across all spaces. ## Testing 1. Create an SLO and save the id returned in the response in a space "A" 2. Create a second SLO with the id saved from the first SLO in the request in a different space "B" 3. User should receive a 409 error from the SLO API. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 56f1ebf) # Conflicts: # x-pack/solutions/observability/plugins/slo/server/routes/slo/create_slo.ts # x-pack/solutions/observability/plugins/slo/server/routes/slo/inspect_slo.ts # x-pack/solutions/observability/plugins/slo/server/services/create_slo.test.ts # x-pack/solutions/observability/plugins/slo/server/services/create_slo.ts
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
kdelemme
approved these changes
May 6, 2025
Contributor
💔 Build Failed
Failed CI StepsHistory
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation