[Spaces] Fixed search in Spaces Grid Page#220398
Merged
elena-shostak merged 6 commits intoelastic:mainfrom May 21, 2025
Merged
Conversation
elena-shostak
added
Team:Security
elena-shostak
commented
May 8, 2025
| search={{ | ||
| onChange: this.debouncedOnQueryChange, | ||
| box: { | ||
| incremental: true, |
Contributor
Author
There was a problem hiding this comment.
Note
Have added incremental to enable search once you type. Since we filter it only on the client and filter function is debounced, don't expect any problems with that change.
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
legrego
reviewed
May 8, 2025
x-pack/platform/plugins/shared/spaces/public/management/spaces_grid/spaces_grid_page.tsx
Outdated
Show resolved
Hide resolved
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
elena-shostak
added
the
Feature:Security/Spaces
Contributor
|
Starting backport for target branches: 8.19 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 21, 2025
## Summary Fixed spaces search functionality for spaces created with Avatar type as image. https://github.com/user-attachments/assets/b2e802c2-42ec-48d7-9b30-d19e138d14dd ## How to test - Create multiple spaces with Avatar type as image. - Navigate to Management -> Stack Management - Open Spaces tab from left hand navigation bar under Kibana. - In search bar for Spaces, search for `de` as partial search for Default space. - Observe that all the Spaces with Avatar type as image will not be shown. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release Note Fixed spaces search functionality for spaces created with avatar type as image. __Fixes: https://github.com/elastic/kibana/issues/192810__ (cherry picked from commit 57f602e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 21, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[Spaces] Fixed search in Spaces Grid Page (#220398)](#220398) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Elena Shostak","email":"165678770+elena-shostak@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-05-21T08:05:50Z","message":"[Spaces] Fixed search in Spaces Grid Page (#220398)\n\n## Summary\n\nFixed spaces search functionality for spaces created with Avatar type as\nimage.\n\n\nhttps://github.com/user-attachments/assets/b2e802c2-42ec-48d7-9b30-d19e138d14dd\n\n\n\n## How to test\n- Create multiple spaces with Avatar type as image.\n- Navigate to Management -> Stack Management\n- Open Spaces tab from left hand navigation bar under Kibana.\n- In search bar for Spaces, search for `de` as partial search for\nDefault space.\n- Observe that all the Spaces with Avatar type as image will not be\nshown.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n## Release Note\nFixed spaces search functionality for spaces created with avatar type as\nimage.\n\n\n__Fixes: https://github.com/elastic/kibana/issues/192810__","sha":"57f602eb58c2305954ccedeec16402b07c22f5d3","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Security","Feature:Security/Spaces","backport:version","v9.1.0","v8.19.0"],"title":"[Spaces] Fixed search in Spaces Grid Page","number":220398,"url":"https://github.com/elastic/kibana/pull/220398","mergeCommit":{"message":"[Spaces] Fixed search in Spaces Grid Page (#220398)\n\n## Summary\n\nFixed spaces search functionality for spaces created with Avatar type as\nimage.\n\n\nhttps://github.com/user-attachments/assets/b2e802c2-42ec-48d7-9b30-d19e138d14dd\n\n\n\n## How to test\n- Create multiple spaces with Avatar type as image.\n- Navigate to Management -> Stack Management\n- Open Spaces tab from left hand navigation bar under Kibana.\n- In search bar for Spaces, search for `de` as partial search for\nDefault space.\n- Observe that all the Spaces with Avatar type as image will not be\nshown.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n## Release Note\nFixed spaces search functionality for spaces created with avatar type as\nimage.\n\n\n__Fixes: https://github.com/elastic/kibana/issues/192810__","sha":"57f602eb58c2305954ccedeec16402b07c22f5d3"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220398","number":220398,"mergeCommit":{"message":"[Spaces] Fixed search in Spaces Grid Page (#220398)\n\n## Summary\n\nFixed spaces search functionality for spaces created with Avatar type as\nimage.\n\n\nhttps://github.com/user-attachments/assets/b2e802c2-42ec-48d7-9b30-d19e138d14dd\n\n\n\n## How to test\n- Create multiple spaces with Avatar type as image.\n- Navigate to Management -> Stack Management\n- Open Spaces tab from left hand navigation bar under Kibana.\n- In search bar for Spaces, search for `de` as partial search for\nDefault space.\n- Observe that all the Spaces with Avatar type as image will not be\nshown.\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n## Release Note\nFixed spaces search functionality for spaces created with avatar type as\nimage.\n\n\n__Fixes: https://github.com/elastic/kibana/issues/192810__","sha":"57f602eb58c2305954ccedeec16402b07c22f5d3"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Shostak <165678770+elena-shostak@users.noreply.github.com>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary Fixed spaces search functionality for spaces created with Avatar type as image. https://github.com/user-attachments/assets/b2e802c2-42ec-48d7-9b30-d19e138d14dd ## How to test - Create multiple spaces with Avatar type as image. - Navigate to Management -> Stack Management - Open Spaces tab from left hand navigation bar under Kibana. - In search bar for Spaces, search for `de` as partial search for Default space. - Observe that all the Spaces with Avatar type as image will not be shown. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release Note Fixed spaces search functionality for spaces created with avatar type as image. __Fixes: https://github.com/elastic/kibana/issues/192810__
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
## Summary Fixed spaces search functionality for spaces created with Avatar type as image. https://github.com/user-attachments/assets/b2e802c2-42ec-48d7-9b30-d19e138d14dd ## How to test - Create multiple spaces with Avatar type as image. - Navigate to Management -> Stack Management - Open Spaces tab from left hand navigation bar under Kibana. - In search bar for Spaces, search for `de` as partial search for Default space. - Observe that all the Spaces with Avatar type as image will not be shown. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release Note Fixed spaces search functionality for spaces created with avatar type as image. __Fixes: https://github.com/elastic/kibana/issues/192810__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed spaces search functionality for spaces created with Avatar type as image.
Screen.Recording.2025-05-08.at.11.50.03.mov
How to test
deas partial search for Default space.Checklist
release_note:*label is applied per the guidelinesRelease Note
Fixed spaces search functionality for spaces created with avatar type as image.
Fixes: #192810