[DataView] Fix inability to clear Document ID in data view field editor preview#220891
Merged
kertal merged 3 commits intoelastic:mainfrom May 20, 2025
Merged
Conversation
Member
Author
|
/ci |
kertal
added
Feature:Data Views
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
AlexGPlay
reviewed
May 19, 2025
.../plugins/shared/data_view_field_editor/public/components/preview/preview_controller.test.tsx
Outdated
Show resolved
Hide resolved
AlexGPlay
reviewed
May 19, 2025
.../plugins/shared/data_view_field_editor/public/components/preview/preview_controller.test.tsx
Outdated
Show resolved
Hide resolved
AlexGPlay
approved these changes
May 19, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @kertal |
Member
Author
|
@AlexGPlay confirmed, looking better now with the enhanced jest tests. merging |
Contributor
|
Starting backport for target branches: 8.19 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 20, 2025
…or preview (elastic#220891) Previously, clearing the document ID in the data-view field editor preview always reset it back to the original value. This change updates the preview logic so that an empty ID can be entered (cherry picked from commit 288a479)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 20, 2025
…ld editor preview (#220891) (#220970) # Backport This will backport the following commits from `main` to `8.19`: - [[DataView] Fix inability to clear document ID in data view field editor preview (#220891)](#220891) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"matthias.wilhelm@elastic.co"},"sourceCommit":{"committedDate":"2025-05-20T09:01:58Z","message":"[DataView] Fix inability to clear document ID in data view field editor preview (#220891)\n\nPreviously, clearing the document ID in the data-view field editor preview always reset it back to the original value. This change updates the preview logic so that an empty ID can be entered","sha":"288a479d13b4ba538805bde7efcb9829bdd76fc6","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Data Views","Team:DataDiscovery","backport:version","v9.1.0","v8.19.0"],"title":"[DataView] Fix inability to clear Document ID in data view field editor preview","number":220891,"url":"https://github.com/elastic/kibana/pull/220891","mergeCommit":{"message":"[DataView] Fix inability to clear document ID in data view field editor preview (#220891)\n\nPreviously, clearing the document ID in the data-view field editor preview always reset it back to the original value. This change updates the preview logic so that an empty ID can be entered","sha":"288a479d13b4ba538805bde7efcb9829bdd76fc6"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/220891","number":220891,"mergeCommit":{"message":"[DataView] Fix inability to clear document ID in data view field editor preview (#220891)\n\nPreviously, clearing the document ID in the data-view field editor preview always reset it back to the original value. This change updates the preview logic so that an empty ID can be entered","sha":"288a479d13b4ba538805bde7efcb9829bdd76fc6"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
…or preview (elastic#220891) Previously, clearing the document ID in the data-view field editor preview always reset it back to the original value. This change updates the preview logic so that an empty ID can be entered
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jun 3, 2025
…or preview (elastic#220891) Previously, clearing the document ID in the data-view field editor preview always reset it back to the original value. This change updates the preview logic so that an empty ID can be entered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #151245
With this PR the Document ID can be cleared in the data view field editor preview. Before it was just reset to the original ID. Here's a video showing how the id can be cleared
CleanShot.2025-05-19.at.11.52.21.mp4
Checklist