[Dashboard] Deprecate allow by value embeddables setting & remove usage#221165
Conversation
|
/ci |
…wByValueEmbeddables
|
/ci |
ThomThomson
changed the title
|
/ci |
…wByValueEmbeddables
|
/ci |
…wByValueEmbeddables
|
/ci |
…wByValueEmbeddables
|
/ci |
| }, | ||
| schema: configSchema, | ||
| deprecations: ({ deprecate }) => { | ||
| return [deprecate('allowByValueEmbeddables', '9.3.0', { level: 'warning' })]; |
There was a problem hiding this comment.
This key is called removeBy - I read that as "this warning will tell Kibana administrators to remove this YML config by this minor"
We're planning on removing this in 10.0, so I figured that it might be good to remind any admins that have this setting to remove it ASAP. If this is meant to remind us when to remove the YML config, then it's 10.0.
A lot of usages of this seem to have "a future version" in that field. I'd be happy to leave it as 9.3, or to switch it to 10.0.
There was a problem hiding this comment.
why 9.3 instead of the released version of 9.1. 9.3 seems like an odd choice.
There was a problem hiding this comment.
True. I just thought "sometime in the future - but not too far in the future" 😄 The guidelines here seem really loose, so I'd honestly be happy with any version.
There was a problem hiding this comment.
lets go with 9.1 since its marked as deprecated in that version
ThomThomson
added
Feature:Dashboard
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
added
loe:small
| }); | ||
|
|
||
| export const config: PluginConfigDescriptor<TypeOf<typeof configSchema>> = { | ||
| exposeToBrowser: { |
There was a problem hiding this comment.
Does allowByValueEmbeddables still need to be exposed to browser if its no longer used any where. I think we could remove exposeToBrowser section.
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Page load bundle
History
|
|
Starting backport for target branches: 9.0 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…ge (elastic#221165) Removes usage of the `allowByValueEmbeddables` setting
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ge (elastic#221165) Removes usage of the `allowByValueEmbeddables` setting (cherry picked from commit 754afac) # Conflicts: # src/platform/plugins/shared/dashboard/public/dashboard_actions/register_actions.ts # src/platform/plugins/shared/dashboard/public/plugin.tsx
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
…ve usage (#221165) (#221952) # Backport This will backport the following commits from `main` to `9.0`: - [[Dashboard] Deprecate allow by value embeddables setting & remove usage (#221165)](#221165) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Devon Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2025-05-28T19:43:06Z","message":"[Dashboard] Deprecate allow by value embeddables setting & remove usage (#221165)\n\nRemoves usage of the `allowByValueEmbeddables` setting","sha":"754afacb8e25e1b741a9f7a5b2cdc0b1ba243603","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:deprecation","Team:Presentation","loe:small","technical debt","impact:low","backport:prev-minor","v9.1.0"],"title":"[Dashboard] Deprecate allow by value embeddables setting & remove usage","number":221165,"url":"https://github.com/elastic/kibana/pull/221165","mergeCommit":{"message":"[Dashboard] Deprecate allow by value embeddables setting & remove usage (#221165)\n\nRemoves usage of the `allowByValueEmbeddables` setting","sha":"754afacb8e25e1b741a9f7a5b2cdc0b1ba243603"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221165","number":221165,"mergeCommit":{"message":"[Dashboard] Deprecate allow by value embeddables setting & remove usage (#221165)\n\nRemoves usage of the `allowByValueEmbeddables` setting","sha":"754afacb8e25e1b741a9f7a5b2cdc0b1ba243603"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added
v9.0.2
and removed
backport missing
|
This PR didn't make it into the latest 9.0.2 BC. Updating the labels. |
…ge (elastic#221165) Removes usage of the `allowByValueEmbeddables` setting
…ge (elastic#221165) Removes usage of the `allowByValueEmbeddables` setting
6 participants
Summary
Removes usage of the
allowByValueEmbeddablessetting from the Dashboard plugin, and marks the setting as deprecated. Closes #137197