Skip to content

[Discover] Add info icon to doc viewer table (#214366)#222299

Merged
AlexGPlay merged 1 commit intoelastic:mainfrom
AlexGPlay:214366-add-info-icon-to-doc-viewer-table
Jun 4, 2025
Merged

[Discover] Add info icon to doc viewer table (#214366)#222299
AlexGPlay merged 1 commit intoelastic:mainfrom
AlexGPlay:214366-add-info-icon-to-doc-viewer-table

Conversation

@AlexGPlay
Copy link
Contributor

@AlexGPlay AlexGPlay commented Jun 3, 2025

Summary

Closes #214366

Before After
image image

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
@AlexGPlay AlexGPlay force-pushed the 214366-add-info-icon-to-doc-viewer-table branch from 9faf559 to c53cd6e Compare June 3, 2025 09:08
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / getNextRunAt should use the rrule with a fixed time when it is given to calculate the next runAt

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedDocViewer 219.8KB 219.9KB +21.0B

History

@AlexGPlay AlexGPlay self-assigned this Jun 3, 2025
@AlexGPlay AlexGPlay added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// Feature:UnifiedDocViewer Issues relating to the unified doc viewer component backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 3, 2025
@AlexGPlay AlexGPlay marked this pull request as ready for review June 3, 2025 14:01
@AlexGPlay AlexGPlay requested a review from a team as a code owner June 3, 2025 14:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@akowalska622 akowalska622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast! Good job 🚀

@AlexGPlay AlexGPlay merged commit 08eb393 into elastic:main Jun 4, 2025
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15439060906

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 4, 2025
…c#222299)

## Summary

Closes elastic#214366

| Before | After |
|--------|------|
| <img width="387" alt="image"
src="https://github.com/user-attachments/assets/b0e011b9-5563-4b63-9632-cfed9d3eea1c"
/> | <img width="389" alt="image"
src="https://github.com/user-attachments/assets/b26696ab-ee6a-4433-8dd4-877e2d2e7d90"
/> |

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 08eb393)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 4, 2025
… (#222535)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Discover] Add info icon to doc viewer table (#214366)
(#222299)](#222299)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alejandro García
Parrondo","email":"31973472+AlexGPlay@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-04T09:44:17Z","message":"[Discover]
Add info icon to doc viewer table (#214366) (#222299)\n\n##
Summary\n\nCloses https://github.com/elastic/kibana/issues/214366\n\n|
Before | After |\n|--------|------|\n| <img width=\"387\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b0e011b9-5563-4b63-9632-cfed9d3eea1c\"\n/>
| <img width=\"389\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b26696ab-ee6a-4433-8dd4-877e2d2e7d90\"\n/>
|\n\n\n### Checklist\n\nCheck the PR satisfies following conditions.
\n\nReviewers should verify this PR satisfies this list as well.\n\n-
[x] The PR description includes the appropriate Release Notes
section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"08eb3938df4208108f3954874b212dd2b001a322","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:DataDiscovery","Feature:UnifiedDocViewer","backport:version","v9.1.0","v8.19.0"],"title":"[Discover]
Add info icon to doc viewer table
(#214366)","number":222299,"url":"https://github.com/elastic/kibana/pull/222299","mergeCommit":{"message":"[Discover]
Add info icon to doc viewer table (#214366) (#222299)\n\n##
Summary\n\nCloses https://github.com/elastic/kibana/issues/214366\n\n|
Before | After |\n|--------|------|\n| <img width=\"387\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b0e011b9-5563-4b63-9632-cfed9d3eea1c\"\n/>
| <img width=\"389\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b26696ab-ee6a-4433-8dd4-877e2d2e7d90\"\n/>
|\n\n\n### Checklist\n\nCheck the PR satisfies following conditions.
\n\nReviewers should verify this PR satisfies this list as well.\n\n-
[x] The PR description includes the appropriate Release Notes
section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"08eb3938df4208108f3954874b212dd2b001a322"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222299","number":222299,"mergeCommit":{"message":"[Discover]
Add info icon to doc viewer table (#214366) (#222299)\n\n##
Summary\n\nCloses https://github.com/elastic/kibana/issues/214366\n\n|
Before | After |\n|--------|------|\n| <img width=\"387\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b0e011b9-5563-4b63-9632-cfed9d3eea1c\"\n/>
| <img width=\"389\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b26696ab-ee6a-4433-8dd4-877e2d2e7d90\"\n/>
|\n\n\n### Checklist\n\nCheck the PR satisfies following conditions.
\n\nReviewers should verify this PR satisfies this list as well.\n\n-
[x] The PR description includes the appropriate Release Notes
section,\nand the correct `release_note:*` label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"08eb3938df4208108f3954874b212dd2b001a322"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Alejandro García Parrondo <31973472+AlexGPlay@users.noreply.github.com>
zacharyparikh pushed a commit to zacharyparikh/kibana that referenced this pull request Jun 4, 2025
…c#222299)

## Summary

Closes elastic#214366

| Before | After |
|--------|------|
| <img width="387" alt="image"
src="https://github.com/user-attachments/assets/b0e011b9-5563-4b63-9632-cfed9d3eea1c"
/> | <img width="389" alt="image"
src="https://github.com/user-attachments/assets/b26696ab-ee6a-4433-8dd4-877e2d2e7d90"
/> |


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@AlexGPlay AlexGPlay added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Jun 10, 2025
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
…c#222299)

## Summary

Closes elastic#214366

| Before | After |
|--------|------|
| <img width="387" alt="image"
src="https://github.com/user-attachments/assets/b0e011b9-5563-4b63-9632-cfed9d3eea1c"
/> | <img width="389" alt="image"
src="https://github.com/user-attachments/assets/b26696ab-ee6a-4433-8dd4-877e2d2e7d90"
/> |


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:UnifiedDocViewer Issues relating to the unified doc viewer component release_note:fix Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.19.0 v9.1.0

4 participants