[Saved objects client - bulkUpdate] Passing the correct namespace to migrateInputDocument by cesco-f · Pull Request #222313 · elastic/kibana

cesco-f · 2025-06-03T09:02:47Z

While working on this PR I noticed an issue when trying to bulk update saved objects overriding the current space for the operation.

rudolf · 2025-06-03T14:44:11Z

src/core/packages/saved-objects/api-server-internal/src/lib/apis/bulk_update.ts

        id,
        type,
-        namespace,
+        namespace: getNamespaceId(objectNamespace),


This looks correct but we should not set a namespace if this is a multinamespace saved object type. So we need to do something similar to the update method where either namespace or namespaces is set depending on if this is multi/single namespace.

https://github.com/elastic/kibana/blob/main/src/core/packages/saved-objects/api-server-internal/src/lib/apis/update.ts#L162-L179

wdyt @TinaHeiligers

++
May even have to look back at this section where "namespaces" is set, and adjust to account for "namespace" vs "namespaces" throughout the rest of the code.

kibana/src/core/packages/saved-objects/api-server-internal/src/lib/apis/bulk_update.ts

Line 261 in d3abb6e

if (isMultiNS) {

Hey team 😊

Can we maybe merge this to fix my use case and open another PR to fix the multinamespace saved object type?

I can make push some changes to take care of this. I will take a look on Monday.

Sorry for the delay. I pushed c122b83
I believe it will handle the difference between single and multi-namespace types correctly. I also officially tagged @TinaHeiligers for a review.

I suspect this isn't a bug and could be a callee error because we haven't had any other reports of namespace issues. I'll take a look at the diffs.

So we need to do something similar to the update method where either namespace or namespaces is set depending on if this is multi/single namespace.

If bulkUpdate now supports upsert, then probably yes. When I worked on the API making it BWC, bulkUpdate didn't support upsert, nor did it support partial updates.

Using getNamespaceId might mess with the namespaces array, so we'll need to watch the tests carefully.

elasticmachine · 2025-06-03T15:44:19Z

Pinging @elastic/kibana-core (Team:Core)

TinaHeiligers

left a comment.

src/core/packages/saved-objects/api-server-internal/src/lib/apis/bulk_update.test.ts

rudolf

Just left a question to clarify what kind of namespace (string or id) we need for encryption. Otherwise lgtm

src/core/packages/saved-objects/api-server-internal/src/lib/apis/bulk_update.ts

rudolf · 2025-06-10T15:29:01Z

src/core/packages/saved-objects/api-server-internal/src/lib/apis/bulk_update.ts

        type,
-        namespace,
-        namespaces,
+        ...(savedObjectNamespace && { namespace: savedObjectNamespace }),


Can't comment on the right place, but in line 297 should we fallback to namespace or namespaceString for the encryption helper?

It actually doesn't matter if we pass a namespace ID or a namespace string to the encryption extension - it will always get "normalized" and used appropriately. ~~However, you brought to my attention that the parameters might have always been wrong here.~~

~~The object should be encrypted based on its descriptor, not the current namespace or the provided object namespace. So... let me think about this...~~

Disregard...I forgot that we do not use namespace in the descriptor for multi-namespace ESOs.

jeramysoucy · 2025-06-13T11:26:31Z

src/core/packages/saved-objects/api-server-internal/src/lib/apis/bulk_update.ts

        type,
        id,
-        objectNamespace || namespace,
+        savedObjectNamespaces ?? savedObjectNamespace,


Encryption should always be based on the object's actual namespace(s). For multi-namespace objects, we pick the first namespace to use in the encryption descriptor (we also "normalize" the parameters to handle passing an namespace vs namespace string). So because namespaces can be overridden in bulk update per object, we should be careful here not to use either the provided object namespace or the current namespace, because it might render an multi-namespace ESO undecryptable. Does this make sense?

I also think we really need tests for this logic specifically (bulk update, object space override on a multispace encrypted object), but I have not had time to do so.

😓 Ahhh...nevermind! No namespace is used for the ESO descriptor for multi-namespace objects. Disregard. We can revert this back to what was there.

TinaHeiligers

LGTM

…k-update-namespace

elasticmachine · 2025-06-18T12:29:20Z

⏳ Build in-progress, with failures

Buildkite Build
Commit: 3ba40ab

Failed CI Steps

Check Types

History

💔 Build #309909 failed f902c06
💔 Build #308928 failed f0d27f3
💔 Build #308384 failed b587d1d
💔 Build #308266 failed d18b2aa
💔 Build #306678 failed 15ebfd8
💚 Build #305656 succeeded 791a5ee

kibanamachine · 2025-06-19T08:01:50Z

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15752738765

…migrateInputDocument (elastic#222313) While working on [this PR](elastic#221515) I noticed an issue when trying to bulk update saved objects overriding the current space for the operation. --------- Co-authored-by: “jeramysoucy” <jeramy.soucy@elastic.co> Co-authored-by: Shahzad <shahzad31comp@gmail.com> Co-authored-by: Rudolf Meijering <skaapgif@gmail.com> (cherry picked from commit 9794168)

kibanamachine · 2025-06-19T08:08:25Z

💚 All backports created successfully

Status	Branch	Result
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ace to migrateInputDocument (#222313) (#224522) # Backport This will backport the following commits from `main` to `8.19`: - [[Saved objects client - bulkUpdate] Passing the correct namespace to migrateInputDocument (#222313)](#222313)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com> Co-authored-by: “jeramysoucy” <jeramy.soucy@elastic.co> Co-authored-by: Shahzad <shahzad31comp@gmail.com> Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>

…pace to migrateInputDocument (elastic#222313)" This reverts commit 9794168.

cesco-f requested a review from a team as a code owner June 3, 2025 09:02

cesco-f added release_note:fix backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 3, 2025

github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Jun 3, 2025

rudolf reviewed Jun 3, 2025

View reviewed changes

rudolf added the Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// label Jun 3, 2025

rudolf added the bug Fixes for quality problems that affect the customer experience label Jun 3, 2025

fix(bulk update): passing the correct namespace to migrateInputDocument

791a5ee

cesco-f force-pushed the fix-bulk-update-namespace branch from d3abb6e to 791a5ee Compare June 5, 2025 09:22

jeramysoucy added 2 commits June 9, 2025 18:07

Handles namespace vs namespaces

c122b83

Merge branch 'main' into fix-bulk-update-namespace

15ebfd8

jeramysoucy requested a review from TinaHeiligers June 9, 2025 16:09

TinaHeiligers reviewed Jun 9, 2025

View reviewed changes

src/core/packages/saved-objects/api-server-internal/src/lib/apis/bulk_update.test.ts Show resolved Hide resolved

rudolf reviewed Jun 10, 2025

View reviewed changes

shahzad31 requested review from TinaHeiligers and jeramysoucy June 12, 2025 07:38

Addresses feedback, corrects encryption params

ddbc57b

jeramysoucy reviewed Jun 13, 2025

View reviewed changes

Merge branch 'main' into fix-bulk-update-namespace

d18b2aa

jeramysoucy mentioned this pull request Jun 13, 2025

[Synthetics] Edit private locations labels and tags in Synthetics #221515

Merged

jeramysoucy added 2 commits June 13, 2025 16:38

Reverts namespace argument to encryption func

e43846a

Merge branch 'main' into fix-bulk-update-namespace

b587d1d

rudolf approved these changes Jun 16, 2025

View reviewed changes

Merge branch 'main' into fix-bulk-update-namespace

f0d27f3

TinaHeiligers approved these changes Jun 18, 2025

View reviewed changes

shahzad31 added 2 commits June 18, 2025 11:31

Merge branch 'main' of https://github.com/elastic/kibana into fix-bul…

95c38f3

…k-update-namespace

use namespace for update

f902c06

update

3ba40ab

rudolf and others added 2 commits June 18, 2025 14:41

Add test to make update method behavior explicit

70aa25f

type

a248161

cesco-f merged commit 9794168 into elastic:main Jun 19, 2025
10 checks passed

kibanamachine mentioned this pull request Jun 19, 2025

[8.19] [Saved objects client - bulkUpdate] Passing the correct namespace to migrateInputDocument (#222313) #224522

Merged

cesco-f deleted the fix-bulk-update-namespace branch June 19, 2025 08:23

shahzad31 mentioned this pull request Jun 25, 2025

Revert "[Saved objects client - bulkUpdate] Passing the correct namespace to migrateInputDocument" #225250

Closed

rudolf mentioned this pull request Jun 25, 2025

bulkUpdate regression causes invalid default namespace in source #225254

Closed

rudolf added a commit to rudolf/kibana that referenced this pull request Jun 25, 2025

Revert "[Saved objects client - bulkUpdate] Passing the correct names…

944310c

…pace to migrateInputDocument (elastic#222313)" This reverts commit 9794168.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Saved objects client - bulkUpdate] Passing the correct namespace to migrateInputDocument#222313

[Saved objects client - bulkUpdate] Passing the correct namespace to migrateInputDocument#222313
cesco-f merged 13 commits intoelastic:mainfrom
cesco-f:fix-bulk-update-namespace

cesco-f commented Jun 3, 2025 •

edited by kibanamachine

Loading

rudolf Jun 3, 2025

jeramysoucy Jun 4, 2025 •

edited

Loading

cesco-f Jun 5, 2025

jeramysoucy Jun 6, 2025

jeramysoucy Jun 9, 2025

TinaHeiligers Jun 9, 2025

TinaHeiligers Jun 9, 2025 •

edited

Loading

elasticmachine commented Jun 3, 2025

TinaHeiligers left a comment

Uh oh!

rudolf left a comment

Uh oh!

rudolf Jun 10, 2025

jeramysoucy Jun 13, 2025 •

edited

Loading

jeramysoucy Jun 13, 2025 •

edited

Loading

jeramysoucy Jun 13, 2025

jeramysoucy Jun 13, 2025

TinaHeiligers left a comment

elasticmachine commented Jun 18, 2025

Uh oh!

kibanamachine commented Jun 19, 2025

kibanamachine commented Jun 19, 2025

Labels

7 participants

Conversation

cesco-f commented Jun 3, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

jeramysoucy Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

elasticmachine commented Jun 3, 2025

TinaHeiligers left a comment

Choose a reason for hiding this comment

Uh oh!

rudolf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

jeramysoucy Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

jeramysoucy Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers left a comment

Choose a reason for hiding this comment

elasticmachine commented Jun 18, 2025

⏳ Build in-progress, with failures

Failed CI Steps

History

Uh oh!

kibanamachine commented Jun 19, 2025

kibanamachine commented Jun 19, 2025

💚 All backports created successfully

Questions ?

Labels

7 participants

cesco-f commented Jun 3, 2025 •

edited by kibanamachine

Loading

jeramysoucy Jun 4, 2025 •

edited

Loading

TinaHeiligers Jun 9, 2025 •

edited

Loading

jeramysoucy Jun 13, 2025 •

edited

Loading

jeramysoucy Jun 13, 2025 •

edited

Loading