[8.18] Use msearch to fetch the alerts for maintenance windows with scoped query (#221702)#222490
Merged
ersin-erdal merged 4 commits intoelastic:8.18from Jun 4, 2025
Merged
Conversation
…uery (elastic#221702) Currently we use a search with a `top_hits` aggregation to get the alerts filtered with the scoped queries of the active maintenance windows. But since `top_hits` aggregation has a fixed limit of 100 hits we cannot use our max alerts limit to get all the alerts an execution can generate. This PR replaces `search` with `msearch` and removes the aggregation from the search query so we can use the maxAlerts limit for the response size. (cherry picked from commit 1343bfe) # Conflicts: # x-pack/platform/plugins/shared/alerting/server/alerts_client/alerts_client.test.ts # x-pack/platform/plugins/shared/alerting/server/alerts_client/alerts_client.ts # x-pack/platform/plugins/shared/alerting/server/alerts_client/lib/get_summarized_alerts_query.ts
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
doakalexi
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.18:Questions ?
Please refer to the Backport tool documentation