[ES|QL] Fix COALESCE autocomplete#222607
Merged
drewdaemon merged 38 commits intoelastic:mainfrom Jun 5, 2025
Merged
Conversation
drewdaemon
added
backport:version
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
History
|
stratoula
approved these changes
Jun 5, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Autocomplete fixed, lovely cleanup 🚀
Contributor
|
Starting backport for target branches: 8.19 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 5, 2025
## Summary The autocomplete side of elastic#222425 Also, cleans up and simplifies some unnecessarily-complicated autocomplete function test code, following the same pattern we used for function validation testing 💪 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 1279bc9)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Jun 9, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [[ES|QL] Fix `COALESCE` autocomplete (#222607)](#222607) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"drew.tate@elastic.co"},"sourceCommit":{"committedDate":"2025-06-05T15:10:48Z","message":"[ES|QL] Fix `COALESCE` autocomplete (#222607)\n\n## Summary\n\nThe autocomplete side of https://github.com/elastic/kibana/pull/222425\n\nAlso, cleans up and simplifies some unnecessarily-complicated\nautocomplete function test code, following the same pattern we used for\nfunction validation testing 💪\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"1279bc9f92486d6e22e849ff390be3f957764414","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:ES|QL","Team:ESQL","backport:version","v9.1.0","v8.19.0"],"title":"[ES|QL] Fix `COALESCE` autocomplete","number":222607,"url":"https://github.com/elastic/kibana/pull/222607","mergeCommit":{"message":"[ES|QL] Fix `COALESCE` autocomplete (#222607)\n\n## Summary\n\nThe autocomplete side of https://github.com/elastic/kibana/pull/222425\n\nAlso, cleans up and simplifies some unnecessarily-complicated\nautocomplete function test code, following the same pattern we used for\nfunction validation testing 💪\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"1279bc9f92486d6e22e849ff390be3f957764414"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222607","number":222607,"mergeCommit":{"message":"[ES|QL] Fix `COALESCE` autocomplete (#222607)\n\n## Summary\n\nThe autocomplete side of https://github.com/elastic/kibana/pull/222425\n\nAlso, cleans up and simplifies some unnecessarily-complicated\nautocomplete function test code, following the same pattern we used for\nfunction validation testing 💪\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"1279bc9f92486d6e22e849ff390be3f957764414"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Drew Tate <drew.tate@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
pmuellr
pushed a commit
to pmuellr/kibana
that referenced
this pull request
Jun 11, 2025
## Summary The autocomplete side of elastic#222425 Also, cleans up and simplifies some unnecessarily-complicated autocomplete function test code, following the same pattern we used for function validation testing 💪 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
## Summary The autocomplete side of elastic#222425 Also, cleans up and simplifies some unnecessarily-complicated autocomplete function test code, following the same pattern we used for function validation testing 💪 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The autocomplete side of #222425
Also, cleans up and simplifies some unnecessarily-complicated autocomplete function test code, following the same pattern we used for function validation testing 💪
Checklist