Skip to content

[8.19] [Response Ops][Alerting] Fixing issue with setting cancelAlertsOnRuleTimeout=false in kibana config (#222263)#222729

Merged
kibanamachine merged 2 commits intoelastic:8.19from
kibanamachine:backport/8.19/pr-222263
Jun 5, 2025
Merged

[8.19] [Response Ops][Alerting] Fixing issue with setting cancelAlertsOnRuleTimeout=false in kibana config (#222263)#222729
kibanamachine merged 2 commits intoelastic:8.19from
kibanamachine:backport/8.19/pr-222263

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

…eTimeout=false` in kibana config (elastic#222263)

Fixing elastic#222127

## Summary

Fixes issue that causes Kibana to bootloop when
`xpack.alerting.cancelAlertsOnRuleTimeout` is set to `false` in the
kibana config.

Moves the check for incompatible `cancelAlertsOnRuleTimeout` and
`autoRecoverAlerts` rule type config to the plugin setup code because we
mutate some of these values before registering. So now the check
actually checks the values set by the rule type in the code. Then we
proceed with merging some of these values with the Kibana config.
Because there are issues with lifecycle rule types when
`cancelAlertsOnRuleTimeout` is set to false, we log a warning when we
see this override in the config and ignore the setting for lifecycle
rule types. Persistent rule types (detection rules) will still respect
this config override if set.

There will be a followup issue to deprecate this config for 9.10 and
8.19. This PR is to address the immediate bug.

## To Verify
1. Set `xpack.alerting.cancelAlertsOnRuleTimeout: false` in the Kibana
config and start Kibana.
2. Verify Kibana starts up correctly with no errors.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 69690c9)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jun 5, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) June 5, 2025 02:06
@ymao1
Copy link
Contributor

ymao1 commented Jun 5, 2025

@elasticmachine merge upstream

@kibanamachine kibanamachine merged commit 8e4cbca into elastic:8.19 Jun 5, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / Testing AddDataProviderPopover Test Popover is visible

Metrics [docs]

✅ unchanged

History

cc @ymao1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

3 participants