Skip to content

[ML] File upload: Fixes adding additional field when pipeline is blank#222775

Merged
jgowdyelastic merged 2 commits intoelastic:mainfrom
jgowdyelastic:fixing-auto-adding-additional-fields-when-no-pipeline-is-present
Jun 5, 2025
Merged

[ML] File upload: Fixes adding additional field when pipeline is blank#222775
jgowdyelastic merged 2 commits intoelastic:mainfrom
jgowdyelastic:fixing-auto-adding-additional-fields-when-no-pipeline-is-present

Conversation

@jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jun 5, 2025

If no pipeline has been generated, when adding an additional field like semantic text or geo point, the empty pipeline is populated before adding the processor

Fixes #222742

@jgowdyelastic jgowdyelastic marked this pull request as ready for review June 5, 2025 09:17
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner June 5, 2025 09:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 670.8KB 670.8KB +61.0B

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit b13fe6a into elastic:main Jun 5, 2025
11 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.19, 9.0

https://github.com/elastic/kibana/actions/runs/15466318616

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 5, 2025
…nk (elastic#222775)

If no pipeline has been generated, when adding an additional field like
semantic text or geo point, the empty pipeline is populated before
adding the processor

Fixes elastic#222742

(cherry picked from commit b13fe6a)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 5, 2025
…nk (elastic#222775)

If no pipeline has been generated, when adding an additional field like
semantic text or geo point, the empty pipeline is populated before
adding the processor

Fixes elastic#222742

(cherry picked from commit b13fe6a)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 5, 2025
…nk (elastic#222775)

If no pipeline has been generated, when adding an additional field like
semantic text or geo point, the empty pipeline is populated before
adding the processor

Fixes elastic#222742

(cherry picked from commit b13fe6a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.18
8.19
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

zacharyparikh pushed a commit to zacharyparikh/kibana that referenced this pull request Jun 5, 2025
…nk (elastic#222775)

If no pipeline has been generated, when adding an additional field like
semantic text or geo point, the empty pipeline is populated before
adding the processor

Fixes elastic#222742
kibanamachine added a commit that referenced this pull request Jun 5, 2025
… is blank (#222775) (#222801)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[ML] File upload: Fixing adding additional field when pipeline is
blank (#222775)](#222775)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2025-06-05T11:53:20Z","message":"[ML]
File upload: Fixing adding additional field when pipeline is blank
(#222775)\n\nIf no pipeline has been generated, when adding an
additional field like\nsemantic text or geo point, the empty pipeline is
populated before\nadding the processor\n\nFixes
https://github.com/elastic/kibana/issues/222742","sha":"b13fe6a426acbd6226a73a08036dec5b2254bdd2","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:File
and Index Data Viz","Feature:File
Upload","backport:version","v9.1.0","v8.19.0","v9.0.3","v8.18.3"],"title":"[ML]
File upload: Fixing adding additional field when pipeline is
blank","number":222775,"url":"https://github.com/elastic/kibana/pull/222775","mergeCommit":{"message":"[ML]
File upload: Fixing adding additional field when pipeline is blank
(#222775)\n\nIf no pipeline has been generated, when adding an
additional field like\nsemantic text or geo point, the empty pipeline is
populated before\nadding the processor\n\nFixes
https://github.com/elastic/kibana/issues/222742","sha":"b13fe6a426acbd6226a73a08036dec5b2254bdd2"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222775","number":222775,"mergeCommit":{"message":"[ML]
File upload: Fixing adding additional field when pipeline is blank
(#222775)\n\nIf no pipeline has been generated, when adding an
additional field like\nsemantic text or geo point, the empty pipeline is
populated before\nadding the processor\n\nFixes
https://github.com/elastic/kibana/issues/222742","sha":"b13fe6a426acbd6226a73a08036dec5b2254bdd2"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine added a commit that referenced this pull request Jun 5, 2025
…is blank (#222775) (#222803)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[ML] File upload: Fixing adding additional field when pipeline is
blank (#222775)](#222775)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2025-06-05T11:53:20Z","message":"[ML]
File upload: Fixing adding additional field when pipeline is blank
(#222775)\n\nIf no pipeline has been generated, when adding an
additional field like\nsemantic text or geo point, the empty pipeline is
populated before\nadding the processor\n\nFixes
https://github.com/elastic/kibana/issues/222742","sha":"b13fe6a426acbd6226a73a08036dec5b2254bdd2","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:File
and Index Data Viz","Feature:File
Upload","backport:version","v9.1.0","v8.19.0","v9.0.3","v8.18.3"],"title":"[ML]
File upload: Fixing adding additional field when pipeline is
blank","number":222775,"url":"https://github.com/elastic/kibana/pull/222775","mergeCommit":{"message":"[ML]
File upload: Fixing adding additional field when pipeline is blank
(#222775)\n\nIf no pipeline has been generated, when adding an
additional field like\nsemantic text or geo point, the empty pipeline is
populated before\nadding the processor\n\nFixes
https://github.com/elastic/kibana/issues/222742","sha":"b13fe6a426acbd6226a73a08036dec5b2254bdd2"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222775","number":222775,"mergeCommit":{"message":"[ML]
File upload: Fixing adding additional field when pipeline is blank
(#222775)\n\nIf no pipeline has been generated, when adding an
additional field like\nsemantic text or geo point, the empty pipeline is
populated before\nadding the processor\n\nFixes
https://github.com/elastic/kibana/issues/222742","sha":"b13fe6a426acbd6226a73a08036dec5b2254bdd2"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine added a commit that referenced this pull request Jun 5, 2025
… is blank (#222775) (#222802)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[ML] File upload: Fixing adding additional field when pipeline is
blank (#222775)](#222775)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2025-06-05T11:53:20Z","message":"[ML]
File upload: Fixing adding additional field when pipeline is blank
(#222775)\n\nIf no pipeline has been generated, when adding an
additional field like\nsemantic text or geo point, the empty pipeline is
populated before\nadding the processor\n\nFixes
https://github.com/elastic/kibana/issues/222742","sha":"b13fe6a426acbd6226a73a08036dec5b2254bdd2","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:File
and Index Data Viz","Feature:File
Upload","backport:version","v9.1.0","v8.19.0","v9.0.3","v8.18.3"],"title":"[ML]
File upload: Fixing adding additional field when pipeline is
blank","number":222775,"url":"https://github.com/elastic/kibana/pull/222775","mergeCommit":{"message":"[ML]
File upload: Fixing adding additional field when pipeline is blank
(#222775)\n\nIf no pipeline has been generated, when adding an
additional field like\nsemantic text or geo point, the empty pipeline is
populated before\nadding the processor\n\nFixes
https://github.com/elastic/kibana/issues/222742","sha":"b13fe6a426acbd6226a73a08036dec5b2254bdd2"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0","8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222775","number":222775,"mergeCommit":{"message":"[ML]
File upload: Fixing adding additional field when pipeline is blank
(#222775)\n\nIf no pipeline has been generated, when adding an
additional field like\nsemantic text or geo point, the empty pipeline is
populated before\nadding the processor\n\nFixes
https://github.com/elastic/kibana/issues/222742","sha":"b13fe6a426acbd6226a73a08036dec5b2254bdd2"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <jgowdy@elastic.co>
@peteharverson peteharverson changed the title [ML] File upload: Fixing adding additional field when pipeline is blank Jun 10, 2025
pmuellr pushed a commit to pmuellr/kibana that referenced this pull request Jun 11, 2025
…nk (elastic#222775)

If no pipeline has been generated, when adding an additional field like
semantic text or geo point, the empty pipeline is populated before
adding the processor

Fixes elastic#222742
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
…nk (elastic#222775)

If no pipeline has been generated, when adding an additional field like
semantic text or geo point, the empty pipeline is populated before
adding the processor

Fixes elastic#222742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment