[9.0] [Response Ops][Alerting] Fixing issue with setting cancelAlertsOnRuleTimeout=false in kibana config (#222263)#222799
Merged
ymao1 merged 2 commits intoelastic:9.0from Jun 5, 2025
Merged
Conversation
…eTimeout=false` in kibana config (elastic#222263) Fixing elastic#222127 ## Summary Fixes issue that causes Kibana to bootloop when `xpack.alerting.cancelAlertsOnRuleTimeout` is set to `false` in the kibana config. Moves the check for incompatible `cancelAlertsOnRuleTimeout` and `autoRecoverAlerts` rule type config to the plugin setup code because we mutate some of these values before registering. So now the check actually checks the values set by the rule type in the code. Then we proceed with merging some of these values with the Kibana config. Because there are issues with lifecycle rule types when `cancelAlertsOnRuleTimeout` is set to false, we log a warning when we see this override in the config and ignore the setting for lifecycle rule types. Persistent rule types (detection rules) will still respect this config override if set. There will be a followup issue to deprecate this config for 9.10 and 8.19. This PR is to address the immediate bug. ## To Verify 1. Set `xpack.alerting.cancelAlertsOnRuleTimeout: false` in the Kibana config and start Kibana. 2. Verify Kibana starts up correctly with no errors. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 69690c9) # Conflicts: # x-pack/platform/plugins/shared/alerting/server/rule_type_registry.test.ts # x-pack/platform/plugins/shared/alerting/server/test_utils/index.ts
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
doakalexi
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:cancelAlertsOnRuleTimeout=falsein kibana config (#222263)Questions ?
Please refer to the Backport tool documentation