Skip to content

[Discover] Add profiles inspector (#184077)#222999

Merged
AlexGPlay merged 13 commits intoelastic:mainfrom
AlexGPlay:184077-add-profiles-inspector
Jul 1, 2025
Merged

[Discover] Add profiles inspector (#184077)#222999
AlexGPlay merged 13 commits intoelastic:mainfrom
AlexGPlay:184077-add-profiles-inspector

Conversation

@AlexGPlay
Copy link
Contributor

@AlexGPlay AlexGPlay commented Jun 6, 2025

Summary

Closes #184077

Adds a new tab to the inspector flyout that shows the contexts/profiles that are currently active.

Grabacion.de.pantalla.2025-06-16.a.las.16.24.30.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@AlexGPlay AlexGPlay force-pushed the 184077-add-profiles-inspector branch 3 times, most recently from a342821 to 935c58a Compare June 19, 2025 13:31
@AlexGPlay AlexGPlay marked this pull request as ready for review June 20, 2025 12:14
@AlexGPlay AlexGPlay requested a review from a team as a code owner June 20, 2025 12:14
@AlexGPlay AlexGPlay self-assigned this Jun 20, 2025
@AlexGPlay AlexGPlay added the Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// label Jun 20, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@AlexGPlay AlexGPlay added release_note:enhancement Feature:Discover Discover Application Project:OneDiscover Enrich Discover with contextual awareness backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 20, 2025
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall and it worked well when testing! I left a bit of feedback, but nothing major.

The only drawback I see to the current approach vs the PoC is that since we're not using observables for the contexts, the profiles info isn't reactive. E.g. if you open the inspector while a search is still running, you won't get the updated document profiles when the search completes unless you close and reopen. That said, it's mainly a debugging tool so I'm not too concerned about it.

@AlexGPlay AlexGPlay force-pushed the 184077-add-profiles-inspector branch from ccc37ce to 3c43773 Compare June 26, 2025 08:55
@AlexGPlay
Copy link
Contributor Author

Changes look good overall and it worked well when testing! I left a bit of feedback, but nothing major.

The only drawback I see to the current approach vs the PoC is that since we're not using observables for the contexts, the profiles info isn't reactive. E.g. if you open the inspector while a search is still running, you won't get the updated document profiles when the search completes unless you close and reopen. That said, it's mainly a debugging tool so I'm not too concerned about it.

yeah, it's more like a snapshot of the profiles - if it doesn't look like this i can rethink it but i guess for now it should be enough

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Great to finally have this for debugging!

@AlexGPlay AlexGPlay added v9.2.0 backport:skip This PR does not require backporting and removed v9.1.0 v8.19.0 backport:version Backport to applied version labels v9.2.0 labels Jun 27, 2025
@AlexGPlay AlexGPlay force-pushed the 184077-add-profiles-inspector branch from d2a374a to cc6e954 Compare June 30, 2025 06:48
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #84 / ESQL execution logic API @ess @serverless ES|QL rule type shard failures should handle shard failures and include warning in logs for query that is not aggregating

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 1339 1352 +13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 1.1MB 1.1MB +6.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 22.0KB 22.4KB +448.0B
Unknown metric groups

async chunk count

id before after diff
discover 38 39 +1

ESLint disabled line counts

id before after diff
discover 15 16 +1

Total ESLint disabled count

id before after diff
discover 17 18 +1

History

cc @AlexGPlay

@AlexGPlay AlexGPlay merged commit b884ae1 into elastic:main Jul 1, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Discover Discover Application needs_docs Project:OneDiscover Enrich Discover with contextual awareness release_note:enhancement Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v9.2.0

5 participants