[Discover] Add profiles inspector (#184077)#222999
Conversation
a342821 to
935c58a
Compare
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
davismcphee
left a comment
There was a problem hiding this comment.
Changes look good overall and it worked well when testing! I left a bit of feedback, but nothing major.
The only drawback I see to the current approach vs the PoC is that since we're not using observables for the contexts, the profiles info isn't reactive. E.g. if you open the inspector while a search is still running, you won't get the updated document profiles when the search completes unless you close and reopen. That said, it's mainly a debugging tool so I'm not too concerned about it.
src/platform/plugins/shared/discover/public/application/main/hooks/use_active_profiles.test.tsx
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/discover/public/application/main/hooks/use_active_profiles.ts
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/discover/public/application/main/hooks/use_active_profiles.ts
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/discover/public/application/main/hooks/use_active_profiles.ts
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/discover/public/application/main/hooks/use_active_profiles.ts
Outdated
Show resolved
Hide resolved
src/platform/plugins/shared/discover/public/application/main/hooks/use_active_profiles.ts
Outdated
Show resolved
Hide resolved
...r/public/context_awareness/inspector/profiles_inspector_view/data_source_profile_section.tsx
Outdated
Show resolved
Hide resolved
.../inspector/profiles_inspector_view/documents_profiles_display/documents_profiles_section.tsx
Outdated
Show resolved
Hide resolved
...m/plugins/shared/discover/public/context_awareness/inspector/get_profiles_inspector_view.tsx
Outdated
Show resolved
Hide resolved
ccc37ce to
3c43773
Compare
yeah, it's more like a snapshot of the profiles - if it doesn't look like this i can rethink it but i guess for now it should be enough |
davismcphee
left a comment
There was a problem hiding this comment.
LGTM 👍 Great to finally have this for debugging!
d2a374a to
cc6e954
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
Total ESLint disabled count
History
cc @AlexGPlay |
Summary
Closes #184077
Adds a new tab to the inspector flyout that shows the contexts/profiles that are currently active.
Grabacion.de.pantalla.2025-06-16.a.las.16.24.30.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.