Skip to content

[Data Streams] Fix forward-compatibility test failures#223129

Merged
ElenaStoeva merged 3 commits intoelastic:mainfrom
ElenaStoeva:data-streams/forward-compatibility-test
Jun 10, 2025
Merged

[Data Streams] Fix forward-compatibility test failures#223129
ElenaStoeva merged 3 commits intoelastic:mainfrom
ElenaStoeva:data-streams/forward-compatibility-test

Conversation

@ElenaStoeva
Copy link
Contributor

@ElenaStoeva ElenaStoeva commented Jun 9, 2025 •
edited by kibanamachine
Loading

Fixes #221224

Summary

This PR fixes the forward-compatibility test for index mode, which failed because the index mode was added to Get Data Streams API in 8.19 and 9.1 (see elastic/elasticsearch#122486), so if Kibana 8.19 is run with Es 9.0, the index mode is always displayed as "Standard" because Es doesn't return an index mode field.

In this PR, we separate all index mode-related tests into a separate file, and only run it for Es versions 8.19 or 9.1+.
@ElenaStoeva ElenaStoeva self-assigned this Jun 9, 2025
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner June 9, 2025 17:33
@ElenaStoeva ElenaStoeva added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 9, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 9, 2025

Pinging @elastic/kibana-management (Team:Kibana Management)
@SoniaSanzV
Copy link
Contributor

SoniaSanzV commented Jun 10, 2025

I have a question @ElenaStoeva! Why removing the old tests instead of adding the this.onlyEsVersion('<=8.18 || 9.0') flag?
@SoniaSanzV SoniaSanzV self-requested a review June 10, 2025 09:23
@ElenaStoeva
Copy link
Contributor Author

ElenaStoeva commented Jun 10, 2025

Thanks for reviewing @SoniaSanzV!

Why removing the old tests instead of adding the this.onlyEsVersion('<=8.18 || 9.0') flag?

this.onlyEsVersion('<=8.18 || 9.0') mutes all tests in the file, rather than just the current describe. Since we only want to mute the index mode tests for 9.0 and we still want to run the rest of the data stream tests, we need to move the index mode tests to a separate file and skip them there. Unless you know a way to skip only the current describe?
@SoniaSanzV
Copy link
Contributor

SoniaSanzV commented Jun 10, 2025

Thanks for reviewing @SoniaSanzV!

Why removing the old tests instead of adding the this.onlyEsVersion('<=8.18 || 9.0') flag?

this.onlyEsVersion('<=8.18 || 9.0') mutes all tests in the file, rather than just the current describe. Since we only want to mute the index mode tests for 9.0 and we still want to run the rest of the data stream tests, we need to move the index mode tests to a separate file and skip them there. Unless you know a way to skip only the current describe?

I didn't know that! Thank you for the explanation!
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 10, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @ElenaStoeva
@ElenaStoeva ElenaStoeva merged commit d12b196 into elastic:main Jun 10, 2025
10 checks passed
@ElenaStoeva ElenaStoeva deleted the data-streams/forward-compatibility-test branch June 10, 2025 12:39
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 10, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15559709620
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 10, 2025
@ElenaStoeva
[Data Streams] Fix forward-compatibility test failures (elastic#223129)
5fa3eb7 
Fixes elastic#221224

## Summary

This PR fixes the forward-compatibility test for index mode, which
failed because the index mode was added to Get Data Streams API in 8.19
and 9.1 (see elastic/elasticsearch#122486), so
if Kibana 8.19 is run with Es 9.0, the index mode is always displayed as
"Standard" because Es doesn't return an index mode field.

In this PR, we separate all index mode-related tests into a separate
file, and only run it for Es versions 8.19 or 9.1+.

(cherry picked from commit d12b196)
@kibanamachine kibanamachine mentioned this pull request Jun 10, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 10, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation
kibanamachine added a commit that referenced this pull request Jun 10, 2025
@kibanamachine @ElenaStoeva
[8.19] [Data Streams] Fix forward-compatibility test failures (#223129)…
a2b6b97 
… (#223226)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Data Streams] Fix forward-compatibility test failures
(#223129)](#223129)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Elena
Stoeva","email":"59341489+ElenaStoeva@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-10T12:38:54Z","message":"[Data
Streams] Fix forward-compatibility test failures (#223129)\n\nFixes
https://github.com/elastic/kibana/issues/221224\n\n## Summary\n\nThis PR
fixes the forward-compatibility test for index mode, which\nfailed
because the index mode was added to Get Data Streams API in 8.19\nand
9.1 (see elastic/elasticsearch#122486), so\nif
Kibana 8.19 is run with Es 9.0, the index mode is always displayed
as\n\"Standard\" because Es doesn't return an index mode field.\n\nIn
this PR, we separate all index mode-related tests into a separate\nfile,
and only run it for Es versions 8.19 or
9.1+.","sha":"d12b19608af35df7ad1c3b38371819b90c926676","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Kibana
Management","release_note:skip","backport:version","v9.1.0","v8.19.0"],"title":"[Data
Streams] Fix forward-compatibility test
failures","number":223129,"url":"https://github.com/elastic/kibana/pull/223129","mergeCommit":{"message":"[Data
Streams] Fix forward-compatibility test failures (#223129)\n\nFixes
https://github.com/elastic/kibana/issues/221224\n\n## Summary\n\nThis PR
fixes the forward-compatibility test for index mode, which\nfailed
because the index mode was added to Get Data Streams API in 8.19\nand
9.1 (see elastic/elasticsearch#122486), so\nif
Kibana 8.19 is run with Es 9.0, the index mode is always displayed
as\n\"Standard\" because Es doesn't return an index mode field.\n\nIn
this PR, we separate all index mode-related tests into a separate\nfile,
and only run it for Es versions 8.19 or
9.1+.","sha":"d12b19608af35df7ad1c3b38371819b90c926676"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223129","number":223129,"mergeCommit":{"message":"[Data
Streams] Fix forward-compatibility test failures (#223129)\n\nFixes
https://github.com/elastic/kibana/issues/221224\n\n## Summary\n\nThis PR
fixes the forward-compatibility test for index mode, which\nfailed
because the index mode was added to Get Data Streams API in 8.19\nand
9.1 (see elastic/elasticsearch#122486), so\nif
Kibana 8.19 is run with Es 9.0, the index mode is always displayed
as\n\"Standard\" because Es doesn't return an index mode field.\n\nIn
this PR, we separate all index mode-related tests into a separate\nfile,
and only run it for Es versions 8.19 or
9.1+.","sha":"d12b19608af35df7ad1c3b38371819b90c926676"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Elena Stoeva <59341489+ElenaStoeva@users.noreply.github.com>
pmuellr pushed a commit to pmuellr/kibana that referenced this pull request Jun 11, 2025
@ElenaStoeva @pmuellr
[Data Streams] Fix forward-compatibility test failures (elastic#223129)
33b58ed 
Fixes elastic#221224

## Summary

This PR fixes the forward-compatibility test for index mode, which
failed because the index mode was added to Get Data Streams API in 8.19
and 9.1 (see elastic/elasticsearch#122486), so
if Kibana 8.19 is run with Es 9.0, the index mode is always displayed as
"Standard" because Es doesn't return an index mode field.

In this PR, we separate all index mode-related tests into a separate
file, and only run it for Es versions 8.19 or 9.1+.
@alisonelizabeth alisonelizabeth mentioned this pull request Jun 12, 2025
Closed
nickpeihl pushed a commit to nickpeihl/kibana that referenced this pull request Jun 12, 2025
@ElenaStoeva @nickpeihl
[Data Streams] Fix forward-compatibility test failures (elastic#223129)
f0c028d 
Fixes elastic#221224

## Summary

This PR fixes the forward-compatibility test for index mode, which
failed because the index mode was added to Get Data Streams API in 8.19
and 9.1 (see elastic/elasticsearch#122486), so
if Kibana 8.19 is run with Es 9.0, the index mode is always displayed as
"Standard" because Es doesn't return an index mode field.

In this PR, we separate all index mode-related tests into a separate
file, and only run it for Es versions 8.19 or 9.1+.
iblancof pushed a commit to iblancof/kibana that referenced this pull request Jun 16, 2025
@ElenaStoeva @iblancof
[Data Streams] Fix forward-compatibility test failures (elastic#223129)
28ee854 
Fixes elastic#221224

## Summary

This PR fixes the forward-compatibility test for index mode, which
failed because the index mode was added to Get Data Streams API in 8.19
and 9.1 (see elastic/elasticsearch#122486), so
if Kibana 8.19 is run with Es 9.0, the index mode is always displayed as
"Standard" because Es doesn't return an index mode field.

In this PR, we separate all index mode-related tests into a separate
file, and only run it for Es versions 8.19 or 9.1+.
@SoniaSanzV SoniaSanzV mentioned this pull request Jun 23, 2025
Merged
SoniaSanzV added a commit that referenced this pull request Jun 25, 2025
@SoniaSanzV @kibanamachine
[Data Streams] Fix forward-compatibility api test failures (#224795)
493ca9f 
Fixes #223990

## Summary

This PR fixes the forward-compatibility test for index mode, which
failed because the index mode was added to Get Data Streams API in 8.19
and 9.1 (see elastic/elasticsearch#122486), so
if Kibana 8.19 is run with Es 9.0, the index mode is always displayed as
"Standard" because Es doesn't return an index mode field.

In this PR, we separate all index mode-related tests into a separate
file, and only run it for Es versions 8.19 or 9.1+.

This was also fixed for functional tests in
#223129

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
SoniaSanzV added a commit to SoniaSanzV/kibana that referenced this pull request Jun 27, 2025
@SoniaSanzV
[Data Streams] Fix forward-compatibility api test failures (elastic#2…
295f742 
…24795)

Fixes elastic#223990

## Summary

This PR fixes the forward-compatibility test for index mode, which
failed because the index mode was added to Get Data Streams API in 8.19
and 9.1 (see elastic/elasticsearch#122486), so
if Kibana 8.19 is run with Es 9.0, the index mode is always displayed as
"Standard" because Es doesn't return an index mode field.

In this PR, we separate all index mode-related tests into a separate
file, and only run it for Es versions 8.19 or 9.1+.

This was also fixed for functional tests in
elastic#223129

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 493ca9f)

# Conflicts:
#	x-pack/platform/test/api_integration/apis/management/index_management/data_streams.ts
SoniaSanzV added a commit that referenced this pull request Jul 2, 2025
@SoniaSanzV @damian-polewski
[8.19] [Data Streams] Fix forward-compatibility api test failures (#2…
3715ca7 
…24795) (#225641)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Data Streams] Fix forward-compatibility api test failures
(#224795)](#224795)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Sonia Sanz
Vivas","email":"sonia.sanzvivas@elastic.co"},"sourceCommit":{"committedDate":"2025-06-25T11:55:46Z","message":"[Data
Streams] Fix forward-compatibility api test failures (#224795)\n\nFixes
https://github.com/elastic/kibana/issues/223990\n\n## Summary\n\nThis PR
fixes the forward-compatibility test for index mode, which\nfailed
because the index mode was added to Get Data Streams API in 8.19\nand
9.1 (see elastic/elasticsearch#122486), so\nif
Kibana 8.19 is run with Es 9.0, the index mode is always displayed
as\n\"Standard\" because Es doesn't return an index mode field.\n\nIn
this PR, we separate all index mode-related tests into a separate\nfile,
and only run it for Es versions 8.19 or 9.1+.\n\nThis was also fixed for
functional tests
in\nhttps://github.com//pull/223129\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"493ca9f1061ab1e451741c6875107d8d16953d23","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Kibana Management","release_note:skip","backport
missing","backport:version","v9.1.0","v8.19.0"],"title":"[Data Streams]
Fix forward-compatibility api test
failures","number":224795,"url":"https://github.com/elastic/kibana/pull/224795","mergeCommit":{"message":"[Data
Streams] Fix forward-compatibility api test failures (#224795)\n\nFixes
https://github.com/elastic/kibana/issues/223990\n\n## Summary\n\nThis PR
fixes the forward-compatibility test for index mode, which\nfailed
because the index mode was added to Get Data Streams API in 8.19\nand
9.1 (see elastic/elasticsearch#122486), so\nif
Kibana 8.19 is run with Es 9.0, the index mode is always displayed
as\n\"Standard\" because Es doesn't return an index mode field.\n\nIn
this PR, we separate all index mode-related tests into a separate\nfile,
and only run it for Es versions 8.19 or 9.1+.\n\nThis was also fixed for
functional tests
in\nhttps://github.com//pull/223129\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"493ca9f1061ab1e451741c6875107d8d16953d23"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224795","number":224795,"mergeCommit":{"message":"[Data
Streams] Fix forward-compatibility api test failures (#224795)\n\nFixes
https://github.com/elastic/kibana/issues/223990\n\n## Summary\n\nThis PR
fixes the forward-compatibility test for index mode, which\nfailed
because the index mode was added to Get Data Streams API in 8.19\nand
9.1 (see elastic/elasticsearch#122486), so\nif
Kibana 8.19 is run with Es 9.0, the index mode is always displayed
as\n\"Standard\" because Es doesn't return an index mode field.\n\nIn
this PR, we separate all index mode-related tests into a separate\nfile,
and only run it for Es versions 8.19 or 9.1+.\n\nThis was also fixed for
functional tests
in\nhttps://github.com//pull/223129\n\n---------\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"493ca9f1061ab1e451741c6875107d8d16953d23"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Damian Polewski <125268832+damian-polewski@users.noreply.github.com>
Co-authored-by: Damian Polewski <damian.polewski@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.19.0 v9.1.0

4 participants

@ElenaStoeva @elasticmachine @SoniaSanzV @kibanamachine